needs a rebase

needs a rebase

needs a rebase

needs a rebase

lock issue detected by clang

rebase, remove now useless hack to skip checkblockindex from D14653

rebase and add a syncwithvalidationinterfacequeue to the test

fix clippy error

revert accidental changes to package(-lock).json

collect the headers_hex

use headers_by_range which simplifies the code a lot

rename helper function json_to_u31. We still return a i32, because that's what all functions expect a block height to be in the node and the indexer, but with the added guarantee that it is >=0 . Returning a u32 would just shift the problem from checking >= 0 to checking <=2**31 -1, while requiring a lot of as i32 conversions when calling the indexer functions.

remove a duplicated test and improve another comment

fix comment in test

the todo is done

comment phrasing nit

rebase on D17496

rebase on D17496

remove unneeded import

same

nit: use format! rather than concat! and save a to_string() conversion

@bot build-explorer

I have a test failing in a later commit due to an assertion in validation.cpp on line 6093 (Assertion pindex->nStatus.isOnParkedChain() || setBlockIndexCandidates.count(pindex)' failed..) I need to check if I missed something here, or if the issue is introduced later.

dedup AssertLockHeld

use a match no that the Err branch is a single liner

leak, complete error messages

rebase to restart CI. I can't figure out why rpc_psbt.py failed, but it is clearly unrelated (nodes[2] never received an inv for the transaction)