Page MenuHomePhabricator
Feed All Stories

Thu, Mar 13

bytesofman updated the diff for D17779: [ecash-wallet] Add method to get spendable sats utxos.

use spendablesatsonlyutxos instead of fuelutxos, make getSpendableCoinbaseUtxos private

Thu, Mar 13, 16:25
bytesofman added inline comments to D17779: [ecash-wallet] Add method to get spendable sats utxos.
Thu, Mar 13, 16:24
teamcity closed T3769: Build Bitcoin-ABC / Master / Sanitizers / Fuzzer is broken. as Resolved.
Thu, Mar 13, 15:54
Fabien closed D17798: [electrum] Update trezor firmware.
Thu, Mar 13, 15:28
Fabien committed rABC163c0d03f1f6: [electrum] Update trezor firmware (authored by Fabien).
[electrum] Update trezor firmware
Thu, Mar 13, 15:28
Fabien requested changes to D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.
Thu, Mar 13, 15:27
PiRK accepted D17798: [electrum] Update trezor firmware.

tested with python3.11 (via AppImage)

Thu, Mar 13, 15:22
Fabien closed D17800: [fuzzer] Fix the validation_load_mempool build.
Thu, Mar 13, 15:15
Fabien committed rABCa88c53babb4e: [fuzzer] Fix the validation_load_mempool build (authored by Fabien).
[fuzzer] Fix the validation_load_mempool build
Thu, Mar 13, 15:15
PiRK accepted D17800: [fuzzer] Fix the validation_load_mempool build.
Thu, Mar 13, 15:12
hazzarust added a comment to D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.

Still need to add comprehensive comments to explain whats going on - will do this later this evening.

Thu, Mar 13, 15:08
hazzarust updated the diff for D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.

lint

Thu, Mar 13, 15:08
Fabien updated the diff for D17798: [electrum] Update trezor firmware.

Don't use python 3.12 syntax

Thu, Mar 13, 15:06
hazzarust updated the diff for D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.

Removed boilerplate and replaced with assert_status_code_eq!()

Thu, Mar 13, 15:04
PiRK requested changes to D17798: [electrum] Update trezor firmware.
Thu, Mar 13, 15:04
Fabien requested review of D17801: [avalanche] Add a mempool isWorthPolling method for txs.
Thu, Mar 13, 15:03
PiRK closed D17797: [electrum] also use patched btchip-python in non-deterministic requirements-hw.txt.
Thu, Mar 13, 14:47
PiRK closed D17796: [electrum] bump hidapi and remove --only-binary workaround.
Thu, Mar 13, 14:47
PiRK committed rABC3a3f70a15b77: [electrum] bump hidapi and remove --only-binary workaround (authored by PiRK).
[electrum] bump hidapi and remove --only-binary workaround
Thu, Mar 13, 14:47
PiRK committed rABCdab327942d2a: [electrum] also use patched btchip-python in non-deterministic requirements-hw. (authored by PiRK).
[electrum] also use patched btchip-python in non-deterministic requirements-hw.
Thu, Mar 13, 14:47
Fabien requested review of D17800: [fuzzer] Fix the validation_load_mempool build.
Thu, Mar 13, 14:47
teamcity triaged T3769: Build Bitcoin-ABC / Master / Sanitizers / Fuzzer is broken. as Unbreak Now! priority.
Thu, Mar 13, 14:36
Fabien committed rABC4bfa18b31d05: [avalanche] Use the block fitter to track the finalized txs statistics (authored by Fabien).
[avalanche] Use the block fitter to track the finalized txs statistics
Thu, Mar 13, 14:24
Fabien closed D17795: [avalanche] Use the block fitter to track the finalized txs statistics.
Thu, Mar 13, 14:24
Fabien closed D17793: Extract the block fitting logic from the block assembler logic.
Thu, Mar 13, 14:24
Fabien committed rABC65cd0d3d2796: Reset the block template in the constructor (authored by Fabien).
Reset the block template in the constructor
Thu, Mar 13, 14:24
Fabien closed D17792: Reset the block template in the constructor.
Thu, Mar 13, 14:24
Fabien committed rABC9ac95e329a2b: Extract the block fitting logic from the block assembler logic (authored by Fabien).
Extract the block fitting logic from the block assembler logic
Thu, Mar 13, 14:24
Fabien closed D17791: Use constants for the coinbase reserved size in the block assembler.
Thu, Mar 13, 14:24
Fabien committed rABCa5d9b7229373: Use constants for the coinbase reserved size in the block assembler (authored by Fabien).
Use constants for the coinbase reserved size in the block assembler
Thu, Mar 13, 14:24
teamcity closed T3768: Build Bitcoin-ABC / Master / Clang is broken. as Resolved.
Thu, Mar 13, 14:23
bytesofman closed D17782: [ecash-lib] Allow use of .only in mocha test files.
Thu, Mar 13, 14:08
bytesofman committed rABC6f6281853271: [ecash-lib] Allow use of .only in mocha test files (authored by bytesofman).
[ecash-lib] Allow use of .only in mocha test files
Thu, Mar 13, 14:08
teamcity triaged T3768: Build Bitcoin-ABC / Master / Clang is broken. as Unbreak Now! priority.
Thu, Mar 13, 13:39
hazzarust closed D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.
Thu, Mar 13, 13:29
hazzarust committed rABCe3e84199d89c: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client (authored by hazzarust).
[chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client
Thu, Mar 13, 13:29
Fabien accepted D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.
Thu, Mar 13, 13:07
hazzarust updated the diff for D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.

Removed test and changed title + summary

Thu, Mar 13, 11:30
hazzarust retitled D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client from [chronik] Add extract_status_code function to bitcoinsuite-chronik-client to [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.
Thu, Mar 13, 11:29
Fabien requested review of D17798: [electrum] Update trezor firmware.
Thu, Mar 13, 10:26
Fabien accepted D17797: [electrum] also use patched btchip-python in non-deterministic requirements-hw.txt.
Thu, Mar 13, 10:17
Fabien accepted D17796: [electrum] bump hidapi and remove --only-binary workaround.
Thu, Mar 13, 10:16
PiRK closed D17777: [electrum] freeze UTXOs that may contain ALP tokens.
Thu, Mar 13, 10:00
PiRK committed rABC5d218549c5d2: [electrum] freeze UTXOs that may contain ALP tokens (authored by PiRK).
[electrum] freeze UTXOs that may contain ALP tokens
Thu, Mar 13, 10:00
PiRK planned changes to D17785: [electrum] install a custom version of trezorlib.
Thu, Mar 13, 09:57
PiRK updated the diff for D17785: [electrum] install a custom version of trezorlib.

rebase on D17797 (extracted some changes not directly related to trezor)

Thu, Mar 13, 09:56
PiRK requested review of D17797: [electrum] also use patched btchip-python in non-deterministic requirements-hw.txt.
Thu, Mar 13, 09:52
PiRK requested review of D17796: [electrum] bump hidapi and remove --only-binary workaround.
Thu, Mar 13, 09:46
PiRK closed D17790: [electrum] build: use pyca/cryptography release version.
Thu, Mar 13, 09:41
PiRK committed rABCe5f570af9696: [electrum] build: use pyca/cryptography release version (authored by EchterAgo).
[electrum] build: use pyca/cryptography release version
Thu, Mar 13, 09:41
Fabien accepted D17790: [electrum] build: use pyca/cryptography release version.
Thu, Mar 13, 08:39
Fabien requested changes to D17774: [ecash-lib-wasm] Add readme with installation instructions.
Thu, Mar 13, 08:38
Fabien added inline comments to D17774: [ecash-lib-wasm] Add readme with installation instructions.
Thu, Mar 13, 08:38
Fabien accepted D17777: [electrum] freeze UTXOs that may contain ALP tokens.
Thu, Mar 13, 08:37
Fabien requested changes to D17778: [Cashtab] Use ecash-lib to sign and verify msgs.

More a question than requesting change here

Thu, Mar 13, 08:36
PiRK added a comment to D17795: [avalanche] Use the block fitter to track the finalized txs statistics.

my review collided with an update that fixed the issue

Thu, Mar 13, 08:17
PiRK accepted D17795: [avalanche] Use the block fitter to track the finalized txs statistics.
Thu, Mar 13, 08:16
PiRK requested changes to D17795: [avalanche] Use the block fitter to track the finalized txs statistics.

This diff somehow pulls blockfitter.cpp into bitcoin-chainstate's dependencies, so you need to add it a second time in CMakeList.txt

Thu, Mar 13, 08:15
Fabien updated the diff for D17795: [avalanche] Use the block fitter to track the finalized txs statistics.

The blockfitter now needs to be part of the kernel for bitcoin-chainstate to build

Thu, Mar 13, 08:13
PiRK accepted D17793: Extract the block fitting logic from the block assembler logic.
Thu, Mar 13, 08:10
PiRK accepted D17792: Reset the block template in the constructor.
Thu, Mar 13, 07:55
PiRK accepted D17791: Use constants for the coinbase reserved size in the block assembler.
Thu, Mar 13, 07:52
PiRK closed D17787: [electrum] enable the Build Avalanche Proof context menu action when possible for Trezor wallets.
Thu, Mar 13, 07:46
PiRK committed rABC41118e547b70: [electrum] enable the Build Avalanche Proof context menu action when possible… (authored by PiRK).
[electrum] enable the Build Avalanche Proof context menu action when possible…
Thu, Mar 13, 07:46
PiRK updated the summary of D17787: [electrum] enable the Build Avalanche Proof context menu action when possible for Trezor wallets.
Thu, Mar 13, 07:45
emack updated the diff for D17774: [ecash-lib-wasm] Add readme with installation instructions.

Linked docker installation guide

Thu, Mar 13, 06:01
emack accepted D17782: [ecash-lib] Allow use of .only in mocha test files.
Thu, Mar 13, 05:52
tobias_ruck requested changes to D17779: [ecash-wallet] Add method to get spendable sats utxos.
Thu, Mar 13, 04:34

Wed, Mar 12

bytesofman closed D17794: [Cashtab] Add POW to agora landing page.
Wed, Mar 12, 21:24
bytesofman committed rABC0bb8a45a6dd6: [Cashtab] Add POW to agora landing page (authored by bytesofman).
[Cashtab] Add POW to agora landing page
Wed, Mar 12, 21:24
Mengerian accepted D17794: [Cashtab] Add POW to agora landing page.
Wed, Mar 12, 21:22
teamcity added a comment to D17795: [avalanche] Use the block fitter to track the finalized txs statistics.
Wed, Mar 12, 21:21
Fabien requested review of D17795: [avalanche] Use the block fitter to track the finalized txs statistics.
Wed, Mar 12, 21:16
bytesofman published D17794: [Cashtab] Add POW to agora landing page for review.
Wed, Mar 12, 21:11
Fabien accepted D17787: [electrum] enable the Build Avalanche Proof context menu action when possible for Trezor wallets.
Wed, Mar 12, 20:55
bytesofman closed D17786: [Cashtab] Patch header links to token page in extension.
Wed, Mar 12, 20:52
bytesofman committed rABCc00fa844c161: [Cashtab] Patch header links to token page in extension (authored by bytesofman).
[Cashtab] Patch header links to token page in extension
Wed, Mar 12, 20:52
Fabien requested review of D17793: Extract the block fitting logic from the block assembler logic.
Wed, Mar 12, 20:45
Fabien requested review of D17792: Reset the block template in the constructor.
Wed, Mar 12, 20:38
Fabien requested review of D17791: Use constants for the coinbase reserved size in the block assembler.
Wed, Mar 12, 20:30
bytesofman updated the diff for D17778: [Cashtab] Use ecash-lib to sign and verify msgs.

add comments for verifyMsg

Wed, Mar 12, 20:24
bytesofman added inline comments to D17778: [Cashtab] Use ecash-lib to sign and verify msgs.
Wed, Mar 12, 20:24
Fabien added inline comments to D17778: [Cashtab] Use ecash-lib to sign and verify msgs.
Wed, Mar 12, 20:24
teamcity updated the summary of D17790: [electrum] build: use pyca/cryptography release version.
Wed, Mar 12, 19:49
PiRK requested review of D17790: [electrum] build: use pyca/cryptography release version.
Wed, Mar 12, 19:49
roqqit planned changes to D17788: [avalanche] Move contender cache to peer manager.
Wed, Mar 12, 19:39
teamcity added a comment to D17788: [avalanche] Move contender cache to peer manager.
Wed, Mar 12, 19:31
teamcity added a comment to D17788: [avalanche] Move contender cache to peer manager.
Wed, Mar 12, 19:28
teamcity added a comment to D17788: [avalanche] Move contender cache to peer manager.
Wed, Mar 12, 19:28
Fabien requested changes to D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.

Please update your title and summary

Wed, Mar 12, 19:27
roqqit requested review of D17788: [avalanche] Move contender cache to peer manager.
Wed, Mar 12, 19:26
PiRK accepted D17786: [Cashtab] Patch header links to token page in extension.
Wed, Mar 12, 18:55
PiRK updated the diff for D17777: [electrum] freeze UTXOs that may contain ALP tokens.

feedback + handle case of same transaction added twice without clearing first (don't duplicate outpoints, don't even bother rescanning the transaction)

Wed, Mar 12, 18:54
PiRK requested review of D17787: [electrum] enable the Build Avalanche Proof context menu action when possible for Trezor wallets.
Wed, Mar 12, 18:40
PiRK published D17785: [electrum] install a custom version of trezorlib for review.
Wed, Mar 12, 18:23
bytesofman published D17786: [Cashtab] Patch header links to token page in extension for review.
Wed, Mar 12, 17:23
hazzarust updated the diff for D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.

lint

Wed, Mar 12, 17:08
hazzarust updated the diff for D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.

Removed the impl function and made into macro

Wed, Mar 12, 17:07
bytesofman closed D17775: [Cashtab] Show XECX sweeper balance and notice if user redemption will not be instant.
Wed, Mar 12, 16:44
bytesofman committed rABC212529d453fa: [Cashtab] Show XECX sweeper balance and notice if user redemption will not be… (authored by bytesofman).
[Cashtab] Show XECX sweeper balance and notice if user redemption will not be…
Wed, Mar 12, 16:44