Page MenuHomePhabricator
Feed All Stories

Mar 12 2025

bytesofman requested review of D17782: [ecash-lib] Allow use of .only in mocha test files.

Add .only to a test file in ecash-lib, run arc lint, get a lint error, remove it, all good, npm test with a test using .only and only that test runs

I added .only to describe('SLP Integration Test') and it is not the only test that is run.

image.png (840×692 px, 96 KB)

Mar 12 2025, 16:19
Fabien added inline comments to D17777: [electrum] freeze UTXOs that may contain ALP tokens.
Mar 12 2025, 16:18
PiRK added inline comments to D17777: [electrum] freeze UTXOs that may contain ALP tokens.
Mar 12 2025, 16:09
Fabien added inline comments to D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.
Mar 12 2025, 14:17
Fabien requested changes to D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.
Mar 12 2025, 14:15
hazzarust requested review of D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.
Mar 12 2025, 14:13
Fabien requested changes to D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.
Mar 12 2025, 13:39
Fabien requested changes to D17778: [Cashtab] Use ecash-lib to sign and verify msgs.
Mar 12 2025, 13:36
Fabien requested changes to D17777: [electrum] freeze UTXOs that may contain ALP tokens.
Mar 12 2025, 13:24
hazzarust updated the summary of D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.
Mar 12 2025, 12:07
hazzarust updated the summary of D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.
Mar 12 2025, 12:07
hazzarust requested review of D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.
Mar 12 2025, 12:03
emack accepted D17775: [Cashtab] Show XECX sweeper balance and notice if user redemption will not be instant.
Mar 12 2025, 04:05
emack requested changes to D17782: [ecash-lib] Allow use of .only in mocha test files.

Add .only to a test file in ecash-lib, run arc lint, get a lint error, remove it, all good, npm test with a test using .only and only that test runs

Mar 12 2025, 04:04
bytesofman added inline comments to D17778: [Cashtab] Use ecash-lib to sign and verify msgs.
Mar 12 2025, 03:50
bytesofman requested review of D17775: [Cashtab] Show XECX sweeper balance and notice if user redemption will not be instant.
Mar 12 2025, 03:27
emack requested changes to D17775: [Cashtab] Show XECX sweeper balance and notice if user redemption will not be instant.
Mar 12 2025, 02:11

Mar 11 2025

bytesofman published D17782: [ecash-lib] Allow use of .only in mocha test files for review.
Mar 11 2025, 23:11
bytesofman published D17778: [Cashtab] Use ecash-lib to sign and verify msgs for review.
Mar 11 2025, 23:10
Fabien committed rABC66fb757a1fb5: [ci] Fix wasm install with newer rust versions (authored by Fabien).
[ci] Fix wasm install with newer rust versions
Mar 11 2025, 21:13
Fabien closed D17780: [ci] Fix wasm install with newer rust versions.
Mar 11 2025, 21:13
Fabien closed D17781: [chronik] Bump corrosion to 0.5.1.
Mar 11 2025, 21:13
Fabien committed rABCe522e2476965: [chronik] Bump corrosion to 0.5.1 (authored by Fabien).
[chronik] Bump corrosion to 0.5.1
Mar 11 2025, 21:13
bytesofman accepted D17781: [chronik] Bump corrosion to 0.5.1.
Mar 11 2025, 21:12
bytesofman accepted D17780: [ci] Fix wasm install with newer rust versions.
Mar 11 2025, 21:12
Fabien accepted D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
Mar 11 2025, 21:08
PiRK updated the diff for D17777: [electrum] freeze UTXOs that may contain ALP tokens.

minor UI improvement (change the greyed out spend action text to tell why the coin is unspendable)

Mar 11 2025, 20:59
Fabien requested review of D17781: [chronik] Bump corrosion to 0.5.1.
Mar 11 2025, 20:59
PiRK updated the summary of D17777: [electrum] freeze UTXOs that may contain ALP tokens.
Mar 11 2025, 20:50
bytesofman updated the diff for D17779: [ecash-wallet] Add method to get spendable sats utxos.

no arrow syntax, stop testing files that do not yet exist, use correct COINBASE_MATURITY term, clean up comments

Mar 11 2025, 20:34
tobias_ruck requested changes to D17779: [ecash-wallet] Add method to get spendable sats utxos.

Some initial comments

Mar 11 2025, 20:15
PiRK published D17777: [electrum] freeze UTXOs that may contain ALP tokens for review.
Mar 11 2025, 19:56
Fabien requested review of D17780: [ci] Fix wasm install with newer rust versions.
Mar 11 2025, 19:47
bytesofman updated the diff for D17779: [ecash-wallet] Add method to get spendable sats utxos.

do not assume coinbase utxos cannot be tokens, add token utxos to tests to show we do not get them as fuel utxos

Mar 11 2025, 18:27
bytesofman published D17779: [ecash-wallet] Add method to get spendable sats utxos for review.
Mar 11 2025, 18:16
bytesofman closed D17776: [ecash-agora] Support full-accept agora partials.
Mar 11 2025, 16:15
bytesofman committed rABCc92a2d2520d0: [ecash-agora] Support full-accept agora partials (authored by bytesofman).
[ecash-agora] Support full-accept agora partials
Mar 11 2025, 16:15
tobias_ruck accepted D17776: [ecash-agora] Support full-accept agora partials.
Mar 11 2025, 15:31
bytesofman accepted D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.
Mar 11 2025, 15:10
bytesofman published D17776: [ecash-agora] Support full-accept agora partials for review.
Mar 11 2025, 15:08
alitayin updated the diff for D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

An attempt to resolve a missing base commit

Mar 11 2025, 15:01
bytesofman added a comment to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

otherwise the code is fine, diff is ready to roll with exception of mystery git basis / arc patch issue

Mar 11 2025, 13:32
bytesofman added a comment to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

mb it's not the best git-fu but in my experience it's almost always easier to recreate a diff with a single commit when phab/git raise issues (vs attempt to squash / update all the necessary arcanist stuff...who knows what's in there or what it was originally based on).

Mar 11 2025, 13:27
bytesofman requested changes to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

looks like this is not based on the latest master or is accidentally a stack

Mar 11 2025, 13:17
bytesofman requested changes to D17774: [ecash-lib-wasm] Add readme with installation instructions.
Mar 11 2025, 13:14
bytesofman published D17775: [Cashtab] Show XECX sweeper balance and notice if user redemption will not be instant for review.
Mar 11 2025, 13:12
emack requested review of D17774: [ecash-lib-wasm] Add readme with installation instructions.
Mar 11 2025, 04:53
emack accepted D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Tested all ok across chrome and firefox.

Mar 11 2025, 04:17

Mar 10 2025

tobias_ruck updated the diff for D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.

fix it description

Mar 10 2025, 23:02
tobias_ruck updated the diff for D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
  • add test for all root certs
  • fix handling of NULL parameters in readAlgIdent
  • err on invalid date instead of setting it to 0
Mar 10 2025, 23:01
bytesofman closed D17773: [ecash-wallet] Init ecash-wallet in monorepo.
Mar 10 2025, 22:54
bytesofman committed rABCaebc4cb1bd74: [ecash-wallet] Init ecash-wallet in monorepo (authored by bytesofman).
[ecash-wallet] Init ecash-wallet in monorepo
Mar 10 2025, 22:54
tobias_ruck accepted D17773: [ecash-wallet] Init ecash-wallet in monorepo.
Mar 10 2025, 22:28
bytesofman updated the diff for D17773: [ecash-wallet] Init ecash-wallet in monorepo.

remove another XecWallet mention

Mar 10 2025, 21:51
bytesofman updated the diff for D17773: [ecash-wallet] Init ecash-wallet in monorepo.

more fixes from the rename and constructor change, better property comments

Mar 10 2025, 21:51
tobias_ruck requested changes to D17773: [ecash-wallet] Init ecash-wallet in monorepo.
Mar 10 2025, 21:45
Fabien closed D17771: [avalanche] Remove useless timeout in the tx finalization test.
Mar 10 2025, 21:31
Fabien committed rABC45b81d2fa789: [avalanche] Remove useless timeout in the tx finalization test (authored by Fabien).
[avalanche] Remove useless timeout in the tx finalization test
Mar 10 2025, 21:31
bytesofman updated the diff for D17773: [ecash-wallet] Init ecash-wallet in monorepo.

remove redundant interface, change name to Wallet, private constructor with fromSk static method helper constructor

Mar 10 2025, 21:13
bytesofman added inline comments to D17773: [ecash-wallet] Init ecash-wallet in monorepo.
Mar 10 2025, 21:12
tobias_ruck requested changes to D17773: [ecash-wallet] Init ecash-wallet in monorepo.
Mar 10 2025, 18:43
bytesofman published D17773: [ecash-wallet] Init ecash-wallet in monorepo for review.
Mar 10 2025, 18:33
teamcity closed T3767: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 64 is broken. as Resolved.
Mar 10 2025, 17:27
bytesofman committed rABC73355376b907: [Cashtab] Patch flaky test in XECX redemption workflow (authored by bytesofman).
[Cashtab] Patch flaky test in XECX redemption workflow
Mar 10 2025, 16:55
bytesofman closed D17772: [Cashtab] Patch flaky test in XECX redemption workflow.
Mar 10 2025, 16:55
Fabien accepted D17772: [Cashtab] Patch flaky test in XECX redemption workflow.
Mar 10 2025, 16:49
bytesofman published D17772: [Cashtab] Patch flaky test in XECX redemption workflow for review.
Mar 10 2025, 16:48
PiRK accepted D17771: [avalanche] Remove useless timeout in the tx finalization test.
Mar 10 2025, 16:04
Fabien requested review of D17771: [avalanche] Remove useless timeout in the tx finalization test.
Mar 10 2025, 15:15
teamcity triaged T3767: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 64 is broken. as Unbreak Now! priority.
Mar 10 2025, 15:11
Fabien committed rABCc9a42a9daf58: [electrum] Add native eCash support for compatible Trezor One firmware (authored by Fabien).
[electrum] Add native eCash support for compatible Trezor One firmware
Mar 10 2025, 14:45
Fabien closed D17770: [electrum] Add native eCash support for compatible Trezor One firmware.
Mar 10 2025, 14:45
Fabien retitled D17770: [electrum] Add native eCash support for compatible Trezor One firmware from [electrum] Has native eCash support for compatible Trezor One firmware to [electrum] Add native eCash support for compatible Trezor One firmware.
Mar 10 2025, 14:45
PiRK accepted D17770: [electrum] Add native eCash support for compatible Trezor One firmware.
Mar 10 2025, 13:29
Fabien requested review of D17770: [electrum] Add native eCash support for compatible Trezor One firmware.
Mar 10 2025, 13:26
lisafabian19 set Slack Username to https://slack.com/shortcuts/Ft08G521HHQU/36e21e4f8c9041011e7378fd9c7db327 on lisafabian19.
Mar 10 2025, 07:29
alitayin updated the diff for D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

[Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling

Mar 10 2025, 03:54
alitayin updated the diff for D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

lint

Mar 10 2025, 03:47
alitayin updated the diff for D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

remove stopPropagation

Mar 10 2025, 03:43
alitayin updated the diff for D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Updating D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling

Mar 10 2025, 02:53

Mar 9 2025

teamcity closed T3766: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Mar 9 2025, 22:20
abc-bot committed rABC077dd7225437: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Mar 9 2025, 22:17
abc-bot committed rABCae9be6d42fd8: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Mar 9 2025, 22:08
teamcity triaged T3766: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Mar 9 2025, 21:54
abc-bot committed rABCbe361ec6ae93: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Mar 9 2025, 21:39

Mar 8 2025

bytesofman closed D17762: [lint patch] resolve arc lint issue.
Mar 8 2025, 05:18
bytesofman committed rABC78cdc63e02a8: [lint patch] resolve arc lint issue (authored by bytesofman).
[lint patch] resolve arc lint issue
Mar 8 2025, 05:18
bytesofman closed D17755: [monorepo] eslint all the js with a single version-pinned flat config.
Mar 8 2025, 05:16
bytesofman committed rABC55f5da822801: [monorepo] eslint all the js with a single version-pinned flat config (authored by bytesofman).
[monorepo] eslint all the js with a single version-pinned flat config
Mar 8 2025, 05:16
emack accepted D17755: [monorepo] eslint all the js with a single version-pinned flat config.
Mar 8 2025, 04:37

Mar 7 2025

Kronkmeister committed rABCa5323bdbebad: [e.cash] Updated high quality Pay2Stay Logo for use-ecash page (authored by Kronkmeister).
[e.cash] Updated high quality Pay2Stay Logo for use-ecash page
Mar 7 2025, 22:14
Kronkmeister closed D17767: [e.cash] Updated high quality Pay2Stay Logo for use-ecash page.
Mar 7 2025, 22:14
Fabien accepted D17767: [e.cash] Updated high quality Pay2Stay Logo for use-ecash page.
Mar 7 2025, 22:00
Fabien added a comment to D17767: [e.cash] Updated high quality Pay2Stay Logo for use-ecash page.

Not sure why the builds failed and the bot doesn't respond. The change works on my end. Lints say there's nothing to lint (since it's just updating an image file).

Mar 7 2025, 21:59
teamcity added a comment to D17767: [e.cash] Updated high quality Pay2Stay Logo for use-ecash page.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.178.130.230:41749 for the next 60 minutes.

Mar 7 2025, 21:56
teamcity awarded D17767: [e.cash] Updated high quality Pay2Stay Logo for use-ecash page a Haypence token.
Mar 7 2025, 21:54
Kronkmeister added a comment to D17767: [e.cash] Updated high quality Pay2Stay Logo for use-ecash page.

Not sure why the builds failed and the bot doesn't respond. The change works on my end. Lints say there's nothing to lint (since it's just updating an image file).

Mar 7 2025, 21:14
Kronkmeister added a comment to D17767: [e.cash] Updated high quality Pay2Stay Logo for use-ecash page.

@bot preview-e.cash

Mar 7 2025, 21:04
Kronkmeister retitled D17767: [e.cash] Updated high quality Pay2Stay Logo for use-ecash page from Updated high quality Pay2Stay Logo for use-ecash page to [e.cash] Updated high quality Pay2Stay Logo for use-ecash page.
Mar 7 2025, 20:58
Kronkmeister published D17767: [e.cash] Updated high quality Pay2Stay Logo for use-ecash page for review.
Mar 7 2025, 20:57