Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Tue, Mar 18

PiRK committed rABCcd9dcc148d47: [electrum] install a custom version of trezorlib (authored by PiRK).
[electrum] install a custom version of trezorlib
Tue, Mar 18, 14:48
Fabien accepted D17785: [electrum] install a custom version of trezorlib.
Tue, Mar 18, 14:28
Fabien committed rABC704a35e44233: [electrum] Install custom eCash firmware on Trezor (authored by Fabien).
[electrum] Install custom eCash firmware on Trezor
Tue, Mar 18, 14:18
PiRK updated the diff for D17785: [electrum] install a custom version of trezorlib.

use slip10 1.0.1 to better satisfy the trezorlib >= 1.0.1 requirements (the AppImage build works with 1.0.0, but with more recent versions of pip the conflict becomes an error)

Tue, Mar 18, 12:07
teamcity triaged T3771: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX Linux is broken. as Unbreak Now! priority.
Tue, Mar 18, 12:00
PiRK planned changes to D17785: [electrum] install a custom version of trezorlib.
Tue, Mar 18, 11:35
PiRK updated the diff for D17785: [electrum] install a custom version of trezorlib.

update the repo and commit hash to ecash/2.8.9 tag from the Bitcoin ABC repo

Tue, Mar 18, 08:23
emack accepted D17814: [chronik-client] Patch failoverProxy to recognize another type of server failure.
Tue, Mar 18, 04:07
bytesofman updated the test plan for D17814: [chronik-client] Patch failoverProxy to recognize another type of server failure.
Tue, Mar 18, 04:05

Mon, Mar 17

bytesofman published D17814: [chronik-client] Patch failoverProxy to recognize another type of server failure for review.
Mon, Mar 17, 23:50
roqqit closed D17813: [avalanche] Cleanup circular dependency between peer manager and contender cache.
Mon, Mar 17, 22:10
roqqit committed rABCcf38f5e5d94a: [avalanche] Cleanup circular dependency between peer manager and contender cache (authored by roqqit).
[avalanche] Cleanup circular dependency between peer manager and contender cache
Mon, Mar 17, 22:10
Fabien accepted D17813: [avalanche] Cleanup circular dependency between peer manager and contender cache.
Mon, Mar 17, 21:39
roqqit requested review of D17813: [avalanche] Cleanup circular dependency between peer manager and contender cache.
Mon, Mar 17, 19:44
PiRK committed rABCceb2d83868fc: [electrum] make it possible to spend tokens by manually selecting the coins to… (authored by PiRK).
[electrum] make it possible to spend tokens by manually selecting the coins to…
Mon, Mar 17, 14:08
PiRK closed D17809: [electrum] make it possible to spend tokens by manually selecting the coins to spend.
Mon, Mar 17, 14:08
PiRK closed D17808: [electrum] properly exclude ALP tokens when sending XEC.
Mon, Mar 17, 14:08
PiRK committed rABC0e9f232bbe91: [electrum] properly exclude ALP tokens when sending XEC (authored by PiRK).
[electrum] properly exclude ALP tokens when sending XEC
Mon, Mar 17, 14:08
Fabien accepted D17808: [electrum] properly exclude ALP tokens when sending XEC.
Mon, Mar 17, 13:03
PiRK added inline comments to D17808: [electrum] properly exclude ALP tokens when sending XEC.
Mon, Mar 17, 09:23
PiRK updated the diff for D17808: [electrum] properly exclude ALP tokens when sending XEC.

factor the token detection into a wallet.has_tokens(coin) method and fix one more thing that could cause accidental spending of ALP tokens (for users who enabled "Spend only fused coins", if a token is sent to the same address as a fused coin)

Mon, Mar 17, 09:19
PiRK closed D17806: [electrum] Make the coin consolidator not burn alp tokens.
Mon, Mar 17, 08:57
PiRK committed rABCf9a8f5d46c53: [electrum] Make the coin consolidator not burn alp tokens (authored by PiRK).
[electrum] Make the coin consolidator not burn alp tokens
Mon, Mar 17, 08:57
bytesofman closed D17812: [Cashtab] Move native2 to top.
Mon, Mar 17, 05:04
bytesofman committed rABC53526c84d87f: [Cashtab] Move native2 to top (authored by bytesofman).
[Cashtab] Move native2 to top
Mon, Mar 17, 05:04
Fabien accepted D17812: [Cashtab] Move native2 to top.
Mon, Mar 17, 05:03
bytesofman published D17812: [Cashtab] Move native2 to top for review.
Mon, Mar 17, 05:03
emack committed rABCd366dd0addf2: [ecash-lib-wasm] Add readme with installation instructions (authored by emack).
[ecash-lib-wasm] Add readme with installation instructions
Mon, Mar 17, 01:30
emack closed D17774: [ecash-lib-wasm] Add readme with installation instructions.
Mon, Mar 17, 01:30

Sun, Mar 16

alitayin closed D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.
Sun, Mar 16, 23:09
alitayin committed rABC767f0d39a1db: [Cashtab] Add click-outside-area closing effect for NavWrapper using event… (authored by alitayin).
[Cashtab] Add click-outside-area closing effect for NavWrapper using event…
Sun, Mar 16, 23:09
abc-bot committed rABC162b1b98aea7: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Sun, Mar 16, 22:15
abc-bot committed rABC4099c92fd42e: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Sun, Mar 16, 22:11
abc-bot committed rABC469d2b161187: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Sun, Mar 16, 21:38
Fabien requested changes to D17808: [electrum] properly exclude ALP tokens when sending XEC.
Sun, Mar 16, 19:24
Fabien accepted D17809: [electrum] make it possible to spend tokens by manually selecting the coins to spend.
Sun, Mar 16, 19:22
Fabien accepted D17774: [ecash-lib-wasm] Add readme with installation instructions.
Sun, Mar 16, 19:19
emack updated the diff for D17774: [ecash-lib-wasm] Add readme with installation instructions.

updated readme

Sun, Mar 16, 13:29
bytesofman accepted D17774: [ecash-lib-wasm] Add readme with installation instructions.
Sun, Mar 16, 13:19
emack updated the diff for D17774: [ecash-lib-wasm] Add readme with installation instructions.

updated readme

Sun, Mar 16, 00:30

Sat, Mar 15

bytesofman closed D17811: [ecash-wallet] Move wallet class code and tests to wallet files, use an indext file for exports.
Sat, Mar 15, 23:03
bytesofman committed rABC38169309a7b3: [ecash-wallet] Move wallet class code and tests to wallet files, use an indext… (authored by bytesofman).
[ecash-wallet] Move wallet class code and tests to wallet files, use an indext…
Sat, Mar 15, 23:03
bytesofman accepted D17806: [electrum] Make the coin consolidator not burn alp tokens.
Sat, Mar 15, 22:49
hazzarust closed D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.
Sat, Mar 15, 17:24
hazzarust committed rABC18cf3e52f32d: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite… (authored by hazzarust).
[chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite…
Sat, Mar 15, 17:24
tobias_ruck closed D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
Sat, Mar 15, 08:21
tobias_ruck committed rABC612231e6d8eb: [ecash-lib] Add `payment` with `asn1` and `x509` (authored by tobias_ruck).
[ecash-lib] Add `payment` with `asn1` and `x509`
Sat, Mar 15, 08:21
tobias_ruck accepted D17811: [ecash-wallet] Move wallet class code and tests to wallet files, use an indext file for exports.
Sat, Mar 15, 08:20
PiRK added a comment to D17806: [electrum] Make the coin consolidator not burn alp tokens.
In D17806#405784, @bytesofman wrote:

TIL coin consolidator is a thing in electrum

how is this used in the GUI? is this just called in normal tx building?

Sat, Mar 15, 07:08

Fri, Mar 14

bytesofman published D17811: [ecash-wallet] Move wallet class code and tests to wallet files, use an indext file for exports for review.
Fri, Mar 14, 21:47
bytesofman closed D17779: [ecash-wallet] Add method to get spendable sats utxos.
Fri, Mar 14, 21:41
bytesofman committed rABCd0ecde3d1500: [ecash-wallet] Add method to get spendable sats utxos (authored by bytesofman).
[ecash-wallet] Add method to get spendable sats utxos
Fri, Mar 14, 21:41
tobias_ruck accepted D17779: [ecash-wallet] Add method to get spendable sats utxos.
Fri, Mar 14, 21:38
tobias_ruck updated the diff for D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.

as discussed, rename alg.alg -> alg.oid

Fri, Mar 14, 21:33
bytesofman updated the diff for D17779: [ecash-wallet] Add method to get spendable sats utxos.

tighten up comments, remove "get" prefix from utxo selection methods

Fri, Mar 14, 21:04
bytesofman added inline comments to D17779: [ecash-wallet] Add method to get spendable sats utxos.
Fri, Mar 14, 21:03
roqqit closed D17788: [avalanche] Move contender cache to peer manager.
Fri, Mar 14, 20:40
roqqit committed rABC821580a6ab15: [avalanche] Move contender cache to peer manager (authored by roqqit).
[avalanche] Move contender cache to peer manager
Fri, Mar 14, 20:40
Fabien accepted D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.
Fri, Mar 14, 20:36
tobias_ruck requested changes to D17779: [ecash-wallet] Add method to get spendable sats utxos.
Fri, Mar 14, 19:57
bytesofman added a comment to D17806: [electrum] Make the coin consolidator not burn alp tokens.

TIL coin consolidator is a thing in electrum

Fri, Mar 14, 17:38
bytesofman abandoned D17802: [Cashtab] Correct issue of two tests with the same name.

another diff just deleted the test

Fri, Mar 14, 17:28
bytesofman closed D17807: [token-server] Soften recaptcha check.
Fri, Mar 14, 16:01
bytesofman committed rABC459f2bd542e5: [token-server] Soften recaptcha check (authored by bytesofman).
[token-server] Soften recaptcha check
Fri, Mar 14, 16:01
PiRK accepted D17807: [token-server] Soften recaptcha check.
Fri, Mar 14, 14:32
PiRK added a comment to D17808: [electrum] properly exclude ALP tokens when sending XEC.

As an additional test I'm also going to try to be in a few CashFusion rounds to confirm no tokens are burned. But I cannot guarantee the tests will be conclusive in a timely manner.

Fri, Mar 14, 14:30
PiRK requested review of D17809: [electrum] make it possible to spend tokens by manually selecting the coins to spend.
Fri, Mar 14, 14:29
PiRK updated the summary of D17808: [electrum] properly exclude ALP tokens when sending XEC.
Fri, Mar 14, 14:21
PiRK requested review of D17808: [electrum] properly exclude ALP tokens when sending XEC.
Fri, Mar 14, 14:20
bytesofman updated the diff for D17779: [ecash-wallet] Add method to get spendable sats utxos.

rebase

Fri, Mar 14, 13:43
bytesofman retitled D17779: [ecash-wallet] Add method to get spendable sats utxos from [ecash-wallet] Add method to get fuel utxos, i.e. utxos used to send eCash or fuel token txs to [ecash-wallet] Add method to get spendable sats utxos.
Fri, Mar 14, 13:39
bytesofman published D17807: [token-server] Soften recaptcha check for review.
Fri, Mar 14, 13:33
bytesofman closed D17804: [Cashtab] Use ecash-lib for HDNode.
Fri, Mar 14, 13:33
bytesofman committed rABC72d6eb29573c: [Cashtab] Use ecash-lib for HDNode (authored by bytesofman).
[Cashtab] Use ecash-lib for HDNode
Fri, Mar 14, 13:33
bytesofman requested changes to D17774: [ecash-lib-wasm] Add readme with installation instructions.
Fri, Mar 14, 13:27
hazzarust updated the diff for D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.

lint

Fri, Mar 14, 13:06
hazzarust updated the diff for D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.

Remove useless comments

Fri, Mar 14, 13:05
PiRK requested review of D17806: [electrum] Make the coin consolidator not burn alp tokens.
Fri, Mar 14, 12:39
emack updated the diff for D17774: [ecash-lib-wasm] Add readme with installation instructions.

Updated readme

Fri, Mar 14, 05:19
emack accepted D17804: [Cashtab] Use ecash-lib for HDNode.
Fri, Mar 14, 05:07

Thu, Mar 13

bytesofman published D17804: [Cashtab] Use ecash-lib for HDNode for review.
Thu, Mar 13, 23:36
bytesofman closed D17778: [Cashtab] Use ecash-lib to sign and verify msgs.
Thu, Mar 13, 22:40
bytesofman committed rABC5c1b0068bb80: [Cashtab] Use ecash-lib to sign and verify msgs (authored by bytesofman).
[Cashtab] Use ecash-lib to sign and verify msgs
Thu, Mar 13, 22:40
bytesofman closed D17803: [Cashtab] Drop test causing problems in CI.
Thu, Mar 13, 22:10
bytesofman committed rABCcf49ef6cf520: [Cashtab] Drop test causing problems in CI (authored by bytesofman).
[Cashtab] Drop test causing problems in CI
Thu, Mar 13, 22:10
bytesofman updated the diff for D17779: [ecash-wallet] Add method to get spendable sats utxos.

rebase, correct indefinite article in test name

Thu, Mar 13, 22:09
Fabien accepted D17778: [Cashtab] Use ecash-lib to sign and verify msgs.
Thu, Mar 13, 21:12
Fabien committed rABCc35bd582d99f: [avalanche] Add a mempool isWorthPolling method for txs (authored by Fabien).
[avalanche] Add a mempool isWorthPolling method for txs
Thu, Mar 13, 21:09
Fabien closed D17801: [avalanche] Add a mempool isWorthPolling method for txs.
Thu, Mar 13, 21:09
teamcity added a comment to D17803: [Cashtab] Drop test causing problems in CI.
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Thu, Mar 13, 21:08
Fabien accepted D17803: [Cashtab] Drop test causing problems in CI.
Thu, Mar 13, 21:08
Fabien accepted D17788: [avalanche] Move contender cache to peer manager.
Thu, Mar 13, 21:05
bytesofman updated the diff for D17803: [Cashtab] Drop test causing problems in CI.

remove other test that appears to fail for the same reason

Thu, Mar 13, 21:05
bytesofman published D17803: [Cashtab] Drop test causing problems in CI for review.
Thu, Mar 13, 21:01
hazzarust updated the diff for D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.

Added comments from TS implementation into this implementation

Thu, Mar 13, 19:30
roqqit updated the diff for D17788: [avalanche] Move contender cache to peer manager.
  • add lint exception for circular dependency
  • fix lock annotations
Thu, Mar 13, 18:07
roqqit accepted D17801: [avalanche] Add a mempool isWorthPolling method for txs.
Thu, Mar 13, 17:57
roqqit accepted D17802: [Cashtab] Correct issue of two tests with the same name.
Thu, Mar 13, 17:56
bytesofman requested review of D17778: [Cashtab] Use ecash-lib to sign and verify msgs.
Thu, Mar 13, 17:05
bytesofman published D17802: [Cashtab] Correct issue of two tests with the same name for review.
Thu, Mar 13, 16:26
First
Prev
Next