Page MenuHomePhabricator
Feed All Stories

Thu, Nov 20

Fabien accepted D18969: kernel: Add fatalError method to notifications.
Thu, Nov 20, 10:58
teamcity updated the summary of D18973: blockstorage: do not flush block to disk if it is already there.
Thu, Nov 20, 10:53
PiRK requested review of D18973: blockstorage: do not flush block to disk if it is already there.
Thu, Nov 20, 10:53
PiRK added a comment to D18972: Remove utxo db upgrade code.

Note that if this is merged it will replace D18970 and require a rebase the rest of that stack (some changes in D18966 are no longer relevant)

Thu, Nov 20, 10:35
PiRK requested review of D18969: kernel: Add fatalError method to notifications.
Thu, Nov 20, 10:31
teamcity updated the summary of D18972: Remove utxo db upgrade code.
Thu, Nov 20, 10:08
PiRK requested review of D18972: Remove utxo db upgrade code.
Thu, Nov 20, 10:08
Fabien accepted D18971: test: cover read-only blockstore.
Thu, Nov 20, 09:03
Fabien requested changes to D18969: kernel: Add fatalError method to notifications.
Thu, Nov 20, 08:58
Fabien accepted D18968: kernel: Add flushError method to notifications.
Thu, Nov 20, 08:49
Fabien accepted D18967: scripted-diff: Rename FatalError to FatalErrorf.
Thu, Nov 20, 08:47
Fabien accepted D18966: kernel: Pass interrupt reference to chainman.
Thu, Nov 20, 08:47
Fabien accepted D18970: txdb: remove dependency on ui_interface.
Thu, Nov 20, 08:42
Fabien accepted D18965: util: Add SignalInterrupt class and use in shutdown.cpp.
Thu, Nov 20, 08:40
Fabien accepted D18964: util: move threadinterrupt into util.
Thu, Nov 20, 08:37

Wed, Nov 19

Fabien added a comment to D18960: [Cashtab, chronik-client] Add and implement ws methods to support mobile app backgrounding.

We have a keepalive already, and websocket has pings which seems a better/cleaner option

Indeed. However, when an app is backgrounded, the websocket nevertheless disconnects, and it does not automatically reconnect when the app is unbackgrounded. This would be nice to handle in chronik-client but I'm not sure how to listen for this event in chronik-client, or if it's even practical to do so there, as the whole backgrounded event is a mobile app thing. I don't think we want capacitor as a dep in chronik-client.

Wed, Nov 19, 21:45
Fabien accepted D18955: [64-bit ints] 32-bit integers? I never knew you.
Wed, Nov 19, 21:36
bytesofman planned changes to D18960: [Cashtab, chronik-client] Add and implement ws methods to support mobile app backgrounding.

review for further simplifications

Wed, Nov 19, 20:41
bytesofman updated the diff for D18960: [Cashtab, chronik-client] Add and implement ws methods to support mobile app backgrounding.

reconnect instead of creating a new ws on backgrounding

Wed, Nov 19, 20:41
PiRK updated the diff for D18971: test: cover read-only blockstore.

shebang --, file permissions

Wed, Nov 19, 19:41
PiRK updated the summary of D18971: test: cover read-only blockstore.
Wed, Nov 19, 19:40
PiRK updated the summary of D18955: [64-bit ints] 32-bit integers? I never knew you.
Wed, Nov 19, 19:38
PiRK updated the summary of D18970: txdb: remove dependency on ui_interface.
Wed, Nov 19, 19:36
PiRK accepted D18955: [64-bit ints] 32-bit integers? I never knew you.
Wed, Nov 19, 19:35
tobias_ruck published D18955: [64-bit ints] 32-bit integers? I never knew you for review.
Wed, Nov 19, 17:48
bytesofman planned changes to D18960: [Cashtab, chronik-client] Add and implement ws methods to support mobile app backgrounding.

It uses low level ws state that should be handled by chronik-client, if anything made accessible

Wed, Nov 19, 17:18
PiRK updated the test plan for D18971: test: cover read-only blockstore.
Wed, Nov 19, 17:13
PiRK updated the diff for D18971: test: cover read-only blockstore.

don't log 3 warnings for a single message

Wed, Nov 19, 17:12
PiRK added inline comments to D18971: test: cover read-only blockstore.
Wed, Nov 19, 17:10
teamcity updated the summary of D18971: test: cover read-only blockstore.
Wed, Nov 19, 17:09
PiRK requested review of D18971: test: cover read-only blockstore.
Wed, Nov 19, 17:08
PiRK updated the diff for D18969: kernel: Add fatalError method to notifications.

rebase after removing the txdb -> ui_interface dependency (D18970) and document the remaining kernel -> ui_interface transitive dependencies

Wed, Nov 19, 17:04
PiRK updated the diff for D18966: kernel: Pass interrupt reference to chainman.

rebase on D18970

Wed, Nov 19, 17:03
PiRK requested review of D18970: txdb: remove dependency on ui_interface.
Wed, Nov 19, 16:53
PiRK planned changes to D18969: kernel: Add fatalError method to notifications.

figure out why we still need ui_interface in the kernel lib

Wed, Nov 19, 15:47
teamcity added a comment to D18969: kernel: Add fatalError method to notifications.
Wed, Nov 19, 15:12
teamcity updated the summary of D18969: kernel: Add fatalError method to notifications.
Wed, Nov 19, 14:49
PiRK requested review of D18969: kernel: Add fatalError method to notifications.
Wed, Nov 19, 14:49
teamcity updated the summary of D18968: kernel: Add flushError method to notifications.
Wed, Nov 19, 14:44
PiRK requested review of D18968: kernel: Add flushError method to notifications.
Wed, Nov 19, 14:44
teamcity updated the summary of D18967: scripted-diff: Rename FatalError to FatalErrorf.
Wed, Nov 19, 14:44
PiRK requested review of D18967: scripted-diff: Rename FatalError to FatalErrorf.
Wed, Nov 19, 14:43
teamcity updated the summary of D18966: kernel: Pass interrupt reference to chainman.
Wed, Nov 19, 14:42
PiRK requested review of D18966: kernel: Pass interrupt reference to chainman.
Wed, Nov 19, 14:42
teamcity updated the summary of D18965: util: Add SignalInterrupt class and use in shutdown.cpp.
Wed, Nov 19, 14:41
PiRK requested review of D18965: util: Add SignalInterrupt class and use in shutdown.cpp.
Wed, Nov 19, 14:41
teamcity added a comment to D18964: util: move threadinterrupt into util.
Wed, Nov 19, 11:31
PiRK updated the diff for D18964: util: move threadinterrupt into util.

rebase

Wed, Nov 19, 11:31
PiRK added a comment to D18964: util: move threadinterrupt into util.

the failures seem unrelated, rerunning

Wed, Nov 19, 11:01
teamcity added a comment to D18964: util: move threadinterrupt into util.
Wed, Nov 19, 11:00
teamcity added a comment to D18964: util: move threadinterrupt into util.
Wed, Nov 19, 10:36
teamcity added a comment to D18964: util: move threadinterrupt into util.
Wed, Nov 19, 10:36
teamcity updated the summary of D18964: util: move threadinterrupt into util.
Wed, Nov 19, 10:31
PiRK requested review of D18964: util: move threadinterrupt into util.
Wed, Nov 19, 10:31
Fabien closed D18963: [website] Build the man pages for iguana and the proof-manager-cli.
Wed, Nov 19, 10:17
Fabien committed rABCWEB337c6cb67c02: [website] Build the man pages for iguana and the proof-manager-cli (authored by Fabien).
[website] Build the man pages for iguana and the proof-manager-cli
Wed, Nov 19, 10:17
Fabien closed D18961: [cmake] Add man pages for the new executables.
Wed, Nov 19, 10:17
Fabien committed rABCb391ea877c5f: [cmake] Add man pages for the new executables (authored by Fabien).
[cmake] Add man pages for the new executables
Wed, Nov 19, 10:17
PiRK accepted D18963: [website] Build the man pages for iguana and the proof-manager-cli.
Wed, Nov 19, 10:16
Fabien closed D18962: Bump version to 0.32.4.
Wed, Nov 19, 10:16
Fabien committed rABC67398d127ca0: Bump version to 0.32.4 (authored by Fabien).
Bump version to 0.32.4
Wed, Nov 19, 10:16
Fabien added inline comments to D18961: [cmake] Add man pages for the new executables.
Wed, Nov 19, 10:15
PiRK accepted D18962: Bump version to 0.32.4.
Wed, Nov 19, 10:14
PiRK accepted D18961: [cmake] Add man pages for the new executables.
Wed, Nov 19, 10:14
Fabien requested review of D18963: [website] Build the man pages for iguana and the proof-manager-cli.
Wed, Nov 19, 10:04
Fabien requested review of D18962: Bump version to 0.32.4.
Wed, Nov 19, 09:47
Fabien updated the diff for D18961: [cmake] Add man pages for the new executables.

Rebase

Wed, Nov 19, 09:03
Fabien requested review of D18961: [cmake] Add man pages for the new executables.
Wed, Nov 19, 09:01
Fabien closed D18958: [cmake] Add a target for the proof-manager-cli tool.
Wed, Nov 19, 08:43
Fabien closed D18956: [proof-manager-cli] Rename the proof-manager executable to proof-manager-cli.
Wed, Nov 19, 08:43
Fabien closed D18959: [guix] Add the proof-manager-cli to the release.
Wed, Nov 19, 08:43
Fabien committed rABC7bc6ada8fa77: [proof-manager-cli] Rename the proof-manager executable to proof-manager-cli (authored by Fabien).
[proof-manager-cli] Rename the proof-manager executable to proof-manager-cli
Wed, Nov 19, 08:43
Fabien committed rABCa569b425ae1b: [cmake] Add a target for the proof-manager-cli tool (authored by Fabien).
[cmake] Add a target for the proof-manager-cli tool
Wed, Nov 19, 08:43
Fabien committed rABC0c4d7cd8ab6d: [guix] Add the proof-manager-cli to the release (authored by Fabien).
[guix] Add the proof-manager-cli to the release
Wed, Nov 19, 08:43
Fabien requested changes to D18960: [Cashtab, chronik-client] Add and implement ws methods to support mobile app backgrounding.

I understand the problem but I don't think this is a good approach for several reasons:

  • It uses low level ws state that should be handled by chronik-client, if anything made accessible
  • We have a keepalive already, and websocket has pings which seems a better/cleaner option
  • You have events when the app goes to/resumes from background. Why do you need to check the ws status at all ? Can't you just blindly resubscribe? Do you get twice the notifications if subscribed twice to the same things ?
Wed, Nov 19, 08:32
PiRK accepted D18958: [cmake] Add a target for the proof-manager-cli tool.
Wed, Nov 19, 08:06
PiRK closed D18957: bench: add readblock benchmark.
Wed, Nov 19, 08:01
PiRK closed D18952: net: Serve blocks directly from disk when possible.
Wed, Nov 19, 08:01
PiRK committed rABCa51b28b23a2d: net: Serve blocks directly from disk when possible (authored by PiRK).
net: Serve blocks directly from disk when possible
Wed, Nov 19, 08:01
PiRK committed rABC960a5e160248: bench: add readblock benchmark (authored by Andrew Toth <andrewstoth@gmail.com>).
bench: add readblock benchmark
Wed, Nov 19, 08:01

Tue, Nov 18

bytesofman published D18960: [Cashtab, chronik-client] Add and implement ws methods to support mobile app backgrounding for review.
Tue, Nov 18, 22:18
teamcity added a comment to D18952: net: Serve blocks directly from disk when possible.
Tue, Nov 18, 20:57
Fabien accepted D18952: net: Serve blocks directly from disk when possible.
Tue, Nov 18, 20:56
Fabien added inline comments to D18958: [cmake] Add a target for the proof-manager-cli tool.
Tue, Nov 18, 20:46
PiRK accepted D18959: [guix] Add the proof-manager-cli to the release.
Tue, Nov 18, 20:02
PiRK added inline comments to D18958: [cmake] Add a target for the proof-manager-cli tool.
Tue, Nov 18, 20:00
PiRK added inline comments to D18958: [cmake] Add a target for the proof-manager-cli tool.
Tue, Nov 18, 19:58
PiRK accepted D18956: [proof-manager-cli] Rename the proof-manager executable to proof-manager-cli.
Tue, Nov 18, 19:51
Fabien accepted D18957: bench: add readblock benchmark.
Tue, Nov 18, 16:25
teamcity awarded D18959: [guix] Add the proof-manager-cli to the release a Haypence token.
Tue, Nov 18, 16:24
Fabien added a comment to D18959: [guix] Add the proof-manager-cli to the release.

@bot guix-linux guix-osx guix-win

Tue, Nov 18, 16:24
Fabien requested review of D18959: [guix] Add the proof-manager-cli to the release.
Tue, Nov 18, 16:22
Fabien requested review of D18958: [cmake] Add a target for the proof-manager-cli tool.
Tue, Nov 18, 16:21
PiRK updated the diff for D18957: bench: add readblock benchmark.

also add missing includes from core#30716

Tue, Nov 18, 16:18
Fabien updated the diff for D18956: [proof-manager-cli] Rename the proof-manager executable to proof-manager-cli.

Rename in tests

Tue, Nov 18, 16:13
Fabien planned changes to D18956: [proof-manager-cli] Rename the proof-manager executable to proof-manager-cli.
Tue, Nov 18, 16:12
PiRK updated the diff for D18957: bench: add readblock benchmark.

fully apply https://github.com/bitcoin/bitcoin/pull/31490/commits/34f9a0157aad7c10ac364b7e4602c5f74c1f9e20

Tue, Nov 18, 16:09
teamcity updated the summary of D18957: bench: add readblock benchmark.
Tue, Nov 18, 15:51
PiRK requested review of D18957: bench: add readblock benchmark.
Tue, Nov 18, 15:51
teamcity added a comment to D18956: [proof-manager-cli] Rename the proof-manager executable to proof-manager-cli.
Tue, Nov 18, 15:29