Note that if this is merged it will replace D18970 and require a rebase the rest of that stack (some changes in D18966 are no longer relevant)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Thu, Nov 20
Wed, Nov 19
We have a keepalive already, and websocket has pings which seems a better/cleaner option
Indeed. However, when an app is backgrounded, the websocket nevertheless disconnects, and it does not automatically reconnect when the app is unbackgrounded. This would be nice to handle in chronik-client but I'm not sure how to listen for this event in chronik-client, or if it's even practical to do so there, as the whole backgrounded event is a mobile app thing. I don't think we want capacitor as a dep in chronik-client.
review for further simplifications
reconnect instead of creating a new ws on backgrounding
shebang --, file permissions
It uses low level ws state that should be handled by chronik-client, if anything made accessible
don't log 3 warnings for a single message
rebase after removing the txdb -> ui_interface dependency (D18970) and document the remaining kernel -> ui_interface transitive dependencies
rebase on D18970
figure out why we still need ui_interface in the kernel lib
the failures seem unrelated, rerunning
Rebase
I understand the problem but I don't think this is a good approach for several reasons:
- It uses low level ws state that should be handled by chronik-client, if anything made accessible
- We have a keepalive already, and websocket has pings which seems a better/cleaner option
- You have events when the app goes to/resumes from background. Why do you need to check the ws status at all ? Can't you just blindly resubscribe? Do you get twice the notifications if subscribed twice to the same things ?
Tue, Nov 18
@bot guix-linux guix-osx guix-win
also add missing includes from core#30716
Rename in tests