Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Feb 7 2019

jasonbcox updated the summary of D1894: Added RPCCommand base classes in preparation for RPC migration.
Feb 7 2019, 00:40

Feb 6 2019

Herald added a reviewer for D2507: Move call to SetRPCWarmupFinished() so that it applies to the entire test framework: Restricted Project.
Feb 6 2019, 22:13
jasonbcox committed rABC1f9c5f783e91: Fix undeterministic call to shouldPoll() in Avalanche tests (authored by jasonbcox).
Fix undeterministic call to shouldPoll() in Avalanche tests
Feb 6 2019, 18:57
jasonbcox closed D2504: Fix undeterministic call to shouldPoll() in Avalanche tests.
Feb 6 2019, 18:57
jasonbcox added inline comments to D2503: Merge #10712: Add change output if necessary to reduce excess fee.
Feb 6 2019, 18:56
jasonbcox updated the diff for D2503: Merge #10712: Add change output if necessary to reduce excess fee.

Rebase + fix comment linting

Feb 6 2019, 18:46
jasonbcox planned changes to D1894: Added RPCCommand base classes in preparation for RPC migration.
Feb 6 2019, 17:37
jasonbcox updated the summary of D2504: Fix undeterministic call to shouldPoll() in Avalanche tests.
Feb 6 2019, 17:21
jasonbcox updated the summary of D2504: Fix undeterministic call to shouldPoll() in Avalanche tests.
Feb 6 2019, 17:20
jasonbcox updated the summary of D2504: Fix undeterministic call to shouldPoll() in Avalanche tests.
Feb 6 2019, 17:17
Herald added a reviewer for D2504: Fix undeterministic call to shouldPoll() in Avalanche tests: Restricted Project.
Feb 6 2019, 00:00

Feb 5 2019

Herald added a reviewer for D2503: Merge #10712: Add change output if necessary to reduce excess fee: Restricted Project.
Feb 5 2019, 23:52
jasonbcox accepted D2464: Use c++14 generic std::rbegin() and std::rend() instead of class methods.
Feb 5 2019, 22:38
jasonbcox committed rABCcc37dd10864e: Move NULLPTR macro so that it can be used by all unit tests (authored by jasonbcox).
Move NULLPTR macro so that it can be used by all unit tests
Feb 5 2019, 22:32
jasonbcox closed D2500: Move NULLPTR macro so that it can be used by all unit tests.
Feb 5 2019, 22:31
jasonbcox closed T535: Backport Core PR10294 as Resolved.
Feb 5 2019, 22:30 · Backport
jasonbcox closed T535: Backport Core PR10294, a subtask of T534: Backport Core PR10712, as Resolved.
Feb 5 2019, 22:30 · Backport
jasonbcox committed rABCc25af1fd9c0e: Merge #10294: [Wallet] unset change position when there is no change (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10294: [Wallet] unset change position when there is no change
Feb 5 2019, 22:30
jasonbcox closed D2502: Merge #10294: [Wallet] unset change position when there is no change.
Feb 5 2019, 22:30
Herald added a reviewer for D2502: Merge #10294: [Wallet] unset change position when there is no change: Restricted Project.
Feb 5 2019, 21:40
jasonbcox triaged T535: Backport Core PR10294 as Normal priority.
Feb 5 2019, 21:39 · Backport
jasonbcox triaged T534: Backport Core PR10712 as Normal priority.
Feb 5 2019, 19:33 · Backport
jasonbcox accepted D2432: ArgsManager: keep command line and config file arguments separate.
Feb 5 2019, 04:12
jasonbcox added a comment to D2500: Move NULLPTR macro so that it can be used by all unit tests.

I wanted to use it here: https://reviews.bitcoinabc.org/D1894#inline-13587

Feb 5 2019, 01:21

Feb 4 2019

jasonbcox updated the diff for D1894: Added RPCCommand base classes in preparation for RPC migration.

Added a lock for registering commands in a thread-safe way

Feb 4 2019, 23:57
jasonbcox updated the summary of D1894: Added RPCCommand base classes in preparation for RPC migration.
Feb 4 2019, 23:32
jasonbcox planned changes to D1894: Added RPCCommand base classes in preparation for RPC migration.

Still need to design this system to be thread-safe rather than making assumptions about it's use based on current behavior.

Feb 4 2019, 23:30
jasonbcox updated the diff for D1894: Added RPCCommand base classes in preparation for RPC migration.

Fix test for old versions of boost

Feb 4 2019, 23:29
Herald added a reviewer for D2500: Move NULLPTR macro so that it can be used by all unit tests: Restricted Project.
Feb 4 2019, 23:02
jasonbcox requested review of D1894: Added RPCCommand base classes in preparation for RPC migration.
Feb 4 2019, 22:17
jasonbcox planned changes to D1894: Added RPCCommand base classes in preparation for RPC migration.
Feb 4 2019, 20:05
jasonbcox updated the diff for D1894: Added RPCCommand base classes in preparation for RPC migration.

Rebase + feedback

Feb 4 2019, 20:00
jasonbcox added inline comments to D1894: Added RPCCommand base classes in preparation for RPC migration.
Feb 4 2019, 19:59
jasonbcox accepted D2421: Add Fabien to the keys for gitian signing.

Seems the keyservers were down. They're working for me now and I was able to recv Fabien's key.

Feb 4 2019, 19:27
jasonbcox accepted D2489: fix dependency lcg.h in CMakeLists and Makefile.test.include.
Feb 4 2019, 02:13
jasonbcox updated the test plan for D2489: fix dependency lcg.h in CMakeLists and Makefile.test.include.
Feb 4 2019, 02:13

Feb 3 2019

jasonbcox requested changes to D2459: Add a cli option to the test framework to add an argument to all nodes.

There also appears to be a copy-paste error in the test plan.

Feb 3 2019, 21:19
jasonbcox accepted D2486: [avalanche] Limit the number of in flight request per item..

Some nits. All else LGTM.

Feb 3 2019, 20:05
jasonbcox accepted D2472: [avalanche] refactor getInvsForNextPoll to limit the scope of cs_main.
Feb 3 2019, 17:04
jasonbcox accepted D2470: [avalanche] Make sure we keep the read lock when reading from VoteRecord.
Feb 3 2019, 17:02
jasonbcox accepted D2473: [avalanche] Refactor the clearing of timed out requests in its own function.
Feb 3 2019, 17:00
jasonbcox accepted D2484: [avalanche] Refactor test..
Feb 3 2019, 16:59
jasonbcox accepted D2471: [avalanche] Group constants definition together.
Feb 3 2019, 16:56
jasonbcox accepted D2474: [avalanche] Use initializer for VoteRecord.
Feb 3 2019, 16:54
jasonbcox accepted D2485: [avalanche] Make constant constant.
Feb 3 2019, 16:51

Feb 2 2019

jasonbcox updated the diff for D2289: Ban nodes providing an invalid checksum in a message header.

Ban the node explicitly + fix a flakiness bug in the test

Feb 2 2019, 01:26

Feb 1 2019

jasonbcox closed T515: Backport Core PR 10449 as Wontfix.

RBF only

Feb 1 2019, 22:02 · Backport
jasonbcox closed T515: Backport Core PR 10449, a subtask of T417: Backport PR10244 from core, as Wontfix.
Feb 1 2019, 22:02 · Backport
jasonbcox added inline comments to D2289: Ban nodes providing an invalid checksum in a message header.
Feb 1 2019, 20:13
jasonbcox updated the diff for D2289: Ban nodes providing an invalid checksum in a message header.

Add test case for version message with invalid checksum (on connection to a peer)

Feb 1 2019, 20:11
jasonbcox planned changes to D2289: Ban nodes providing an invalid checksum in a message header.

Still a WIP for the test changes Amaury pointed out

Feb 1 2019, 18:49
jasonbcox updated the diff for D2289: Ban nodes providing an invalid checksum in a message header.

Rebasing due to lots of refactors to account for

Feb 1 2019, 18:48
jasonbcox added inline comments to D2457: [schnorr] Refactor the signature process in reusable component.
Feb 1 2019, 01:03
jasonbcox updated the summary of D2457: [schnorr] Refactor the signature process in reusable component.
Feb 1 2019, 00:44

Jan 31 2019

jasonbcox committed rABC743ef14afed9: Revert "[qa] cause test_framework to mine the initial chain *now*" (authored by jasonbcox).
Revert "[qa] cause test_framework to mine the initial chain *now*"
Jan 31 2019, 19:24
jasonbcox added a reverting change for rABCa95b44134c18: [qa] cause test_framework to mine the initial chain *now*: rABC743ef14afed9: Revert "[qa] cause test_framework to mine the initial chain *now*".
Jan 31 2019, 19:24
jasonbcox closed D2465: Revert "[qa] cause test_framework to mine the initial chain *now*".
Jan 31 2019, 19:24
jasonbcox accepted D2463: Migrate MakeUnique to c++14 std::make_unique.
Jan 31 2019, 19:07
jasonbcox accepted D2461: Drop support for OpenBSD.
Jan 31 2019, 19:06
jasonbcox updated the diff for D2465: Revert "[qa] cause test_framework to mine the initial chain *now*".

Rebase, just to be sure

Jan 31 2019, 19:03
jasonbcox updated the summary of D2465: Revert "[qa] cause test_framework to mine the initial chain *now*".
Jan 31 2019, 18:57
Herald added a reviewer for D2465: Revert "[qa] cause test_framework to mine the initial chain *now*": Restricted Project.
Jan 31 2019, 18:57
jasonbcox added inline comments to D2432: ArgsManager: keep command line and config file arguments separate.
Jan 31 2019, 18:15

Jan 30 2019

jasonbcox accepted D2454: Use compile-time constants instead of unnamed enumerations.
Jan 30 2019, 22:41
jasonbcox accepted D2445: Fix unused imports in contrib/ python scripts.
Jan 30 2019, 22:39
jasonbcox added inline comments to D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
Jan 30 2019, 22:38
jasonbcox accepted D2348: Add CKey::SignSchnorr and CPubKey::VerifySchnorr.
Jan 30 2019, 22:27
jasonbcox accepted D2169: [secp256k1] Implement Schnorr signatures.
Jan 30 2019, 22:06
jasonbcox requested changes to D2452: Make the number service of service flag bits to display a constant.
Jan 30 2019, 17:35
jasonbcox accepted D2451: Check for unused imports in *.py files.
Jan 30 2019, 16:54
jasonbcox accepted D2450: Fix unused imports in lint/ python scripts.
Jan 30 2019, 16:51
jasonbcox accepted D2449: Fix unused imports in test_framework python scripts.
Jan 30 2019, 16:51
jasonbcox accepted D2448: Fix unused imports in rpc_* functional tests.
Jan 30 2019, 16:50
jasonbcox accepted D2447: Fix unused imports in feature_*, mempool_* and p2p_* functional tests.
Jan 30 2019, 16:49
jasonbcox accepted D2446: Fix unused imports in abc-* functional tests.
Jan 30 2019, 16:47
jasonbcox accepted D2453: Fix braces in guiutil.cpp.
Jan 30 2019, 16:45
jasonbcox updated the task description for T524: Improve IBD script to support arbitrary params.
Jan 30 2019, 00:36 · Bootcamp, Restricted Project
jasonbcox closed T464: Build Bitcoin-ABC / Master / Nightly Builds / Nightly - OSX is broken. as Resolved.
Jan 30 2019, 00:27
jasonbcox closed T465: Build Bitcoin-ABC / Master / Nightly Builds / Nightly - Win is broken. as Resolved.
Jan 30 2019, 00:27
jasonbcox closed T474: Build Bitcoin-ABC / Master / Initial Block Download is broken. as Resolved.
Jan 30 2019, 00:27
jasonbcox closed T475: Build Bitcoin-ABC / Master / Initial Block Download is broken. as Resolved.
Jan 30 2019, 00:27
jasonbcox closed T481: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Resolved.
Jan 30 2019, 00:26
jasonbcox closed T485: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Resolved.
Jan 30 2019, 00:26
jasonbcox closed T486: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Resolved.
Jan 30 2019, 00:26
jasonbcox closed T488: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Resolved.
Jan 30 2019, 00:26
jasonbcox closed T489: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Resolved.
Jan 30 2019, 00:26
jasonbcox closed T490: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Resolved.
Jan 30 2019, 00:26
jasonbcox closed T491: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Resolved.
Jan 30 2019, 00:26
jasonbcox closed T492: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Resolved.
Jan 30 2019, 00:26
jasonbcox closed T493: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Resolved.
Jan 30 2019, 00:26
jasonbcox closed T435: Build Bitcoin-ABC / Master / Bitcoin-ABC Master is broken. as Resolved.
Jan 30 2019, 00:20
jasonbcox closed T450: Build Bitcoin-ABC / Master / Nightly Builds / Nightly - Linux is broken. as Resolved.
Jan 30 2019, 00:20

Jan 29 2019

jasonbcox closed T513: Backport Core PR 11365 as Resolved.
Jan 29 2019, 23:32 · Backport
jasonbcox committed rABC49d0b1ed151f: [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page (authored by Anditto Heristyo <anditto.heristyo@gmail.com>).
[Tests] Add Qt GUI tests to Overview and ReceiveCoin Page
Jan 29 2019, 23:32
jasonbcox closed T513: Backport Core PR 11365, a subtask of T417: Backport PR10244 from core, as Resolved.
Jan 29 2019, 23:32 · Backport
jasonbcox closed D2428: [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page.
Jan 29 2019, 23:32
jasonbcox committed rABC6373126c825e: Merge #10231: [Qt] Reduce a significant cs_main lock freeze (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10231: [Qt] Reduce a significant cs_main lock freeze
Jan 29 2019, 23:31
jasonbcox closed T510: Backport Core PR 10231 as Resolved.
Jan 29 2019, 23:31 · Backport
jasonbcox closed T510: Backport Core PR 10231, a subtask of T417: Backport PR10244 from core, as Resolved.
Jan 29 2019, 23:31 · Backport
jasonbcox closed D2429: Merge #10231: [Qt] Reduce a significant cs_main lock freeze.
Jan 29 2019, 23:31
First
Prev
Next