Page MenuHomePhabricator
Feed Advanced Search

Feb 12 2019

Herald added a reviewer for D2540: Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee: Restricted Project.
Feb 12 2019, 22:53
jasonbcox closed T512: Backport Core PR 10420 as Resolved.
Feb 12 2019, 22:44 · Backport
jasonbcox closed T512: Backport Core PR 10420, a subtask of T417: Backport PR10244 from core, as Resolved.
Feb 12 2019, 22:44 · Backport
jasonbcox committed rABCc3f35428fd2e: Add Qt tests for wallet spends (authored by Russell Yanofsky <russ@yanofsky.org>).
Add Qt tests for wallet spends
Feb 12 2019, 22:28
jasonbcox closed D2538: Add Qt tests for wallet spends.
Feb 12 2019, 22:28
jasonbcox closed T511: Backport Core PR 10770 as Resolved.
Feb 12 2019, 19:15 · Backport
jasonbcox closed T511: Backport Core PR 10770, a subtask of T417: Backport PR10244 from core, as Resolved.
Feb 12 2019, 19:15 · Backport
jasonbcox accepted D2518: Add an argument to the test framework to enable great wall activation.
Feb 12 2019, 19:15
jasonbcox added a comment to D2538: Add Qt tests for wallet spends.

I can see this is a dependency for T417 in the task list but fail to see how they are linked together; is there another intermediate backport that needs to build on top of this one ?

Feb 12 2019, 19:09
jasonbcox updated the diff for D2538: Add Qt tests for wallet spends.

Fixed according to feedback

Feb 12 2019, 19:07
jasonbcox added inline comments to D2538: Add Qt tests for wallet spends.
Feb 12 2019, 19:07
jasonbcox added inline comments to D2538: Add Qt tests for wallet spends.
Feb 12 2019, 01:21
Herald added a reviewer for D2538: Add Qt tests for wallet spends: Restricted Project.
Feb 12 2019, 01:19

Feb 11 2019

jasonbcox accepted D2479: Add activation code for SEGWIT_RECOVERY.
Feb 11 2019, 22:48
jasonbcox closed T381: Implement polymorphic RPC call registration as Resolved.
Feb 11 2019, 22:36 · Restricted Project
jasonbcox closed T381: Implement polymorphic RPC call registration, a subtask of T367: Create proof-of-concept for BlockTemplateManager, as Resolved.
Feb 11 2019, 22:36 · Restricted Project
jasonbcox closed T381: Implement polymorphic RPC call registration, a subtask of T368: Implement new getblocktemplate mode, as Resolved.
Feb 11 2019, 22:36 · Restricted Project
jasonbcox committed rABC97c2227fc9ba: Added RPCCommand base classes in preparation for RPC migration (authored by jasonbcox).
Added RPCCommand base classes in preparation for RPC migration
Feb 11 2019, 22:36
jasonbcox closed D1894: Added RPCCommand base classes in preparation for RPC migration.
Feb 11 2019, 22:35
jasonbcox added inline comments to D2483: Schnorr signature activation.
Feb 11 2019, 22:15
jasonbcox requested changes to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Feb 11 2019, 22:03
jasonbcox accepted D2535: Refactor TestNode arguments management.
Feb 11 2019, 18:48
jasonbcox added inline comments to D2535: Refactor TestNode arguments management.
Feb 11 2019, 18:48
jasonbcox added inline comments to D2535: Refactor TestNode arguments management.
Feb 11 2019, 18:34
jasonbcox committed rABC5f2ade873098: Remove BytesIO dependency from feature_dersig (authored by jasonbcox).
Remove BytesIO dependency from feature_dersig
Feb 11 2019, 18:04
jasonbcox closed D2529: Remove BytesIO dependency from feature_dersig.
Feb 11 2019, 18:04
jasonbcox accepted D2536: Use ToHex() in rpc_decodescript.py, remove dependency to mininode.
Feb 11 2019, 17:52
jasonbcox accepted D2537: Use ToHex() in feature_nulldummy.py.
Feb 11 2019, 17:51
jasonbcox committed rABC7777c68cf676: Remove dependency on BytesIO in feature_nulldummy.py (authored by jasonbcox).
Remove dependency on BytesIO in feature_nulldummy.py
Feb 11 2019, 01:52
jasonbcox closed D2528: Remove dependency on BytesIO in feature_nulldummy.py.
Feb 11 2019, 01:52
jasonbcox accepted D2525: Add importMempool.
Feb 11 2019, 00:07

Feb 10 2019

jasonbcox closed T534: Backport Core PR10712 as Resolved.
Feb 10 2019, 05:36 · Backport
jasonbcox closed T534: Backport Core PR10712, a subtask of T521: Backport Core PR 10706, as Resolved.
Feb 10 2019, 05:36 · Backport
jasonbcox committed rABC268be8dd95e0: Merge #10712: Add change output if necessary to reduce excess fee (authored by jasonbcox).
Merge #10712: Add change output if necessary to reduce excess fee
Feb 10 2019, 05:35
jasonbcox closed D2526: Merge #10712: Add change output if necessary to reduce excess fee.
Feb 10 2019, 05:35
jasonbcox updated the diff for D2529: Remove BytesIO dependency from feature_dersig.

Rebase + removed unnecessary intermediate variable

Feb 10 2019, 05:34
jasonbcox committed rABC634af4262efc: Remove unused function and dependencies from rpc_listtransactions (authored by jasonbcox).
Remove unused function and dependencies from rpc_listtransactions
Feb 10 2019, 05:32
jasonbcox closed D2530: Remove unused function and dependencies from rpc_listtransactions.
Feb 10 2019, 05:31
jasonbcox committed rABCbff2287cf61c: Removed BytesIO dependency from rpc_decodescript (authored by jasonbcox).
Removed BytesIO dependency from rpc_decodescript
Feb 10 2019, 05:31
jasonbcox closed D2531: Removed BytesIO dependency from rpc_decodescript.
Feb 10 2019, 05:31
jasonbcox requested changes to D2483: Schnorr signature activation.
Feb 10 2019, 05:29
jasonbcox added inline comments to D2483: Schnorr signature activation.
Feb 10 2019, 05:23
jasonbcox updated the diff for D2528: Remove dependency on BytesIO in feature_nulldummy.py.

Fix according to feedback

Feb 10 2019, 05:04

Feb 9 2019

Herald added a reviewer for D2531: Removed BytesIO dependency from rpc_decodescript: Restricted Project.
Feb 9 2019, 00:29
Herald added a reviewer for D2530: Remove unused function and dependencies from rpc_listtransactions: Restricted Project.
Feb 9 2019, 00:18
Herald added a reviewer for D2529: Remove BytesIO dependency from feature_dersig: Restricted Project.
Feb 9 2019, 00:07
jasonbcox added inline comments to D2508: [tests] nulldummy cleanup.
Feb 9 2019, 00:02
Herald added a reviewer for D2528: Remove dependency on BytesIO in feature_nulldummy.py: Restricted Project.
Feb 9 2019, 00:02

Feb 8 2019

Herald added a reviewer for D2526: Merge #10712: Add change output if necessary to reduce excess fee: Restricted Project.
Feb 8 2019, 23:47
jasonbcox accepted D2452: Make the number service of service flag bits to display a constant.
Feb 8 2019, 23:46
jasonbcox abandoned D2524: Revert "Revert "Merge #10712: Add change output if necessary to reduce excess fee"".
Feb 8 2019, 23:39
jasonbcox committed rABC622196dc3d13: [QA] Renaming rawtx into rawTx (authored by NicolasDorier <nicolas.dorier@gmail.com>).
[QA] Renaming rawtx into rawTx
Feb 8 2019, 23:36
jasonbcox closed D2523: [QA] Renaming rawtx into rawTx.
Feb 8 2019, 23:36
jasonbcox updated the diff for D1894: Added RPCCommand base classes in preparation for RPC migration.

Better tests and other feedback

Feb 8 2019, 23:34
jasonbcox added inline comments to D1894: Added RPCCommand base classes in preparation for RPC migration.
Feb 8 2019, 23:34
jasonbcox added inline comments to D2518: Add an argument to the test framework to enable great wall activation.
Feb 8 2019, 21:18
jasonbcox requested changes to D2518: Add an argument to the test framework to enable great wall activation.
Feb 8 2019, 21:13
jasonbcox requested changes to D2525: Add importMempool.
Feb 8 2019, 21:07
jasonbcox requested changes to D2452: Make the number service of service flag bits to display a constant.
Feb 8 2019, 20:13
jasonbcox updated the summary of D2523: [QA] Renaming rawtx into rawTx.
Feb 8 2019, 20:07
jasonbcox updated the diff for D2523: [QA] Renaming rawtx into rawTx.

Rebase + invert the change to be rawtx -> rawTx since this naming is more to style

Feb 8 2019, 20:06
Herald added a reviewer for D2524: Revert "Revert "Merge #10712: Add change output if necessary to reduce excess fee"": Restricted Project.
Feb 8 2019, 19:44
jasonbcox added a reverting change for rABCd22f9b079538: Revert "Merge #10712: Add change output if necessary to reduce excess fee": D2524: Revert "Revert "Merge #10712: Add change output if necessary to reduce excess fee"".
Feb 8 2019, 19:44
jasonbcox committed rABC4460385844a9: [QA] Fix typo in fundrawtransaction test (authored by jasonbcox).
[QA] Fix typo in fundrawtransaction test
Feb 8 2019, 19:27
jasonbcox closed D2522: [QA] Fix typo in fundrawtransaction test.
Feb 8 2019, 19:27
Herald added a reviewer for D2523: [QA] Renaming rawtx into rawTx: Restricted Project.
Feb 8 2019, 18:58
Herald added a reviewer for D2522: [QA] Fix typo in fundrawtransaction test: Restricted Project.
Feb 8 2019, 18:43
jasonbcox reopened T534: Backport Core PR10712, a subtask of T521: Backport Core PR 10706, as Open.
Feb 8 2019, 04:36 · Backport
jasonbcox reopened T534: Backport Core PR10712 as "Open".

Reverted because rpc_fundrawtransaction was failing. Will fix then re-diff.

Feb 8 2019, 04:36 · Backport
jasonbcox committed rABCd22f9b079538: Revert "Merge #10712: Add change output if necessary to reduce excess fee" (authored by jasonbcox).
Revert "Merge #10712: Add change output if necessary to reduce excess fee"
Feb 8 2019, 04:35
jasonbcox added a reverting change for rABC06c232f38061: Merge #10712: Add change output if necessary to reduce excess fee: rABCd22f9b079538: Revert "Merge #10712: Add change output if necessary to reduce excess fee".
Feb 8 2019, 04:35
jasonbcox closed D2517: Revert "Merge #10712: Add change output if necessary to reduce excess fee".
Feb 8 2019, 04:35
Herald added a reviewer for D2517: Revert "Merge #10712: Add change output if necessary to reduce excess fee": Restricted Project.
Feb 8 2019, 03:42
jasonbcox added a reverting change for rABC06c232f38061: Merge #10712: Add change output if necessary to reduce excess fee: D2517: Revert "Merge #10712: Add change output if necessary to reduce excess fee".
Feb 8 2019, 03:42
jasonbcox closed D2513: Added release note regarding hex field in tx JSON from getblock.
Feb 8 2019, 03:36
jasonbcox committed rABCbd0717a4e443: Update manpages for 0.18.8 (authored by jasonbcox).
Update manpages for 0.18.8
Feb 8 2019, 03:34
jasonbcox closed D2512: Update manpages for 0.18.8.
Feb 8 2019, 03:34
jasonbcox committed rABCe4604068ee4c: Added release note regarding hex field in tx JSON from getblock (authored by jasonbcox).
Added release note regarding hex field in tx JSON from getblock
Feb 8 2019, 03:31
jasonbcox committed rABC2939a67e6916: Ban nodes providing an invalid checksum in a message header (authored by jasonbcox).
Ban nodes providing an invalid checksum in a message header
Feb 8 2019, 03:28
jasonbcox closed D2289: Ban nodes providing an invalid checksum in a message header.
Feb 8 2019, 03:28
jasonbcox changed the visibility for D2289: Ban nodes providing an invalid checksum in a message header.
Feb 8 2019, 03:27

Feb 7 2019

Herald added a reviewer for D2513: Added release note regarding hex field in tx JSON from getblock: Restricted Project.
Feb 7 2019, 23:01
jasonbcox updated the test plan for D2512: Update manpages for 0.18.8.
Feb 7 2019, 22:44
jasonbcox updated the diff for D2512: Update manpages for 0.18.8.

Fixed upnp and dirty state (I built in the wrong tree, as I have multiple)

Feb 7 2019, 22:44
jasonbcox added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Feb 7 2019, 22:32
jasonbcox added inline comments to D2512: Update manpages for 0.18.8.
Feb 7 2019, 22:12
jasonbcox planned changes to D2512: Update manpages for 0.18.8.
Feb 7 2019, 22:10
Herald added a reviewer for D2512: Update manpages for 0.18.8: Restricted Project.
Feb 7 2019, 22:09
jasonbcox updated the diff for D1894: Added RPCCommand base classes in preparation for RPC migration.
  • Fixed r/w synchronization
  • Removed MatchCommand() since it made the implemenation of the above easier (and it was suggested earlier that it was questionable to have in the public API)
Feb 7 2019, 21:51
jasonbcox accepted D2510: Update chain parameters for 0.18.8.
Feb 7 2019, 18:36
jasonbcox accepted D2509: Fix formatting in release-process.md.
Feb 7 2019, 18:34
jasonbcox added inline comments to D1894: Added RPCCommand base classes in preparation for RPC migration.
Feb 7 2019, 01:04
jasonbcox updated the diff for D1894: Added RPCCommand base classes in preparation for RPC migration.

Rebase + use proper read-write locking

Feb 7 2019, 01:01
jasonbcox added inline comments to D1894: Added RPCCommand base classes in preparation for RPC migration.
Feb 7 2019, 01:00
jasonbcox closed T534: Backport Core PR10712 as Resolved.
Feb 7 2019, 00:45 · Backport
jasonbcox closed T534: Backport Core PR10712, a subtask of T521: Backport Core PR 10706, as Resolved.
Feb 7 2019, 00:45 · Backport
jasonbcox committed rABC06c232f38061: Merge #10712: Add change output if necessary to reduce excess fee (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10712: Add change output if necessary to reduce excess fee
Feb 7 2019, 00:44
jasonbcox closed D2503: Merge #10712: Add change output if necessary to reduce excess fee.
Feb 7 2019, 00:44
jasonbcox committed rABC982780fad709: Move call to SetRPCWarmupFinished() so that it applies to the entire test… (authored by jasonbcox).
Move call to SetRPCWarmupFinished() so that it applies to the entire test…
Feb 7 2019, 00:41
jasonbcox closed D2507: Move call to SetRPCWarmupFinished() so that it applies to the entire test framework.
Feb 7 2019, 00:41