developer notes are missing.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 15 2019
Jun 15 2019
D3310: Merge #14085: index: Fix for indexers skipping genesis block. is now accepted and ready to land.
D3334: [LINTER] Set the rules for the phpdoc comments is now accepted and ready to land.
D3341: Add benchmark for AES is now accepted and ready to land.
D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction` now requires changes to proceed.
D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC now requires changes to proceed.
deadalnix committed rABC33ff49689bcd: Make CMutableTransaction constructor explicit (authored by MarcoFalke <falke.marco@gmail.com>).
Make CMutableTransaction constructor explicit
deadalnix committed rABC06ac73365f35: bitcoin-tx: Remove unused for loop (authored by MarcoFalke <falke.marco@gmail.com>).
bitcoin-tx: Remove unused for loop
deadalnix committed rABCadaf42727dcf: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&)
Jun 14 2019
Jun 14 2019
deadalnix committed rABC0f49f7a5185d: Kill MAX_FREE_TRANSACTION_CREATE_SIZE (authored by deadalnix).
Kill MAX_FREE_TRANSACTION_CREATE_SIZE
D3333: Avoid including a C file in crypto/aes.cpp now requires changes to proceed.
You prevent any inlining here. This is why you get 5% perf regression. Don't do this.
deadalnix retitled D3342: Use mempool's descendent count in the wallet code from Use mempool's descendent count int he wallet code to Use mempool's descendent count in the wallet code.
Calculate descendant maximum thoroughly
deadalnix committed rABCdf7e2bdc4ea5: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp (authored by deadalnix).
Directly use CMutableTransaction more often in txvaidationcache_tests.cpp
deadalnix committed rABCaf600301e61b: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool… (authored by practicalswift <practicalswift@users.noreply.github.com>).
mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool…
deadalnix added a comment to D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).
rebase
deadalnix added a comment to D3330: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp.
Rebase
deadalnix committed rABCbd6817fcbf75: Take a CTransaction as argument for ValidateCheckInputsForAllFlags (authored by deadalnix).
Take a CTransaction as argument for ValidateCheckInputsForAllFlags
deadalnix committed rABC8ccdaf871c43: Avoid creating transaction copies in script_tests.cpp and multisig_tests.cpp (authored by deadalnix).
Avoid creating transaction copies in script_tests.cpp and multisig_tests.cpp
deadalnix committed rABC137afdf1c0f2: Use MakeTransactionRef in serialize_tests.cpp (authored by deadalnix).
Use MakeTransactionRef in serialize_tests.cpp
Update mempool eviction benchmark
D3292: Explicitly call out updating makeseeds.py after major releases is now accepted and ready to land.
D3333: Avoid including a C file in crypto/aes.cpp now requires changes to proceed.
I suspect this might be pretty bad for performance. I also suspect you don't intend to become maintainer of ctaes.
deadalnix committed rABC175362193461: Make m_coinbase_txns a vector of CTransactionRef (authored by deadalnix).
Make m_coinbase_txns a vector of CTransactionRef
coinbaseTxns => m_coinbase_txns
deadalnix committed rABC861e1e268cd6: Relayout comments in validation.cpp (authored by Andrew Chow <achow101-github@achow101.com>).
Relayout comments in validation.cpp
Jun 13 2019
Jun 13 2019
deadalnix added a comment to D3328: Take a CTransaction as argument for ValidateCheckInputsForAllFlags.
Remove unecessary copy
Has this error actually happened in the wild ? Also, do we need a new linter for each thing that can go wrong with includes ? It seems like one should be enough.
D3318: [LINTER] Prevent including a source file now requires changes to proceed.
This should also detect the inclusion of a .c .
D3310: Merge #14085: index: Fix for indexers skipping genesis block. now requires changes to proceed.
D3319: [LINTER] Enforce using angle brackets in #include directives is now accepted and ready to land.
deadalnix added a comment to D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).
rebase
deadalnix added a comment to D3304: Add a test to make sure that negative effective values are filtered.
rebase
deadalnix added a comment to D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.
rebase
deadalnix committed rABC6104bd0dcb40: Move original knapsack solver tests to coinselector_tests.cpp (authored by Andrew Chow <achow101-github@achow101.com>).
Move original knapsack solver tests to coinselector_tests.cpp
Rebase
deadalnix committed rABC1277558575c8: Move current coin selection algorithm to coinselection.{cpp,h} (authored by Andrew Chow <achow101-github@achow101.com>).
Move current coin selection algorithm to coinselection.{cpp,h}
deadalnix committed rABC1716c33e056b: Benchmark BnB in the worst case where it exhausts (authored by Andrew Chow <achow101-github@achow101.com>).
Benchmark BnB in the worst case where it exhausts
deadalnix committed rABC5cc81b09640d: Add tests for the Branch and Bound algorithm (authored by Andrew Chow <achow101-github@achow101.com>).
Add tests for the Branch and Bound algorithm
deadalnix committed rABCc9cc9f22f14d: Calculate and store the number of bytes required to spend an input (authored by Andrew Chow <achow101-github@achow101.com>).
Calculate and store the number of bytes required to spend an input
deadalnix committed rABCf24b2f5577cf: Remove coinselection.h -> wallet.h circular dependency (authored by Andrew Chow <achow101-github@achow101.com>).
Remove coinselection.h -> wallet.h circular dependency
deadalnix committed rABC88daa3d6c4af: Implement Branch and Bound coin selection in a new file (authored by Andrew Chow <achow101-github@achow101.com>).
Implement Branch and Bound coin selection in a new file
deadalnix committed rABC558e26523d13: Fix eligibilty_filter => eligibility_filter (authored by deadalnix).
Fix eligibilty_filter => eligibility_filter
deadalnix committed rABC91d67343d27e: Build wallet dependent benchmark using cmake (authored by deadalnix).
Build wallet dependent benchmark using cmake
Fix braces in multisig_test
Fix comments in miner.h
D3308: Merge #9894: remove 'label' filter for rpc command help is now accepted and ready to land.
D3283: Merge #10408, #13291, and partial #13163 now requires changes to proceed.
Jun 12 2019
Jun 12 2019
D3181: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning is now accepted and ready to land.
Why are all of these together ?
D3253: Remove Schnorr activation now requires changes to proceed.
It is very hard to ensure this is correct.
D3254: Revert "add flags to VerifySignature and sigcache" is now accepted and ready to land.
This is correct as long as we "pretend" schnorr always was activated.
D3267: check negative CScriptNum.getint() and introduce new error code now requires changes to proceed.
Please don't add more assumptions into the code. Also please explain why this is needed for schnorr multisig.