Page MenuHomePhabricator
Feed All Stories

Jan 19 2021

teamcity updated the summary of D8959: tests: Add fuzzing harness for CScript and CScriptNum operations.
Jan 19 2021, 13:54
Fabien requested review of D8959: tests: Add fuzzing harness for CScript and CScriptNum operations.
Jan 19 2021, 13:54
teamcity updated the summary of D8958: tests: Add amount compression/decompression fuzzing to existing fuzzing harness.
Jan 19 2021, 13:22
Fabien requested review of D8958: tests: Add amount compression/decompression fuzzing to existing fuzzing harness.
Jan 19 2021, 13:22
teamcity updated the summary of D8957: tests: Avoid hitting some known minor tinyformat issues when fuzzing strprintf(...).
Jan 19 2021, 12:50
Fabien requested review of D8957: tests: Avoid hitting some known minor tinyformat issues when fuzzing strprintf(...).
Jan 19 2021, 12:50
Fabien accepted D8955: [docs] use consistent naming for possible_overwrite.
Jan 19 2021, 12:30
Fabien accepted D8954: scripted-diff: Rename PRUNED to SPENT in coins tests.
Jan 19 2021, 12:28
Fabien accepted D8953: [docs] Improve commenting in coins.cpp|h.
Jan 19 2021, 12:27
teamcity updated the summary of D8956: Make libfuzzer to work on macOS.
Jan 19 2021, 12:14
Fabien requested review of D8956: Make libfuzzer to work on macOS.
Jan 19 2021, 12:13
jasonclark edited a custom field on jasonclark.
Jan 19 2021, 11:13
Fabien accepted D8952: rpc: doc: Fix and extend getblockstats examples.
Jan 19 2021, 11:12
teamcity updated the summary of D8955: [docs] use consistent naming for possible_overwrite.
Jan 19 2021, 10:30
PiRK requested review of D8955: [docs] use consistent naming for possible_overwrite.
Jan 19 2021, 10:30
PiRK updated the summary of D8954: scripted-diff: Rename PRUNED to SPENT in coins tests.
Jan 19 2021, 10:28
teamcity updated the summary of D8954: scripted-diff: Rename PRUNED to SPENT in coins tests.
Jan 19 2021, 10:28
PiRK requested review of D8954: scripted-diff: Rename PRUNED to SPENT in coins tests.
Jan 19 2021, 10:27
teamcity updated the summary of D8953: [docs] Improve commenting in coins.cpp|h.
Jan 19 2021, 10:25
PiRK requested review of D8953: [docs] Improve commenting in coins.cpp|h.
Jan 19 2021, 10:25
teamcity updated the summary of D8952: rpc: doc: Fix and extend getblockstats examples.
Jan 19 2021, 09:22
PiRK requested review of D8952: rpc: doc: Fix and extend getblockstats examples.
Jan 19 2021, 09:22
PiRK closed D8950: test: add further BIP37 size limit checks to p2p_filter.py.
Jan 19 2021, 09:06
PiRK committed rABC197d07192c8d: test: add further BIP37 size limit checks to p2p_filter.py (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: add further BIP37 size limit checks to p2p_filter.py
Jan 19 2021, 09:05
teamcity added a comment to D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.
Jan 19 2021, 09:04
teamcity triaged T1454: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Unbreak Now! priority.
Jan 19 2021, 09:02
PiRK closed D8949: net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear').
Jan 19 2021, 08:58
PiRK committed rABC2e6177c0ef87: net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear') (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear')
Jan 19 2021, 08:58
Fabien updated the diff for D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

Stick with original PR content.
API optimization can still happen later if needed.

Jan 19 2021, 08:55
Fabien updated the summary of D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.
Jan 19 2021, 08:54
Fabien accepted D8951: Fix typo in Sighash tests.
Jan 19 2021, 08:27
Fabien accepted D8950: test: add further BIP37 size limit checks to p2p_filter.py.
Jan 19 2021, 08:26
Fabien accepted D8949: net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear').
Jan 19 2021, 08:24

Jan 18 2021

Joey King <joseph.roy.king@gmail.com> closed D8948: [Cashtab] More clarity and tests for address parsing.
Jan 18 2021, 23:18
Joey King <joseph.roy.king@gmail.com> committed rABC616dff33486e: [Cashtab] More clarity and tests for address parsing (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] More clarity and tests for address parsing
Jan 18 2021, 23:18
PiRK accepted D8948: [Cashtab] More clarity and tests for address parsing.
Jan 18 2021, 23:00
Mengerian updated the diff for D8951: Fix typo in Sighash tests.

Fix typo in Diff description

Jan 18 2021, 22:53
Mengerian requested review of D8951: Fix typo in Sighash tests.
Jan 18 2021, 22:50
teamcity updated the summary of D8950: test: add further BIP37 size limit checks to p2p_filter.py.
Jan 18 2021, 22:46
PiRK requested review of D8950: test: add further BIP37 size limit checks to p2p_filter.py.
Jan 18 2021, 22:46
teamcity updated the summary of D8949: net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear').
Jan 18 2021, 22:28
PiRK requested review of D8949: net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear').
Jan 18 2021, 22:28
deadalnix requested changes to D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

The config is needed down the road is just saying nothing at all.

Jan 18 2021, 21:58
PiRK closed D8939: rpc: Add doc for deactivating settxfee and respect -maxtxfee wallet setting.
Jan 18 2021, 21:51
PiRK committed rABC634c08afae92: rpc: Add doc for deactivating settxfee and respect -maxtxfee wallet setting (authored by Fabian Jahr <fjahr@protonmail.com>).
rpc: Add doc for deactivating settxfee and respect -maxtxfee wallet setting
Jan 18 2021, 21:51
PiRK updated the diff for D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.

relayout comments

Jan 18 2021, 17:41
bytesofman requested review of D8948: [Cashtab] More clarity and tests for address parsing.
Jan 18 2021, 17:36
Fabien accepted D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 18 2021, 17:07
deadalnix requested changes to D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 18 2021, 17:03
Fabien accepted D8939: rpc: Add doc for deactivating settxfee and respect -maxtxfee wallet setting.
Jan 18 2021, 16:49
teamcity updated the summary of D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 18 2021, 16:39
PiRK requested review of D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 18 2021, 16:39
Fabien closed D8946: fuzz: Extend script fuzz test.
Jan 18 2021, 16:33
Fabien committed rABC4cc1ccf8c7ef: fuzz: Extend script fuzz test (authored by MarcoFalke <falke.marco@gmail.com>).
fuzz: Extend script fuzz test
Jan 18 2021, 16:32
Joey King <joseph.roy.king@gmail.com> closed D8944: [Cashtab] support valid addresses if no prefix included.
Jan 18 2021, 16:28
Joey King <joseph.roy.king@gmail.com> committed rABCb17877968ed6: [Cashtab] support valid addresses if no prefix included (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] support valid addresses if no prefix included
Jan 18 2021, 16:28
Fabien accepted D8944: [Cashtab] support valid addresses if no prefix included.
Jan 18 2021, 16:27
Fabien closed D8945: fuzz: Add assert(script == decompressed_script).
Jan 18 2021, 16:25
Fabien committed rABCaa9af3734dbc: fuzz: Add assert(script == decompressed_script) (authored by MarcoFalke <falke.marco@gmail.com>).
fuzz: Add assert(script == decompressed_script)
Jan 18 2021, 16:25
Fabien closed D8943: [CI] Build the fuzzer on diffs that touch the fuzzer files.
Jan 18 2021, 16:19
Fabien committed rABCad3cd8dbb88e: [CI] Build the fuzzer on diffs that touch the fuzzer files (authored by Fabien).
[CI] Build the fuzzer on diffs that touch the fuzzer files
Jan 18 2021, 16:19
PiRK closed D8941: test: Replace boost::mutex with std::mutex.
Jan 18 2021, 16:06
PiRK committed rABC5d76027dc469: test: Replace boost::mutex with std::mutex (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
test: Replace boost::mutex with std::mutex
Jan 18 2021, 16:06
PiRK closed D8936: tests: have coins simulation test also use CCoinsViewDB.
Jan 18 2021, 16:01
PiRK committed rABC2db657ee05bb: tests: have coins simulation test also use CCoinsViewDB (authored by James O'Beirne <james.obeirne@gmail.com>).
tests: have coins simulation test also use CCoinsViewDB
Jan 18 2021, 16:01
PiRK closed D8934: tests: don't repeat scriptPubKey value.
Jan 18 2021, 15:53
PiRK committed rABC82d1d9deaf18: tests: don't repeat scriptPubKey value (authored by PiRK).
tests: don't repeat scriptPubKey value
Jan 18 2021, 15:53
PiRK accepted D8946: fuzz: Extend script fuzz test.
Jan 18 2021, 15:45
PiRK accepted D8945: fuzz: Add assert(script == decompressed_script).
Jan 18 2021, 15:43
PiRK accepted D8943: [CI] Build the fuzzer on diffs that touch the fuzzer files.
Jan 18 2021, 15:42
bytesofman updated the diff for D8944: [Cashtab] support valid addresses if no prefix included.

Fix tests, better variable names

Jan 18 2021, 14:56
Fabien requested changes to D8944: [Cashtab] support valid addresses if no prefix included.
Jan 18 2021, 14:45
teamcity added a comment to D8944: [Cashtab] support valid addresses if no prefix included.
Jan 18 2021, 14:30
teamcity updated the summary of D8946: fuzz: Extend script fuzz test.
Jan 18 2021, 14:29
Fabien requested review of D8946: fuzz: Extend script fuzz test.
Jan 18 2021, 14:29
teamcity updated the summary of D8945: fuzz: Add assert(script == decompressed_script).
Jan 18 2021, 14:27
Fabien requested review of D8945: fuzz: Add assert(script == decompressed_script).
Jan 18 2021, 14:27
bytesofman requested review of D8944: [Cashtab] support valid addresses if no prefix included.
Jan 18 2021, 14:27
Fabien requested review of D8943: [CI] Build the fuzzer on diffs that touch the fuzzer files.
Jan 18 2021, 14:26
Fabien requested review of D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

@deadalnix I added a line with the rationale in the summary:
The config is needed down the road, and provides a facility to retrieve the chainparams, so storing it makes it possible to have a simpler API..
Let me know if you think it's not worth it.

Jan 18 2021, 13:53
Fabien updated the summary of D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.
Jan 18 2021, 13:51
deadalnix requested changes to D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

You say that it differs from the original by passing a config, but provide no reason as to why. It doesn't looks like to me that this difference is justified.

Jan 18 2021, 13:27
teamcity updated the summary of D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.
Jan 18 2021, 13:26
deadalnix accepted D8941: test: Replace boost::mutex with std::mutex.
Jan 18 2021, 13:26
Fabien requested review of D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.
Jan 18 2021, 13:26
Fabien closed D8940: [move only] Collect all private members of PeerLogicValidation together.
Jan 18 2021, 13:22
Fabien committed rABCe490dccb870f: [move only] Collect all private members of PeerLogicValidation together (authored by John Newbery <john@johnnewbery.com>).
[move only] Collect all private members of PeerLogicValidation together
Jan 18 2021, 13:22
teamcity updated the summary of D8941: test: Replace boost::mutex with std::mutex.
Jan 18 2021, 13:14
PiRK requested review of D8941: test: Replace boost::mutex with std::mutex.
Jan 18 2021, 13:14
majcosta closed D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].
Jan 18 2021, 13:06
majcosta committed rABC7680ec0096b1: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState… (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState…
Jan 18 2021, 13:05
PiRK accepted D8940: [move only] Collect all private members of PeerLogicValidation together.
Jan 18 2021, 13:00
Fabien updated the summary of D8940: [move only] Collect all private members of PeerLogicValidation together.
Jan 18 2021, 12:50
teamcity updated the summary of D8940: [move only] Collect all private members of PeerLogicValidation together.
Jan 18 2021, 12:43
Fabien requested review of D8940: [move only] Collect all private members of PeerLogicValidation together.
Jan 18 2021, 12:43
Fabien accepted D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].
Jan 18 2021, 12:30
Fabien accepted D8934: tests: don't repeat scriptPubKey value.
Jan 18 2021, 11:41
teamcity awarded D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix] a Doubloon token.
Jan 18 2021, 11:32
Fabien added a comment to D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].

@bot build-linux32 build-linux-arm build-linux-aarch64

Jan 18 2021, 11:31
majcosta updated the diff for D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].

removed commented leftover debugging line and adapted the test for Coin::DynamicMemoryUsage() on 32-bit

Jan 18 2021, 11:12