remove redundant comment and undo unrelated change in test (I intended to reuse the first change address, but ended up using the first receiving address for this test)

This diff incidentally makes get_sorted_pubkeys return lists intead of tuples, which makes my life easier when when checking the sorting (sorted(...) returns a list). I think this is an improvement, but I can revert and adapt the new test if reviewers don't agree or want it to be in its own diff.

don't order pubkeys in place, don't update pubkeys when it is not needed or not safe to do so.

sorting _pubkeys and _x_pubkeys in place in TxInput

Added two standard one to one send XEC tests, one with change and one without.

Superseded by D14607

still needs completeness and sanity check self-review

squash

still need to review for completeness, approach. Uses this as a work in progress in some local testing and not really sure what's even here until I review it.

.... i dunno why this is the example tx (a self-send tx with no change output that some crazy how ends up with a fee well below 1 sat per byte) but

Rebase, remove FIXME

In D14603#327982, @Fabien wrote:

I'm glad you tested the case of someone generating > 2 billion proofs/delegations :)

I'm glad you tested the case of someone generating > 2 billion proofs/delegations :)

remove unused method

prevent overflows

clarify ++

make the tooltip more clear and unconditional

This diff has gone through 5 rounds of review and the general design is still trivially flawed. This is NOT OK.
It is incredible that none of you is realizing that using a delay to deal with network propagation time is a genuine bad idea.

Responding to feedback

Responding to feedback

the use of aliasServerError context var which sets isValidAliasInput flag isn't quite a reundant daisy chain because there are other instances that would turn isValidAliasInput into false, such as the user inputting non-alphanumeric alias for registration which is unrelated to server error

You should really fix the snapshots. It's a shame you have to do twice the update just because you forgot to update, it should be automatic

update snapshots

Update error msg