rebase after npm ci
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Feb 25 2024
version bump
Feb 24 2024
Combined similar .toHaveTextContent() tests
why does no price trigger aliasValidationError?
Feb 23 2024
Added integration tests that validates behavior between aliasValidationError and aliasServerError states.
Feb 22 2024
Feb 20 2024
Rebase, version bump and commenting updates
Feb 19 2024
Great approach, doesn't even need migration logic since it's updating the same key in localforage. I did a manual test and the existing wallet did not lose existing contacts either.
Accepted with minor nit for consistency
Replaced setAliasServerError() calls which was the trigger to not render registered and pending alias lists in dropdowns. Now using setAliasValidationError() to hold the error displayed below the input field.
Feb 18 2024
FYI - using arc diff --nolint for now until I can resolve the arc lint exceptions. My python was already v3.12 and it didn't seem to fix it. Have also tested with versions < 3.12.
Removed setIsValidAliasInput(false) on price error
nvm, started observing the timeouts with other diffs so not for resolution here. Just needs a separate timeout bump diff.
I ran npm test 5 times on this diff and 5 times on master. This diff was getting consistent jest timeouts over Configure.js whilst master was all ok.
Normally I'd chalk timeouts to local factors but this seems rather specific to this dirty param you're removing.
Is this the case for you?
Feb 17 2024
Feb 16 2024
Rebase and version bump
Feb 14 2024
Feb 13 2024
Updated to use queryByText for elements which are not expected to be rendered and getByText for when it is expected.
Feb 12 2024
Removed single reference var and comment
Updated comments
Updated var usage
Feb 11 2024
Minor commenting nit but otherwise tested all ok across small-windowed web, extension and mobile.
Feb 7 2024
- Updated onMax() to return the value upon completion, which is then passed as a param to isValidMultiSendUserInput from SendXec.js
- Removed redundant vector and related unit test on a single amount being greater than wallet balance
Feb 6 2024
Two areas that need to either be automated or manually tested:
- Refactored isValidMultiSendUserInput unit tests to use the vectors approach
- Updated comments
- Replaced BN usage with Number and converting balances.totalBalance in SendXec.js to number when passing in to this function
Feb 3 2024
Added check for aggregate send value exceeding wallet balance and corresponding unit tests
version bump and test plan updated
Feb 2 2024
version bump
Feb 1 2024
Updated var assignments
version bump
When testing on mobile, both iOS and android devices are showing the create token button stretching off to the right of the screen. It's not the case with master.
Jan 31 2024
reminder to npm i prior to rebase/land to sync up package-lock.json versioning
also update test plan to validate QR code being rendered and scanned successfully (tested all ok from my side)
Wallets with aliases in contact list currently throw the list out and do not set to context.
Rebase and version bump
version bump
version bump
Refreshed package-lock.json to sync version bump
rebase and version bump
Jan 30 2024
Jan 29 2024
Yup, it was indeed related to the logo, scans all ok now.
Added an additional test showing notification is NOT rendered before signing/verification
