Page MenuHomePhabricator
Feed All Stories

Jan 24 2025

hazzarust updated the diff for D17565: [Chronik] Add unix socket listener to test_runner.rs.

Removed timeout

Jan 24 2025, 12:42
hazzarust updated the diff for D17564: [chronik] Add test runner to bitcoinsuite-chronik-client.

Added error handling

Jan 24 2025, 12:39
Fabien requested changes to D17582: [avalanche] Add an invalidation latch to contender cache.

Invalidated invs are removed from the polling list anyway so I'm not sure what the use case is for this. Clearing my queue for now.

Jan 24 2025, 08:37
Fabien closed D17583: [e.cash] Add a link to the chronik documentation.
Jan 24 2025, 08:32
Fabien committed rABC55ae02dedb89: [e.cash] Add a link to the chronik documentation (authored by Fabien).
[e.cash] Add a link to the chronik documentation
Jan 24 2025, 08:32
Fabien requested review of D17586: Bump the timeout in p2p_ibd_stalling.
Jan 24 2025, 08:30
Fabien requested review of D17585: Bump the timeout for the feature_cltv test.
Jan 24 2025, 08:24
johnkuney planned changes to D17584: [cashtab] Token view UI updates.
Jan 24 2025, 00:40

Jan 23 2025

teamcity added a comment to D17584: [cashtab] Token view UI updates.
Jan 23 2025, 22:27
johnkuney updated the diff for D17584: [cashtab] Token view UI updates.

fix errors

Jan 23 2025, 22:21
johnkuney planned changes to D17584: [cashtab] Token view UI updates.
Jan 23 2025, 22:16
johnkuney accepted D17583: [e.cash] Add a link to the chronik documentation.
Jan 23 2025, 22:15
teamcity added a comment to D17584: [cashtab] Token view UI updates.
Jan 23 2025, 22:12
johnkuney requested review of D17584: [cashtab] Token view UI updates.
Jan 23 2025, 22:07
PiRK closed D17581: [electrum] bump version to 5.4.0 and add release notes.
Jan 23 2025, 21:14
PiRK committed rABC25bf4ca369b9: [electrum] bump version to 5.4.0 and add release notes (authored by PiRK).
[electrum] bump version to 5.4.0 and add release notes
Jan 23 2025, 21:14
PiRK committed rABC491b7cda88c1: [electrum] fix lib versions for windows release scripts (authored by PiRK).
[electrum] fix lib versions for windows release scripts
Jan 23 2025, 21:06
PiRK closed D17580: [electrum] fix lib versions for windows release scripts.
Jan 23 2025, 21:06
PiRK updated the diff for D17581: [electrum] bump version to 5.4.0 and add release notes.

use 5.4.0 because of the new features

Jan 23 2025, 20:21
teamcity added a comment to D17583: [e.cash] Add a link to the chronik documentation.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41191 for the next 60 minutes.

Jan 23 2025, 19:25
teamcity awarded D17583: [e.cash] Add a link to the chronik documentation a Haypence token.
Jan 23 2025, 19:24
Fabien added a comment to D17583: [e.cash] Add a link to the chronik documentation.

@bot preview-e.cash

Jan 23 2025, 19:24
Fabien requested review of D17583: [e.cash] Add a link to the chronik documentation.
Jan 23 2025, 19:24
Fabien accepted D17580: [electrum] fix lib versions for windows release scripts.
Jan 23 2025, 18:58
roqqit accepted D17581: [electrum] bump version to 5.4.0 and add release notes.
Jan 23 2025, 17:54
roqqit requested review of D17582: [avalanche] Add an invalidation latch to contender cache.
Jan 23 2025, 17:51
roqqit closed D17574: [avalanche] Fixup incorrect comment about contender cache vote status.
Jan 23 2025, 17:46
roqqit committed rABC8a22e311702c: [avalanche] Fixup incorrect comment about contender cache vote status (authored by roqqit).
[avalanche] Fixup incorrect comment about contender cache vote status
Jan 23 2025, 17:46
PiRK requested review of D17581: [electrum] bump version to 5.4.0 and add release notes.
Jan 23 2025, 16:36
PiRK updated the test plan for D17580: [electrum] fix lib versions for windows release scripts.
Jan 23 2025, 15:51
PiRK committed rABCfb94895b4483: [electrum] Implement SLIP-0039 wallet recovery. (authored by Andrew Kozlik <andrew.kozlik@gmail.com>).
[electrum] Implement SLIP-0039 wallet recovery.
Jan 23 2025, 15:51
PiRK closed D17577: [electrum] Implement SLIP-0039 wallet recovery..
Jan 23 2025, 15:51
PiRK updated the summary of D17577: [electrum] Implement SLIP-0039 wallet recovery..
Jan 23 2025, 15:50
PiRK requested review of D17580: [electrum] fix lib versions for windows release scripts.
Jan 23 2025, 15:48
Fabien closed D17579: [electrum][trezor] 1-click install of the eCash logo as a homescreen.
Jan 23 2025, 15:45
Fabien committed rABC9fe5282e5388: [electrum][trezor] 1-click install of the eCash logo as a homescreen (authored by Fabien).
[electrum][trezor] 1-click install of the eCash logo as a homescreen
Jan 23 2025, 15:45
Mengerian added a comment to D17579: [electrum][trezor] 1-click install of the eCash logo as a homescreen.

Macro likestamp:

Jan 23 2025, 15:45
PiRK accepted D17579: [electrum][trezor] 1-click install of the eCash logo as a homescreen.
Jan 23 2025, 15:43
Fabien closed D17578: [electrum][trezor] Fix homescreen reset.
Jan 23 2025, 14:08
Fabien committed rABCbca06065030d: [electrum][trezor] Fix homescreen reset (authored by Fabien).
[electrum][trezor] Fix homescreen reset
Jan 23 2025, 14:08
Fabien accepted D17577: [electrum] Implement SLIP-0039 wallet recovery..
Jan 23 2025, 14:04
PiRK retitled D17577: [electrum] Implement SLIP-0039 wallet recovery. from Implement SLIP-0039 wallet recovery. to [electrum] Implement SLIP-0039 wallet recovery..
Jan 23 2025, 14:01
PiRK closed D17576: [electrum] pass the bip32 rootseed to the derivation path scanner.
Jan 23 2025, 14:00
PiRK committed rABC92e7592a5448: [electrum] pass the bip32 rootseed to the derivation path scanner (authored by PiRK).
[electrum] pass the bip32 rootseed to the derivation path scanner
Jan 23 2025, 14:00
PiRK added a comment to D17579: [electrum][trezor] 1-click install of the eCash logo as a homescreen.

will test a dummy release later to make sure the image files are properly packaged and relative paths work as expected

Jan 23 2025, 13:59
PiRK accepted D17578: [electrum][trezor] Fix homescreen reset.

probably broken in some major trezor API change (looks like they passed images as strings before, or maybe it was a python2 thing) https://github.com/spesmilo/electrum/commit/dda9d4b746700bfc095c80d84f1ac5de46c5f2ca

Jan 23 2025, 13:54
Fabien requested review of D17579: [electrum][trezor] 1-click install of the eCash logo as a homescreen.
Jan 23 2025, 13:36
PiRK updated the diff for D17577: [electrum] Implement SLIP-0039 wallet recovery..

minor improvements

Jan 23 2025, 13:09
Fabien accepted D17576: [electrum] pass the bip32 rootseed to the derivation path scanner.
Jan 23 2025, 13:05
Fabien requested review of D17578: [electrum][trezor] Fix homescreen reset.
Jan 23 2025, 13:02
PiRK planned changes to D17577: [electrum] Implement SLIP-0039 wallet recovery..

found a couple of minor fixups to backport

Jan 23 2025, 13:00
PiRK published D17577: [electrum] Implement SLIP-0039 wallet recovery. for review.
Jan 23 2025, 12:58
PiRK requested review of D17576: [electrum] pass the bip32 rootseed to the derivation path scanner.
Jan 23 2025, 10:20
bytesofman closed D17575: [Cashtab] No double notifications for SLP partial lists.
Jan 23 2025, 08:32
bytesofman committed rABC63dc3deda632: [Cashtab] No double notifications for SLP partial lists (authored by bytesofman).
[Cashtab] No double notifications for SLP partial lists
Jan 23 2025, 08:32
Fabien accepted D17575: [Cashtab] No double notifications for SLP partial lists.
Jan 23 2025, 08:16

Jan 22 2025

bytesofman published D17575: [Cashtab] No double notifications for SLP partial lists for review.
Jan 22 2025, 23:29
bytesofman added a comment to D17464: [ecash-lib] attach ecc and hashes to globalThis.

Some alt options on this diff

Jan 22 2025, 23:28
Unknown Object (User) added a comment to D7441: [CMAKE] Fix issues when looking for libraries installed with homebrew.
Jan 22 2025, 03:14

Jan 21 2025

teamcity closed T3727: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Jan 21 2025, 21:21
bytesofman closed D17571: [Cashtab] Make sure selectedOffer cannot be undefined after a ws update.
Jan 21 2025, 21:03
bytesofman committed rABCf840614d26c6: [Cashtab] Make sure selectedOffer cannot be undefined after a ws update (authored by bytesofman).
[Cashtab] Make sure selectedOffer cannot be undefined after a ws update
Jan 21 2025, 21:03
Fabien accepted D17574: [avalanche] Fixup incorrect comment about contender cache vote status.
Jan 21 2025, 20:27
roqqit requested review of D17574: [avalanche] Fixup incorrect comment about contender cache vote status.
Jan 21 2025, 19:36
Fabien requested changes to D17565: [Chronik] Add unix socket listener to test_runner.rs.
Jan 21 2025, 17:11
Fabien requested changes to D17564: [chronik] Add test runner to bitcoinsuite-chronik-client.
Jan 21 2025, 17:09
PiRK closed D17572: [electrum] refactor: introduce a Wordlist class for seed phrases.
Jan 21 2025, 16:32
PiRK committed rABCb7a52c79e63d: [electrum] refactor: introduce a Wordlist class for seed phrases (authored by PiRK).
[electrum] refactor: introduce a Wordlist class for seed phrases
Jan 21 2025, 16:32
PiRK closed D17570: [electrum] seed completer: colour words yellow if only in old electrum list.
Jan 21 2025, 16:32
PiRK closed D17569: [electrum] implement autocompletion when restoring from seed.
Jan 21 2025, 16:32
PiRK committed rABC47615a805bc7: [electrum] seed completer: colour words yellow if only in old electrum list (authored by SomberNight <somber.night@protonmail.com>).
[electrum] seed completer: colour words yellow if only in old electrum list
Jan 21 2025, 16:32
PiRK committed rABCd999f60ac80f: [electrum] implement autocompletion when restoring from seed (authored by PiRK).
[electrum] implement autocompletion when restoring from seed
Jan 21 2025, 16:32
PiRK closed D17568: [electrum] refactor text completion.
Jan 21 2025, 16:32
PiRK committed rABC415850772402: [electrum] refactor text completion (authored by Lastrellik <lastrellik@gmail.com>).
[electrum] refactor text completion
Jan 21 2025, 16:32
hazzarust updated the diff for D17565: [Chronik] Add unix socket listener to test_runner.rs.

New line added + updated server to make explicit

Jan 21 2025, 15:52
hazzarust updated the diff for D17564: [chronik] Add test runner to bitcoinsuite-chronik-client.

Removed assert_eq

Jan 21 2025, 15:37
Fabien accepted D17572: [electrum] refactor: introduce a Wordlist class for seed phrases.
Jan 21 2025, 15:34
Fabien accepted D17570: [electrum] seed completer: colour words yellow if only in old electrum list.
Jan 21 2025, 15:31
Fabien accepted D17569: [electrum] implement autocompletion when restoring from seed.
Jan 21 2025, 15:30
Fabien updated the summary of D17569: [electrum] implement autocompletion when restoring from seed.
Jan 21 2025, 15:28
Fabien updated the summary of D17569: [electrum] implement autocompletion when restoring from seed.
Jan 21 2025, 15:28
Fabien accepted D17568: [electrum] refactor text completion.
Jan 21 2025, 15:28
Fabien requested changes to D17565: [Chronik] Add unix socket listener to test_runner.rs.
Jan 21 2025, 15:24
Fabien requested changes to D17564: [chronik] Add test runner to bitcoinsuite-chronik-client.
Jan 21 2025, 15:22
PiRK added inline comments to D17572: [electrum] refactor: introduce a Wordlist class for seed phrases.
Jan 21 2025, 14:22
PiRK updated the diff for D17572: [electrum] refactor: introduce a Wordlist class for seed phrases.

no need for the list conversion. In our codebase bip39_list is already a list because we use Trezor's mnemonic library (so we can support multiple languages for restoring seeds) https://github.com/trezor/python-mnemonic/blob/master/src/mnemonic/mnemonic.py#L56

Jan 21 2025, 14:15
PiRK requested review of D17572: [electrum] refactor: introduce a Wordlist class for seed phrases.
Jan 21 2025, 14:04
emack accepted D17571: [Cashtab] Make sure selectedOffer cannot be undefined after a ws update.
Jan 21 2025, 13:16
PiRK updated the diff for D17568: [electrum] refactor text completion.

restore https://github.com/Bitcoin-ABC/ElectrumABC/commit/e2d0f7f804a0b805644957f423e04120cff921b3 and https://github.com/Bitcoin-ABC/ElectrumABC/commit/ac0da1446ed153c291b065cd9ef8a20ef561081d

Jan 21 2025, 12:38
PiRK planned changes to D17568: [electrum] refactor text completion.

I may have lost a few Electron Cash improvements in keyPressEvent in the process

Jan 21 2025, 12:22
PiRK updated the test plan for D17568: [electrum] refactor text completion.
Jan 21 2025, 12:12
bytesofman published D17571: [Cashtab] Make sure selectedOffer cannot be undefined after a ws update for review.
Jan 21 2025, 11:42
PiRK requested review of D17570: [electrum] seed completer: colour words yellow if only in old electrum list.
Jan 21 2025, 09:30
PiRK updated the summary of D17569: [electrum] implement autocompletion when restoring from seed.
Jan 21 2025, 09:17
PiRK requested review of D17569: [electrum] implement autocompletion when restoring from seed.
Jan 21 2025, 09:15
teamcity updated the summary of D17568: [electrum] refactor text completion.
Jan 21 2025, 08:44
PiRK requested review of D17568: [electrum] refactor text completion.
Jan 21 2025, 08:44

Jan 20 2025

hazzarust updated the diff for D17565: [Chronik] Add unix socket listener to test_runner.rs.

Removed useless comment

Jan 20 2025, 22:07
hazzarust updated the diff for D17565: [Chronik] Add unix socket listener to test_runner.rs.

Deleted second test, made socket error handling verbose

Jan 20 2025, 22:04
hazzarust updated the test plan for D17564: [chronik] Add test runner to bitcoinsuite-chronik-client.
Jan 20 2025, 21:58