Page MenuHomePhabricator
Feed All Stories

Feb 4 2025

bytesofman updated the diff for D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.

more robust check

Feb 4 2025, 17:37
bytesofman added a comment to D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.

So, this is not an exhaustive check; it just patches one (probably the most common) error case.

Feb 4 2025, 17:22
teamcity updated the summary of D17635: assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager.
Feb 4 2025, 16:58
PiRK requested review of D17635: assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager.
Feb 4 2025, 16:58
PiRK added a comment to D17634: chainparams: add blockhash to AssumeutxoData.

Note that the feature_deterministic_chain_setup.py test only exists in Bitcoin ABC, Bitcoin Core does not have it. We added it to demonstrate that the hardcoded regtests chainparams (block hashes and txoutsetinfo), which differ from Core due to differences in the block header format, are actually correct.

Feb 4 2025, 14:29
teamcity updated the summary of D17634: chainparams: add blockhash to AssumeutxoData.
Feb 4 2025, 14:25
PiRK requested review of D17634: chainparams: add blockhash to AssumeutxoData.
Feb 4 2025, 14:25
bytesofman planned changes to D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.

image.png (68×317 px, 6 KB)

Can you provide some context on how to validate this output from the script above and that it is indeed excluding the not-bought or cancelled offers?

Feb 4 2025, 14:25
teamcity updated the summary of D17633: assumeutxo: remove snapshot during -reindex{-chainstate}.
Feb 4 2025, 14:24
PiRK requested review of D17633: assumeutxo: remove snapshot during -reindex{-chainstate}.
Feb 4 2025, 14:24
teamcity updated the summary of D17632: net_processing: Request assumeutxo background chain blocks.
Feb 4 2025, 14:23
PiRK requested review of D17632: net_processing: Request assumeutxo background chain blocks.
Feb 4 2025, 14:23
emack requested changes to D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers.

image.png (68×317 px, 6 KB)

Can you provide some context on how to validate this output from the script above and that it is indeed excluding the not-bought or cancelled offers?

Feb 4 2025, 13:38
PiRK updated the summary of D17631: [net processing] pass a Peer to FindNextBlocksToDownload.
Feb 4 2025, 08:28
teamcity updated the summary of D17631: [net processing] pass a Peer to FindNextBlocksToDownload.
Feb 4 2025, 08:28
PiRK requested review of D17631: [net processing] pass a Peer to FindNextBlocksToDownload.
Feb 4 2025, 08:28
PiRK closed D17629: bugfix: correct is_snapshot_cs in VerifyDB.
Feb 4 2025, 07:05
PiRK committed rABC9b78e7fbb03e: bugfix: correct is_snapshot_cs in VerifyDB (authored by James O'Beirne <james.obeirne@pm.me>).
bugfix: correct is_snapshot_cs in VerifyDB
Feb 4 2025, 07:05
bytesofman published D17630: [ecash-agora] Do not include offers that have not been bought or canceled in historicOffers for review.
Feb 4 2025, 00:57

Feb 3 2025

roqqit accepted D17629: bugfix: correct is_snapshot_cs in VerifyDB.
Feb 3 2025, 17:02
bytesofman closed D17623: [ecash-lib] Better behavior of withPrefix() method in Address class.
Feb 3 2025, 12:49
bytesofman committed rABC12cff4fe1b5c: [ecash-lib] Better behavior of withPrefix() method in Address class (authored by bytesofman).
[ecash-lib] Better behavior of withPrefix() method in Address class
Feb 3 2025, 12:49
teamcity updated the summary of D17629: bugfix: correct is_snapshot_cs in VerifyDB.
Feb 3 2025, 10:22
PiRK requested review of D17629: bugfix: correct is_snapshot_cs in VerifyDB.
Feb 3 2025, 10:22
PiRK accepted D17623: [ecash-lib] Better behavior of withPrefix() method in Address class.
Feb 3 2025, 08:15
bytesofman closed D17625: [Cashtab] Always show send button on send screen.
Feb 3 2025, 04:19
bytesofman committed rABCe27f29ba4083: [Cashtab] Always show send button on send screen (authored by bytesofman).
[Cashtab] Always show send button on send screen
Feb 3 2025, 04:19
bytesofman closed D17628: [Cashtab] Do not wordbreak break-all for XECX summaries.
Feb 3 2025, 03:37
bytesofman committed rABC94b85cf554c2: [Cashtab] Do not wordbreak break-all for XECX summaries (authored by bytesofman).
[Cashtab] Do not wordbreak break-all for XECX summaries
Feb 3 2025, 03:37
bytesofman closed D17627: [Cashtab] Make sure hide balance toggle also hides XECX balance.
Feb 3 2025, 03:35
bytesofman committed rABC9b9a406c97e4: [Cashtab] Make sure hide balance toggle also hides XECX balance (authored by bytesofman).
[Cashtab] Make sure hide balance toggle also hides XECX balance
Feb 3 2025, 03:35
bytesofman added inline comments to D17627: [Cashtab] Make sure hide balance toggle also hides XECX balance.
Feb 3 2025, 03:34
emack accepted D17627: [Cashtab] Make sure hide balance toggle also hides XECX balance.
Feb 3 2025, 01:50
emack accepted D17628: [Cashtab] Do not wordbreak break-all for XECX summaries.
Feb 3 2025, 01:46
emack accepted D17625: [Cashtab] Always show send button on send screen.
Feb 3 2025, 01:43
emack added a comment to D17625: [Cashtab] Always show send button on send screen.

what is the browser / device here?

Ubuntu 22.04 / Chrome 125.0.6422.112

Feb 3 2025, 01:43
bytesofman published D17627: [Cashtab] Make sure hide balance toggle also hides XECX balance for review.
Feb 3 2025, 00:54
bytesofman published D17628: [Cashtab] Do not wordbreak break-all for XECX summaries for review.
Feb 3 2025, 00:24

Feb 2 2025

abc-bot committed rABC1dd9768348c7: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Feb 2 2025, 22:16
abc-bot committed rABC80574c33fccf: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Feb 2 2025, 22:08
teamcity closed T3733: Build Bitcoin-ABC / Master / Build without BIP70 is broken. as Resolved.
Feb 2 2025, 21:41
teamcity closed T3735: Build Bitcoin-ABC / Master / Build without Wallet is broken. as Resolved.
Feb 2 2025, 21:37
abc-bot committed rABCcfef1a072afa: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Feb 2 2025, 21:33
bytesofman added a comment to D17625: [Cashtab] Always show send button on send screen.

On extension the Send button is aligned left, which is correct but the rest of the component is overflowing off to the right as per current behavior. Makes the Send button almost look like a pop up not to mention it covers the labels beneath it.

image.png (1×627 px, 99 KB)

Feb 2 2025, 19:10
bytesofman updated the diff for D17625: [Cashtab] Always show send button on send screen.

give button container background color so scroll-behind looks cleaner, line it up with app buttons on mobile

Feb 2 2025, 19:08
bytesofman abandoned D17626: [Cashtab] Show close modal if window fails to close programmatically.

only reason to do this was potential safari behavior (that, if true, this diff would potentially not resolve)

Feb 2 2025, 14:28
teamcity triaged T3735: Build Bitcoin-ABC / Master / Build without Wallet is broken. as Unbreak Now! priority.
Feb 2 2025, 14:24
bytesofman closed D17624: [Cashtab] Patch button css.
Feb 2 2025, 14:19
bytesofman committed rABCb6b377f844aa: [Cashtab] Patch button css (authored by bytesofman).
[Cashtab] Patch button css
Feb 2 2025, 14:19
emack requested changes to D17626: [Cashtab] Show close modal if window fails to close programmatically.

Tested on iOS Safari 18.1.1 - after paying in cashtab.com it automatically routes back to the paybutton page with the bell and then goes back to the original wp article that triggered it. I'm not seeing the reported issue where it stays on Cashtab.com.

Feb 2 2025, 05:51
emack requested changes to D17625: [Cashtab] Always show send button on send screen.

On extension the Send button is aligned left, which is correct but the rest of the component is overflowing off to the right as per current behavior. Makes the Send button almost look like a pop up not to mention it covers the labels beneath it.

image.png (1×627 px, 99 KB)

Feb 2 2025, 05:00
emack accepted D17624: [Cashtab] Patch button css.
Feb 2 2025, 03:36
bytesofman updated the test plan for D17626: [Cashtab] Show close modal if window fails to close programmatically.
Feb 2 2025, 00:46
bytesofman published D17626: [Cashtab] Show close modal if window fails to close programmatically for review.
Feb 2 2025, 00:45

Feb 1 2025

bytesofman updated the diff for D17625: [Cashtab] Always show send button on send screen.

version bump + extension bump

Feb 1 2025, 23:54
bytesofman published D17625: [Cashtab] Always show send button on send screen for review.
Feb 1 2025, 23:48
bytesofman published D17624: [Cashtab] Patch button css for review.

note the test failure is from when I first put the diff up having accidentally deleted the file

Feb 1 2025, 23:32
PiRK updated the diff for D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.

rebase

Feb 1 2025, 07:52
bytesofman published D17623: [ecash-lib] Better behavior of withPrefix() method in Address class for review.
Feb 1 2025, 00:00

Jan 31 2025

teamcity closed T3732: Build Bitcoin-ABC / Master / Build without CLI is broken. as Resolved.
Jan 31 2025, 23:26
teamcity triaged T3733: Build Bitcoin-ABC / Master / Build without BIP70 is broken. as Unbreak Now! priority.
Jan 31 2025, 23:19
abc-bot committed rABCfa3cef37a6bb: [Automated] Update electrum checkpoints (authored by abc-bot).
[Automated] Update electrum checkpoints
Jan 31 2025, 23:08
teamcity triaged T3732: Build Bitcoin-ABC / Master / Build without CLI is broken. as Unbreak Now! priority.
Jan 31 2025, 22:38
tobias_ruck closed D17622: [ecash-lib] Support custom WASM URL and module.
Jan 31 2025, 22:22
tobias_ruck committed rABC92f16ad6b35e: [ecash-lib] Support custom WASM URL and module (authored by tobias_ruck).
[ecash-lib] Support custom WASM URL and module
Jan 31 2025, 22:22
roqqit updated the diff for D17615: [avalanche] Add stake contender to AnyVoteItem.

Make local acceptance match what this node would eventually vote

Jan 31 2025, 22:07
tobias_ruck updated the summary of D17622: [ecash-lib] Support custom WASM URL and module.
Jan 31 2025, 21:59
bytesofman accepted D17622: [ecash-lib] Support custom WASM URL and module.
Jan 31 2025, 21:58
tobias_ruck updated the diff for D17622: [ecash-lib] Support custom WASM URL and module.

add diff url

Jan 31 2025, 21:56
tobias_ruck requested review of D17622: [ecash-lib] Support custom WASM URL and module.
Jan 31 2025, 21:55
tobias_ruck closed D17621: [ecash-lib] Patch import in `mnemonic.ts`.
Jan 31 2025, 21:03
tobias_ruck committed rABC2ccbb46a96c1: [ecash-lib] Patch import in `mnemonic.ts` (authored by tobias_ruck).
[ecash-lib] Patch import in `mnemonic.ts`
Jan 31 2025, 21:03
bytesofman accepted D17621: [ecash-lib] Patch import in `mnemonic.ts`.
Jan 31 2025, 20:53
tobias_ruck updated the diff for D17621: [ecash-lib] Patch import in `mnemonic.ts`.

include diff url

Jan 31 2025, 20:50
tobias_ruck requested review of D17621: [ecash-lib] Patch import in `mnemonic.ts`.
Jan 31 2025, 20:49
PiRK closed D17620: test: Avoid intermittent timeout in feature_assumevalid.py.
Jan 31 2025, 19:16
PiRK committed rABCb70bc3b15dcd: test: Avoid intermittent timeout in feature_assumevalid.py (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
test: Avoid intermittent timeout in feature_assumevalid.py
Jan 31 2025, 19:16
Fabien accepted D17620: test: Avoid intermittent timeout in feature_assumevalid.py.
Jan 31 2025, 19:04
Fabien closed D17618: [avalanche] Track the finalized txs total sigchecks.
Jan 31 2025, 19:00
Fabien closed D17617: [avalanche] Track the total size of finalized txs.
Jan 31 2025, 19:00
Fabien committed rABC11131d472917: [avalanche] Track the total size of finalized txs (authored by Fabien).
[avalanche] Track the total size of finalized txs
Jan 31 2025, 19:00
Fabien committed rABC82cfa296052e: [avalanche] Track the finalized txs total sigchecks (authored by Fabien).
[avalanche] Track the finalized txs total sigchecks
Jan 31 2025, 19:00
teamcity updated the summary of D17620: test: Avoid intermittent timeout in feature_assumevalid.py.
Jan 31 2025, 19:00
PiRK requested review of D17620: test: Avoid intermittent timeout in feature_assumevalid.py.
Jan 31 2025, 19:00
PiRK added a comment to D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.

Unrelated failure, maybe fixed by https://github.com/bitcoin/bitcoin/pull/26651

Jan 31 2025, 18:49
tobias_ruck closed D17619: [ecash-lib] Publish 1.4.0, expose HD wallet and mnemonic functionality.
Jan 31 2025, 18:03
tobias_ruck committed rABC57bd51505b46: [ecash-lib] Publish 1.4.0, expose HD wallet and mnemonic functionality (authored by tobias_ruck).
[ecash-lib] Publish 1.4.0, expose HD wallet and mnemonic functionality
Jan 31 2025, 18:03
tobias_ruck updated the diff for D17619: [ecash-lib] Publish 1.4.0, expose HD wallet and mnemonic functionality.

bump version using npm, add link to diff

Jan 31 2025, 17:32
tobias_ruck updated the summary of D17619: [ecash-lib] Publish 1.4.0, expose HD wallet and mnemonic functionality.
Jan 31 2025, 17:30
teamcity added a comment to D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.
Jan 31 2025, 14:59
PiRK updated the diff for D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.

rebase
The previous CI failure is unrelated

Jan 31 2025, 14:43
PiRK accepted D17618: [avalanche] Track the finalized txs total sigchecks.
Jan 31 2025, 14:29
PiRK accepted D17617: [avalanche] Track the total size of finalized txs.
Jan 31 2025, 14:28
bytesofman accepted D17619: [ecash-lib] Publish 1.4.0, expose HD wallet and mnemonic functionality.

This not-quite doubles the package size (compressed: 150.4 kB -> 245.0 kB, uncompressed: 564.2 kB -> 934.9 kB), but since we still stay below 1 MB even uncompressed this doesn't seem to be a big issue

Jan 31 2025, 14:23
PiRK closed D17611: [chronik] return empty transaction history for an unknown scripthash.
Jan 31 2025, 14:13
PiRK committed rABCf7183b1f90d8: [chronik] return empty transaction history for an unknown scripthash (authored by PiRK).
[chronik] return empty transaction history for an unknown scripthash
Jan 31 2025, 14:13
tobias_ruck requested review of D17619: [ecash-lib] Publish 1.4.0, expose HD wallet and mnemonic functionality.
Jan 31 2025, 13:45
teamcity closed T3731: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Jan 31 2025, 13:32
tobias_ruck closed D17614: [ecash-lib] Add `HdNode` for HD wallets.
Jan 31 2025, 13:23
tobias_ruck committed rABC0992b4fdbcf9: [ecash-lib] Add `HdNode` for HD wallets (authored by tobias_ruck).
[ecash-lib] Add `HdNode` for HD wallets
Jan 31 2025, 13:23