- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
May 9 2019
May 9 2019
jasonbcox committed rABC90e16b238720: Merge #12842: Prevent concurrent savemempool (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12842: Prevent concurrent savemempool
Updated with ZCash as a disclosure relationship + updated the permalink to the responsible disclosure standard to the latest version.
jasonbcox committed rABCf479c40b04e3: Merge #11599: scripted-diff: Small locking rename (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11599: scripted-diff: Small locking rename
jasonbcox committed rABC4f4f0f720352: Merge #11578: net: Add missing lock in ProcessHeadersMessage(...) (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11578: net: Add missing lock in ProcessHeadersMessage(...)
jasonbcox updated the diff for D2960: Merge #10489: build: silence gcc7's implicit fallthrough warning.
Removed enabling implicit-fallthrough as the default
jasonbcox requested review of D2980: Merge #12287: Optimise lock behaviour for GuessVerificationProgress().
In D2980#70322, @Fabien wrote:The change in qt/clientmodel.cpp is missing (moved to interfaces/node.cpp).
jasonbcox updated the test plan for D2960: Merge #10489: build: silence gcc7's implicit fallthrough warning.
jasonbcox updated the diff for D2960: Merge #10489: build: silence gcc7's implicit fallthrough warning.
Rebase + added to CMake build
jasonbcox updated the summary of D2979: Merge #11281: Avoid permanent cs_main/cs_wallet lock during RescanFromTime.
jasonbcox updated the summary of D2958: Merge #12415: Interrupt loading thread after shutdown request.
jasonbcox updated the summary of D2960: Merge #10489: build: silence gcc7's implicit fallthrough warning.
jasonbcox updated the summary of D2980: Merge #12287: Optimise lock behaviour for GuessVerificationProgress().
jasonbcox updated the summary of D2890: Merge #11578: net: Add missing lock in ProcessHeadersMessage(...).
May 8 2019
May 8 2019
Herald added a reviewer for D3001: Merge #10154: init: Remove redundant logging code: Restricted Project.
Herald added a reviewer for D2999: Merge #10126: Compensate for memory peak at flush time: Restricted Project.
jasonbcox updated the diff for D2890: Merge #11578: net: Add missing lock in ProcessHeadersMessage(...).
Rebase + added test_runner.py to test plan
jasonbcox updated the test plan for D2890: Merge #11578: net: Add missing lock in ProcessHeadersMessage(...).
jasonbcox committed rABCea5179582819: Merge #13080: mempool: Add compile time checking for ::mempool.cs runtime… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13080: mempool: Add compile time checking for ::mempool.cs runtime…
jasonbcox committed rABC62cdb28b5acf: Make functions in rpc/blockchain.cpp static. (authored by jasonbcox).
Make functions in rpc/blockchain.cpp static.
Nit for the test plan: Include the build without static linking, which would produce results for readelf -d src/bitcoind | grep libstdc++
jasonbcox requested changes to D2984: Merge #9333: Document CWalletTx::mapValue entries and remove erase of nonexistent "version" entry..
The mapValue.erase("version"); is clearly a code change and requires some sort of testing. A make check + test_runner.py would be sufficient if tests cover this area. Fortunately, the tests have been run for you, but do make sure to mention that this is the intention in the test plan.
Rebase on D2996
Herald added a reviewer for D2996: Merge #11599: scripted-diff: Small locking rename: Restricted Project.
jasonbcox updated the diff for D2979: Merge #11281: Avoid permanent cs_main/cs_wallet lock during RescanFromTime.
Rebase + missing braces
Herald added a reviewer for D2995: Merge #12842: Prevent concurrent savemempool: Restricted Project.
jasonbcox accepted D2988: Merge #9916: Fix msvc compiler error C4146 (minus operator applied to unsigned type).
Stupid, but I don't want to own this code right now...
jasonbcox committed rABC007edfcb94b1: Merge #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is…
jasonbcox committed rABC105a473fc6dd: Merge #11099: [RPC][mempool]: Add savemempool RPC (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #11099: [RPC][mempool]: Add savemempool RPC
Noting here that this also partially backports PR 9995, but it's so minor that I'm not going to make you backport them separately.
jasonbcox committed rABCeaa496a915de: Merge #10265: [wallet] [moveonly] Check non-null pindex before potentially… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10265: [wallet] [moveonly] Check non-null pindex before potentially…
I can't find the comment right now, but we had a short convo about not adding this at this time. The value of doing so isn't clear beyond estimating IBD time in the GUI. If that's true, we already know it to be quite inaccurate, so doing this just adds work to our release process.
jasonbcox committed rABC570483fa8d1f: Merge #12681: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12681: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER
jasonbcox committed rABCfde4c39de298: Merge #11744: net: Add missing locks in net.{cpp,h} (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11744: net: Add missing locks in net.{cpp,h}
Revert removal of code block
jasonbcox committed rABCcbffe79e55a7: Merge #12206: qa: Sync with validationinterface queue in sync_mempools (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12206: qa: Sync with validationinterface queue in sync_mempools
May 7 2019
May 7 2019
jasonbcox updated the diff for D2951: Merge #12206: qa: Sync with validationinterface queue in sync_mempools.
Sort + align
jasonbcox committed rABC4cfd8bdde7e1: Merge #9539: [net] Avoid initialization to a value that is never read (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #9539: [net] Avoid initialization to a value that is never read
Herald added a reviewer for D2980: Merge #12287: Optimise lock behaviour for GuessVerificationProgress(): Restricted Project.
Does not build. Clearing this off the queue for now...
jasonbcox updated the diff for D2979: Merge #11281: Avoid permanent cs_main/cs_wallet lock during RescanFromTime.
Fix comment
Herald added a reviewer for D2979: Merge #11281: Avoid permanent cs_main/cs_wallet lock during RescanFromTime: Restricted Project.
jasonbcox updated the diff for D2974: Merge #10265: [wallet] [moveonly] Check non-null pindex before potentially referencing.
Rebase ontop of D2976
Herald added a reviewer for D2974: Merge #10265: [wallet] [moveonly] Check non-null pindex before potentially referencing: Restricted Project.
Herald added a reviewer for D2973: Merge #12681: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER: Restricted Project.