Page MenuHomePhabricator
Feed Advanced Search

Oct 26 2020

jasonbcox requested changes to D8133: [backport#12510] test: Add rpc_bind test to default-run tests.

Missing the equivalent change to test_runner's TEST_PARAMS

Oct 26 2020, 20:46
jasonbcox accepted D8128: [website] Add Tcrypt as a sponsor.
Oct 26 2020, 18:39
jasonbcox accepted D8130: [website] Change explorer in donation address link.
Oct 26 2020, 18:37
jasonbcox closed D8127: Error out if jq is not installed when fetching docs.
Oct 26 2020, 17:32
jasonbcox committed rABCWEB832c476edd11: Error out if jq is not installed when fetching docs (authored by jasonbcox).
Error out if jq is not installed when fetching docs
Oct 26 2020, 17:32
jasonbcox closed D8126: Gracefully degrade when no releases are detected.
Oct 26 2020, 17:31
jasonbcox committed rABCWEB5bcc960c0e8e: Gracefully degrade when no releases are detected (authored by jasonbcox).
Gracefully degrade when no releases are detected
Oct 26 2020, 17:31
jasonbcox closed D8125: Move a release note that belongs in the 0.22.6 release.
Oct 26 2020, 17:19
jasonbcox committed rABC614642a768be: Move a release note that belongs in the 0.22.6 release (authored by jasonbcox).
Move a release note that belongs in the 0.22.6 release
Oct 26 2020, 17:19
jasonbcox requested review of D8127: Error out if jq is not installed when fetching docs.
Oct 26 2020, 17:18
jasonbcox requested review of D8126: Gracefully degrade when no releases are detected.
Oct 26 2020, 17:11
jasonbcox requested review of D8125: Move a release note that belongs in the 0.22.6 release.
Oct 26 2020, 16:25
jasonbcox closed D8091: Bump version to 0.22.6.
Oct 26 2020, 16:20
jasonbcox committed rABC12cb8c9d40ce: Bump version to 0.22.6 (authored by jasonbcox).
Bump version to 0.22.6
Oct 26 2020, 16:20

Oct 23 2020

jasonbcox closed D8090: Automatically show a customized message for the upgrade notice before and after activation.
Oct 23 2020, 22:51
jasonbcox committed rABCWEBa6e76b9d7f3e: Automatically show a customized message for the upgrade notice before and after… (authored by jasonbcox).
Automatically show a customized message for the upgrade notice before and after…
Oct 23 2020, 22:51
jasonbcox closed D8089: Add an upgrade notice on the release page.
Oct 23 2020, 22:51
jasonbcox committed rABCWEB5fbbb36af49e: Add an upgrade notice on the release page (authored by jasonbcox).
Add an upgrade notice on the release page
Oct 23 2020, 22:51
jasonbcox requested review of D8091: Bump version to 0.22.6.
Oct 23 2020, 22:50
jasonbcox requested review of D8090: Automatically show a customized message for the upgrade notice before and after activation.
Oct 23 2020, 22:13
jasonbcox updated the diff for D8089: Add an upgrade notice on the release page.

Move the upgrade notice to an include

Oct 23 2020, 21:11
jasonbcox requested review of D8089: Add an upgrade notice on the release page.
Oct 23 2020, 21:04
jasonbcox closed D8064: Merge #18262: bnb: exit selection when best_waste is 0.
Oct 23 2020, 18:44
jasonbcox committed rABC113104448c86: Merge #18262: bnb: exit selection when best_waste is 0 (authored by Samuel Dobson <dobsonsa68@gmail.com>).
Merge #18262: bnb: exit selection when best_waste is 0
Oct 23 2020, 18:44
jasonbcox accepted D8085: [BUILDBOT] Use phabricator version from master instead of pip.
Oct 23 2020, 17:16
jasonbcox accepted D8026: [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137..
Oct 23 2020, 17:13
jasonbcox accepted D8081: Remove the Dockerfile-doxygen file.
Oct 23 2020, 17:05

Oct 22 2020

jasonbcox closed D8063: Merge #17522: test: Wait until mempool is loaded in wallet_abandonconflict.
Oct 22 2020, 23:21
jasonbcox committed rABCecc9c997c95d: Merge #17522: test: Wait until mempool is loaded in wallet_abandonconflict (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #17522: test: Wait until mempool is loaded in wallet_abandonconflict
Oct 22 2020, 23:21
jasonbcox requested review of D8064: Merge #18262: bnb: exit selection when best_waste is 0.
Oct 22 2020, 23:08
jasonbcox requested review of D8063: Merge #17522: test: Wait until mempool is loaded in wallet_abandonconflict.
Oct 22 2020, 22:53
jasonbcox closed D8034: Merge #13928: qa: blocktools enforce named args for amount.
Oct 22 2020, 22:00
jasonbcox committed rABC7eb5e1e2e49a: Merge #13928: qa: blocktools enforce named args for amount (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13928: qa: blocktools enforce named args for amount
Oct 22 2020, 22:00
jasonbcox closed D8060: [build-bot] Fix database test when an extension is not present on the database file.
Oct 22 2020, 21:25
jasonbcox committed rABC47e2944da10c: [build-bot] Fix database test when an extension is not present on the database… (authored by jasonbcox).
[build-bot] Fix database test when an extension is not present on the database…
Oct 22 2020, 21:25
jasonbcox accepted D8057: [backport#15558] Do not query all DNS seed at once.
Oct 22 2020, 21:17
jasonbcox requested changes to D8026: [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137..
Oct 22 2020, 21:16
jasonbcox requested changes to D8057: [backport#15558] Do not query all DNS seed at once.
Oct 22 2020, 17:38
jasonbcox accepted D8058: [BUILDBOT] Remove unecessary imports of the phabricator library.
Oct 22 2020, 17:32
jasonbcox requested review of D8034: Merge #13928: qa: blocktools enforce named args for amount.

Re-ran CI. It looks like the new logging fix is working, so hopefully we can nail the flakiness in that test soon.

Oct 22 2020, 17:15
jasonbcox requested review of D8060: [build-bot] Fix database test when an extension is not present on the database file.
Oct 22 2020, 17:05
jasonbcox closed D8059: Add more release notes.
Oct 22 2020, 16:08
jasonbcox committed rABC8e73a882cb48: Add more release notes (authored by jasonbcox).
Add more release notes
Oct 22 2020, 16:08
jasonbcox requested review of D8059: Add more release notes.
Oct 22 2020, 16:05

Oct 21 2020

jasonbcox requested changes to D8026: [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137..
Oct 21 2020, 21:53
jasonbcox closed D8031: Merge #15772: test: Properly log named args in authproxy.
Oct 21 2020, 21:41
jasonbcox committed rABC0064e37fff35: Merge #15772: test: Properly log named args in authproxy (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15772: test: Properly log named args in authproxy
Oct 21 2020, 21:41
jasonbcox requested review of D8034: Merge #13928: qa: blocktools enforce named args for amount.
Oct 21 2020, 21:35
jasonbcox closed D8033: Merge #14664: example_test.py: fixup coinbase height argument, derive number clearly.
Oct 21 2020, 21:28
jasonbcox committed rABC438ec29b07f7: Merge #14664: example_test.py: fixup coinbase height argument, derive number… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14664: example_test.py: fixup coinbase height argument, derive number…
Oct 21 2020, 21:28
jasonbcox closed D8030: [build-bot] Fix skipping comments in ignore list.
Oct 21 2020, 21:21
jasonbcox committed rABCa99c8c9710a8: [build-bot] Fix skipping comments in ignore list (authored by jasonbcox).
[build-bot] Fix skipping comments in ignore list
Oct 21 2020, 21:21
jasonbcox accepted D8012: Add <datadir>/settings.json persistent settings storage..
Oct 21 2020, 21:18
jasonbcox closed D8028: [build-bot] Use unittest.assert* instead of plain asserts.
Oct 21 2020, 21:01
jasonbcox committed rABCab27bf8d7a87: [build-bot] Use unittest.assert* instead of plain asserts (authored by jasonbcox).
[build-bot] Use unittest.assert* instead of plain asserts
Oct 21 2020, 21:01
jasonbcox closed D8032: Merge #15631: qa: mininode: Clearer error message on invalid magic bytes.
Oct 21 2020, 20:47
jasonbcox committed rABC25ce183dcc9f: Merge #15631: qa: mininode: Clearer error message on invalid magic bytes (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15631: qa: mininode: Clearer error message on invalid magic bytes
Oct 21 2020, 20:47
jasonbcox closed D7994: [build-bot] Persist build info between redeployments.
Oct 21 2020, 19:54
jasonbcox committed rABC594d974a35d2: [build-bot] Persist build info between redeployments (authored by jasonbcox).
[build-bot] Persist build info between redeployments
Oct 21 2020, 19:54
jasonbcox closed D8029: [build-bot] Correctly match hex in ignore pattern for flaky Windows cross-builds.
Oct 21 2020, 19:39
jasonbcox committed rABC7aec57ad89cd: [build-bot] Correctly match hex in ignore pattern for flaky Windows cross-builds (authored by jasonbcox).
[build-bot] Correctly match hex in ignore pattern for flaky Windows cross-builds
Oct 21 2020, 19:39
jasonbcox updated the diff for D8030: [build-bot] Fix skipping comments in ignore list.

Added strip() to detect indented comments as well

Oct 21 2020, 19:22
jasonbcox requested review of D8033: Merge #14664: example_test.py: fixup coinbase height argument, derive number clearly.
Oct 21 2020, 18:53
jasonbcox requested review of D8032: Merge #15631: qa: mininode: Clearer error message on invalid magic bytes.
Oct 21 2020, 18:48
jasonbcox closed D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 18:44
jasonbcox added a reverting change for D7729: Revert recent coin selection changes: rABC54fef78d5b20: Revert "Revert recent coin selection changes".
Oct 21 2020, 18:44
jasonbcox committed rABC54fef78d5b20: Revert "Revert recent coin selection changes" (authored by jasonbcox).
Revert "Revert recent coin selection changes"
Oct 21 2020, 18:44
jasonbcox added a reverting change for rABC85f266319f58: Revert recent coin selection changes: rABC54fef78d5b20: Revert "Revert recent coin selection changes".
Oct 21 2020, 18:44
jasonbcox requested review of D8031: Merge #15772: test: Properly log named args in authproxy.
Oct 21 2020, 18:43
jasonbcox requested review of D8030: [build-bot] Fix skipping comments in ignore list.
Oct 21 2020, 18:26
jasonbcox requested review of D8029: [build-bot] Correctly match hex in ignore pattern for flaky Windows cross-builds.
Oct 21 2020, 18:23
jasonbcox requested review of D8028: [build-bot] Use unittest.assert* instead of plain asserts.
Oct 21 2020, 17:26
jasonbcox updated the diff for D7994: [build-bot] Persist build info between redeployments.

Fixed according to feedback

Oct 21 2020, 16:55
jasonbcox updated the diff for D8015: Revert "Revert recent coin selection changes".
  • Rebase
  • Updated summary to better reflect the "why"
Oct 21 2020, 16:28
jasonbcox updated the summary of D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 16:27
jasonbcox closed D8014: test: Set catch_system_errors=no on boost unit tests.
Oct 21 2020, 16:04
jasonbcox committed rABC1a60077296f7: test: Set catch_system_errors=no on boost unit tests (authored by jasonbcox).
test: Set catch_system_errors=no on boost unit tests
Oct 21 2020, 16:04
jasonbcox added inline comments to D8014: test: Set catch_system_errors=no on boost unit tests.
Oct 21 2020, 00:35
jasonbcox requested review of D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 00:33
jasonbcox added inline comments to D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 00:14
jasonbcox updated the test plan for D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 00:13
jasonbcox added a comment to D8015: Revert "Revert recent coin selection changes".

@bot build-tsan

Oct 21 2020, 00:13
jasonbcox planned changes to D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 00:12
jasonbcox requested review of D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 00:12
jasonbcox added a reverting change for D7729: Revert recent coin selection changes: D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 00:12
jasonbcox added a reverting change for rABC85f266319f58: Revert recent coin selection changes: D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 00:12

Oct 20 2020

jasonbcox requested review of D8014: test: Set catch_system_errors=no on boost unit tests.
Oct 20 2020, 23:46
jasonbcox requested changes to D8012: Add <datadir>/settings.json persistent settings storage..

Back to you. Still a translation issue.

Oct 20 2020, 19:10
jasonbcox accepted D8011: util: Add ReadSettings and WriteSettings functions.
Oct 20 2020, 19:09
jasonbcox closed D7996: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept.
Oct 20 2020, 17:33
jasonbcox committed rABC7caa48fc89ba: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept
Oct 20 2020, 17:33
jasonbcox accepted D8006: [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys().
Oct 20 2020, 16:16
jasonbcox accepted D8008: [backport#16822 3/3] gui: fix autofocus in CreateWalletActivity::askPassphrase().
Oct 20 2020, 16:06
jasonbcox accepted D8007: [backport#16822 2/3] gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog.
Oct 20 2020, 16:05
jasonbcox requested changes to D8006: [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys().
Oct 20 2020, 16:04
jasonbcox accepted D8010: [backport#16847] doc: add comments clarifying how local services are advertised.
Oct 20 2020, 16:00
jasonbcox closed D7995: Merge #16931: test: add unittests for CheckProofOfWork.
Oct 20 2020, 15:59
jasonbcox committed rABCa87c1a8f2312: Merge #16931: test: add unittests for CheckProofOfWork (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #16931: test: add unittests for CheckProofOfWork
Oct 20 2020, 15:59
jasonbcox updated the diff for D7996: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept.

Rebase

Oct 20 2020, 15:58
jasonbcox accepted D8009: doc: Add detailed info about Bitcoin Core files.
Oct 20 2020, 15:49