In D2873#68039, @jasonbcox wrote:

Although this backport looks ok, I do think we should investigate test coverage in the future

In D2873#68026, @jasonbcox wrote:

I don't see this being used in https://github.com/bitcoin/bitcoin/pull/14121/files Why is it needed?

getting commit fef5adcc3 looks like it should be done after T590, though it looks like the rest of backports can proceed independently of that.

rebase

forgot cmakelists for test

cstdint

char eradication and header normalization

• added cmakelists entry
• created siphash.* files from ABC code instead of Core code

getting this rolling again ...

fix comments & typo

• remove seek method per later backport
• adjust comments style per comments
• use cstdint types

squashed in child commit

It's been a couple of weeks. @Mondas if you want to reactivate this Diff, let me know.

s/Qt/bitcoin-qt

add release note

Need fix: https://github.com/bitcoin/bitcoin/pull/11332

• add extra node for doing actual ban-checking (whitelist was stopping this)
• include positive ban tests (for schnorr multisig)
• get rid of update_block

Yeah that was hideous before ... linters aren't always right. :-D

Not 100% sure about the placement of this, but I think it does deserve to go *somewhere*.

A nice simplification and improvement. Presumably there is no chance that StopHTTPServer will be called during StartHTTPServer execution, as they are only ever called from a particular thread?

use wait_for_tip instead of sync_blocks

Check out the debug logs.

various:

• rebase on now-landed D2479 (+ address conflicts in overlap)
• now fully mock-timed
• added actual mininode testing of non-banning (borrowed from D2479)
• added a reorg test at end, for good measure
• nits

@dagurval points out, maybe we want to go straight for https://github.com/bitcoin/bitcoin/pull/14670 ... sounds like this exits uncleanly in some cases?

some tiny nits that @Fabien pointed out on D2483 / D2527

• fully mock test time
• one more sendrawtransaction rejection test
• misc changes

rebase after D2527 landing

commandeering this one for the home stretch

rebase after D2527 landing

last nit for % formatting

address jason comments

address requests for change:

• misc nits
• logging messages altered
• test now fully mock-timed
• expanded comments about how transactions are tracked in invalidateblock and reorg events

Gonna take control of this as florian will be away for the next few days, and this needs landing soon. Thanks for the hard work thus far @florian . :-D

@Fabien ping