Page MenuHomePhabricator
Feed Advanced Search

Jun 11 2020

nakihito updated the diff for D6526: Merge #14719: qa: Check specific reject reasons in feature_block.

Fixed test and text plan.

Jun 11 2020, 17:23
nakihito requested review of D6526: Merge #14719: qa: Check specific reject reasons in feature_block.
Jun 11 2020, 02:20
nakihito requested review of D6525: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request.
Jun 11 2020, 02:07

Jun 10 2020

nakihito committed rABCadeae3daa503: Merge #14626: Select orphan transaction uniformly for eviction (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14626: Select orphan transaction uniformly for eviction
Jun 10 2020, 17:45
nakihito closed D6488: Merge #14626: Select orphan transaction uniformly for eviction.
Jun 10 2020, 17:45

Jun 9 2020

nakihito committed rABC6f41fa19a3ca: Increase maxconnections limit when using poll. (authored by Patrick Strateman <patrick.strateman@gmail.com>).
Increase maxconnections limit when using poll.
Jun 9 2020, 23:52
nakihito closed D6471: Increase maxconnections limit when using poll..
Jun 9 2020, 23:52
nakihito committed rABC898802efaa58: Implement poll() on systems which support it properly. (authored by Patrick Strateman <patrick.strateman@gmail.com>).
Implement poll() on systems which support it properly.
Jun 9 2020, 23:42
nakihito closed D6470: Implement poll() on systems which support it properly..
Jun 9 2020, 23:42
nakihito committed rABC96827c217616: Move SocketEvents logic to private method. (authored by Patrick Strateman <patrick.strateman@gmail.com>).
Move SocketEvents logic to private method.
Jun 9 2020, 23:32
nakihito closed D6461: Move SocketEvents logic to private method..
Jun 9 2020, 23:32
nakihito committed rABC716ac6e899ad: Move GenerateSelectSet logic to private method. (authored by Patrick Strateman <patrick.strateman@gmail.com>).
Move GenerateSelectSet logic to private method.
Jun 9 2020, 23:21
nakihito closed D6460: Move GenerateSelectSet logic to private method..
Jun 9 2020, 23:21
nakihito committed rABC7ef2a7b7612c: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS. (authored by Patrick Strateman <patrick.strateman@gmail.com>).
Introduce and use constant SELECT_TIMEOUT_MILLISECONDS.
Jun 9 2020, 23:13
nakihito closed D6459: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS..
Jun 9 2020, 23:13
nakihito committed rABCa242a8ddcadd: Merge #15597: net: Generate log entry when blocks messages are received… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15597: net: Generate log entry when blocks messages are received…
Jun 9 2020, 23:06
nakihito closed D6491: Merge #15597: net: Generate log entry when blocks messages are received unexpectedly.
Jun 9 2020, 23:06
nakihito committed rABC9dca86e63a4a: Merge #15718: docs: Improve netaddress comments (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15718: docs: Improve netaddress comments
Jun 9 2020, 22:57
nakihito closed D6494: Merge #15718: docs: Improve netaddress comments.
Jun 9 2020, 22:57
nakihito requested review of D6494: Merge #15718: docs: Improve netaddress comments.
Jun 9 2020, 21:26
nakihito updated the diff for D6471: Increase maxconnections limit when using poll..

Rebased.

Jun 9 2020, 20:23
nakihito updated the diff for D6459: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS..

Rebased.

Jun 9 2020, 20:20
nakihito committed rABCee323c8b68d7: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...)… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...)…
Jun 9 2020, 20:17
nakihito closed D6481: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions..
Jun 9 2020, 20:17
nakihito requested review of D6481: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions..
Jun 9 2020, 20:09
nakihito updated the test plan for D6481: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions..
Jun 9 2020, 20:09
nakihito updated the diff for D6489: Merge #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups.

Fixed comment.

Jun 9 2020, 20:06
nakihito requested review of D6491: Merge #15597: net: Generate log entry when blocks messages are received unexpectedly.
Jun 9 2020, 20:03
nakihito requested review of D6489: Merge #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups.
Jun 9 2020, 19:21
nakihito updated the summary of D6283: [seeder] Request headers from new connections.
Jun 9 2020, 18:58
nakihito requested review of D6488: Merge #14626: Select orphan transaction uniformly for eviction.
Jun 9 2020, 18:35
nakihito committed rABCc1e1a85bd303: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive
Jun 9 2020, 18:31
nakihito closed D6476: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive.
Jun 9 2020, 18:31
nakihito committed rABC89c98c77854c: Merge #15254: Trivial: fixup a few doxygen comments (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15254: Trivial: fixup a few doxygen comments
Jun 9 2020, 18:28
nakihito closed D6475: Merge #15254: Trivial: fixup a few doxygen comments.
Jun 9 2020, 18:28
nakihito committed rABC47f476c061cf: Merge #15194: Add comment describing fDisconnect behavior (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15194: Add comment describing fDisconnect behavior
Jun 9 2020, 18:24
nakihito closed D6474: Merge #15194: Add comment describing fDisconnect behavior.
Jun 9 2020, 18:24
nakihito committed rABC03892e93a414: Merge #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg
Jun 9 2020, 18:21
nakihito closed D6472: Merge #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg.
Jun 9 2020, 18:20
nakihito closed D6457: Merge #14436: doc: add comment explaining recentRejects-DoS behavior.
Jun 9 2020, 18:12
nakihito committed rABC063c90dc91a7: Merge #14436: doc: add comment explaining recentRejects-DoS behavior (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14436: doc: add comment explaining recentRejects-DoS behavior
Jun 9 2020, 18:12
nakihito committed rABCe269cb2f708c: Merge #14054: p2p: Disable BIP 61 by default (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14054: p2p: Disable BIP 61 by default
Jun 9 2020, 18:07
nakihito closed D6455: Merge #14054: p2p: Disable BIP 61 by default.
Jun 9 2020, 18:07
nakihito planned changes to D6481: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions..
Jun 9 2020, 17:46
nakihito committed rABC7de90a0236ab: Merge #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check
Jun 9 2020, 17:45
nakihito closed D6454: Merge #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check.
Jun 9 2020, 17:45
nakihito updated the diff for D6460: Move GenerateSelectSet logic to private method..

Addressed nit.

Jun 9 2020, 17:12
nakihito requested review of D6481: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions..
Jun 9 2020, 17:09
nakihito requested review of D6476: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive.
Jun 9 2020, 00:42
nakihito requested review of D6475: Merge #15254: Trivial: fixup a few doxygen comments.
Jun 9 2020, 00:21
nakihito updated the summary of D6475: Merge #15254: Trivial: fixup a few doxygen comments.
Jun 9 2020, 00:21
nakihito planned changes to D6475: Merge #15254: Trivial: fixup a few doxygen comments.
Jun 9 2020, 00:18
nakihito requested review of D6475: Merge #15254: Trivial: fixup a few doxygen comments.
Jun 9 2020, 00:18

Jun 8 2020

nakihito requested review of D6474: Merge #15194: Add comment describing fDisconnect behavior.
Jun 8 2020, 23:53
nakihito requested review of D6472: Merge #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg.
Jun 8 2020, 23:02
nakihito requested review of D6461: Move SocketEvents logic to private method..
Jun 8 2020, 22:16
nakihito requested review of D6470: Implement poll() on systems which support it properly..
Jun 8 2020, 22:16
nakihito requested review of D6460: Move GenerateSelectSet logic to private method..
Jun 8 2020, 22:16
nakihito requested review of D6471: Increase maxconnections limit when using poll..
Jun 8 2020, 22:16
nakihito updated the summary of D6471: Increase maxconnections limit when using poll..
Jun 8 2020, 22:15
nakihito updated the summary of D6470: Implement poll() on systems which support it properly..
Jun 8 2020, 22:15
nakihito updated the summary of D6461: Move SocketEvents logic to private method..
Jun 8 2020, 22:15
nakihito updated the summary of D6460: Move GenerateSelectSet logic to private method..
Jun 8 2020, 22:14
nakihito planned changes to D6471: Increase maxconnections limit when using poll..
Jun 8 2020, 22:13
nakihito requested review of D6471: Increase maxconnections limit when using poll..
Jun 8 2020, 22:13
nakihito planned changes to D6470: Implement poll() on systems which support it properly..
Jun 8 2020, 21:48
nakihito requested review of D6470: Implement poll() on systems which support it properly..
Jun 8 2020, 21:48
nakihito planned changes to D6461: Move SocketEvents logic to private method..
Jun 8 2020, 20:12
nakihito requested review of D6461: Move SocketEvents logic to private method..
Jun 8 2020, 20:12
nakihito planned changes to D6460: Move GenerateSelectSet logic to private method..
Jun 8 2020, 20:07
nakihito requested review of D6460: Move GenerateSelectSet logic to private method..
Jun 8 2020, 20:07
nakihito requested review of D6459: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS..
Jun 8 2020, 19:53
nakihito planned changes to D6459: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS..
Jun 8 2020, 19:51
nakihito requested review of D6459: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS..
Jun 8 2020, 19:51
nakihito requested review of D6457: Merge #14436: doc: add comment explaining recentRejects-DoS behavior.
Jun 8 2020, 18:22
nakihito requested review of D6455: Merge #14054: p2p: Disable BIP 61 by default.
Jun 8 2020, 17:56
nakihito requested review of D6454: Merge #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check.
Jun 8 2020, 17:32

Jun 6 2020

nakihito accepted D6400: [refactor] Move tx relay state to separate structure.
Jun 6 2020, 22:46
nakihito accepted D6401: [refactor] Change tx_relay structure to be unique_ptr.
Jun 6 2020, 01:16
nakihito requested changes to D6400: [refactor] Move tx relay state to separate structure.
Jun 6 2020, 01:11
nakihito accepted D6398: Use BlockHash for vInventoryBlockToSend.
Jun 6 2020, 00:45
nakihito accepted D6399: Remove unused variable.
Jun 6 2020, 00:43
nakihito requested review of D5380: [seeder] Require good seeds to have latest checkpoint.
Jun 6 2020, 00:41
nakihito requested review of D6283: [seeder] Request headers from new connections.
Jun 6 2020, 00:41
nakihito requested review of D6357: Dedup net message writing code in the seeder.

Updated summary to remove mention of previous seeder implementation being unable to send multiple messages. This was actually the result of a different bug that made it appear as if it was not possible.

Jun 6 2020, 00:40
nakihito planned changes to D5380: [seeder] Require good seeds to have latest checkpoint.
Jun 6 2020, 00:34
nakihito updated the diff for D5380: [seeder] Require good seeds to have latest checkpoint.

Rebased and changed the finish state to reflect changes to the getheaders trigger.

Jun 6 2020, 00:34
nakihito planned changes to D6283: [seeder] Request headers from new connections.
Jun 6 2020, 00:27
nakihito updated the diff for D6283: [seeder] Request headers from new connections.

Make use of CBlockLocator class.

Jun 6 2020, 00:27
nakihito planned changes to D6357: Dedup net message writing code in the seeder.
Jun 6 2020, 00:26
nakihito updated the diff for D6357: Dedup net message writing code in the seeder.

Added additionally test case.

Jun 6 2020, 00:26

Jun 5 2020

nakihito planned changes to D6283: [seeder] Request headers from new connections.
Jun 5 2020, 22:59
nakihito updated the diff for D6283: [seeder] Request headers from new connections.

Rebased off D6357. Adjusted trigger for GETHEADERS message to occur with GETADDR.

Jun 5 2020, 22:59
nakihito planned changes to D6357: Dedup net message writing code in the seeder.
Jun 5 2020, 22:54
nakihito updated the diff for D6357: Dedup net message writing code in the seeder.

Reverted vSend to CDataStream and adjusted unit tests to reflect this.

Jun 5 2020, 22:54
nakihito updated the summary of D6357: Dedup net message writing code in the seeder.
Jun 5 2020, 22:50

Jun 4 2020

nakihito planned changes to D6357: Dedup net message writing code in the seeder.
Jun 4 2020, 22:37
nakihito committed rABC6dd46aa22018: Rename Seeder's CAddrInfo -> CSeederAddrInfo (authored by nakihito).
Rename Seeder's CAddrInfo -> CSeederAddrInfo
Jun 4 2020, 00:20
nakihito closed D6355: Rename Seeder's CAddrInfo -> CSeederAddrInfo.
Jun 4 2020, 00:20
nakihito updated the diff for D6355: Rename Seeder's CAddrInfo -> CSeederAddrInfo.

Removed C prefix.

Jun 4 2020, 00:07