Page MenuHomePhabricator
Feed Advanced Search

Jan 28 2021

PiRK closed D9085: [test] test that an invalid GETDATA doesn't prevent processing of future messages.
Jan 28 2021, 08:43
PiRK committed rABCcd5131913fa9: [test] test that an invalid GETDATA doesn't prevent processing of future… (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[test] test that an invalid GETDATA doesn't prevent processing of future…
Jan 28 2021, 08:43
PiRK closed D9084: [net processing] ignore unknown INV types in GETDATA messages.
Jan 28 2021, 08:14
PiRK committed rABCa3dac181b44c: [net processing] ignore unknown INV types in GETDATA messages (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[net processing] ignore unknown INV types in GETDATA messages
Jan 28 2021, 08:14
PiRK accepted D9095: [BUILDBOT] Work around phabricator API change.
Jan 28 2021, 08:10
PiRK accepted D9089: [Cashtab patch] Adjust input field step for cash or crypto.
Jan 28 2021, 08:05
PiRK requested review of D9097: gui: Fix itemWalletAddress leak when not tree mode.
Jan 28 2021, 07:58
PiRK updated the summary of D9096: p2p: add MAX_FEELER_CONNECTIONS.
Jan 28 2021, 07:47
PiRK requested review of D9096: p2p: add MAX_FEELER_CONNECTIONS.
Jan 28 2021, 07:44
PiRK requested review of D9094: net: use CMessageHeader::HEADER_SIZE, add missing include.
Jan 28 2021, 07:37
PiRK requested review of D9093: [doc] Add a link from ZMQ doc to ZMQ example in contrib/.
Jan 28 2021, 07:31
PiRK closed D9083: [net processing] ignore tx GETDATA from blocks-only peers.
Jan 28 2021, 07:05
PiRK committed rABCd2d68c3f859c: [net processing] ignore tx GETDATA from blocks-only peers (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[net processing] ignore tx GETDATA from blocks-only peers
Jan 28 2021, 07:04
PiRK accepted D9092: [backport#18726] test: check misbehavior more independently in p2p_filter.py.
Jan 28 2021, 07:01
PiRK closed D9082: refactor: Apply override specifier consistently.
Jan 28 2021, 06:59
PiRK committed rABC4770199b7a78: refactor: Apply override specifier consistently (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: Apply override specifier consistently
Jan 28 2021, 06:59
PiRK closed D9081: wallet: Fix typo in assert that is compile-time true.
Jan 28 2021, 06:51
PiRK committed rABC9059575a8883: wallet: Fix typo in assert that is compile-time true (authored by MarcoFalke <falke.marco@gmail.com>).
wallet: Fix typo in assert that is compile-time true
Jan 28 2021, 06:51

Jan 27 2021

PiRK closed D9078: Get rid of BindWallet.
Jan 27 2021, 17:17
PiRK committed rABC846f417721ee: Get rid of BindWallet (authored by Russell Yanofsky <russ@yanofsky.org>).
Get rid of BindWallet
Jan 27 2021, 17:17
PiRK closed D9080: doc: Fix typo in Coin doxygen comment.
Jan 27 2021, 17:11
PiRK committed rABCec367a2fad96: doc: Fix typo in Coin doxygen comment (authored by MarcoFalke <falke.marco@gmail.com>).
doc: Fix typo in Coin doxygen comment
Jan 27 2021, 17:11
PiRK updated the summary of D9084: [net processing] ignore unknown INV types in GETDATA messages.
Jan 27 2021, 17:03
PiRK updated the summary of D9085: [test] test that an invalid GETDATA doesn't prevent processing of future messages.
Jan 27 2021, 17:03
PiRK updated the summary of D9086: [docs] Improve commenting in ProcessGetData().
Jan 27 2021, 17:02
PiRK requested review of D9086: [docs] Improve commenting in ProcessGetData().
Jan 27 2021, 17:01
PiRK requested review of D9085: [test] test that an invalid GETDATA doesn't prevent processing of future messages.
Jan 27 2021, 16:59
PiRK requested review of D9084: [net processing] ignore unknown INV types in GETDATA messages.
Jan 27 2021, 16:58
PiRK requested review of D9083: [net processing] ignore tx GETDATA from blocks-only peers.
Jan 27 2021, 16:58
PiRK closed D9077: Disable CWalletTx copy constructor.
Jan 27 2021, 16:42
PiRK committed rABC19dfc4927677: Disable CWalletTx copy constructor (authored by Russell Yanofsky <russ@yanofsky.org>).
Disable CWalletTx copy constructor
Jan 27 2021, 16:42
PiRK planned changes to D9079: walletdb: Remove unused static functions from walletdb.h.

This commit is only a single one in a 3 PR commit. One of the other commits has dependencies that have not yet been backported. I will finish this later when I can cherry pick all 3 commits.

Jan 27 2021, 16:33
PiRK closed D9076: Avoid copying CWalletTx in LoadToWallet.
Jan 27 2021, 16:12
PiRK committed rABC6bde49b66858: Avoid copying CWalletTx in LoadToWallet (authored by Russell Yanofsky <russ@yanofsky.org>).
Avoid copying CWalletTx in LoadToWallet
Jan 27 2021, 16:12
PiRK closed D9073: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction.
Jan 27 2021, 16:00
PiRK committed rABCb740449f358f: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are… (authored by practicalswift <practicalswift@users.noreply.github.com>).
wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are…
Jan 27 2021, 16:00
PiRK closed D9075: Get rid of unneeded CWalletTx::Init parameter.
Jan 27 2021, 15:54
PiRK committed rABC2e0a03b7372a: Get rid of unneeded CWalletTx::Init parameter (authored by Russell Yanofsky <russ@yanofsky.org>).
Get rid of unneeded CWalletTx::Init parameter
Jan 27 2021, 15:54
PiRK closed D9074: Remove CWalletTx merging logic from AddToWallet.
Jan 27 2021, 15:54
PiRK committed rABC66ddfb30ed47: Remove CWalletTx merging logic from AddToWallet (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove CWalletTx merging logic from AddToWallet
Jan 27 2021, 15:54
PiRK updated the diff for D9077: Disable CWalletTx copy constructor.

remove spurious blank line

Jan 27 2021, 15:49
PiRK requested review of D9082: refactor: Apply override specifier consistently.
Jan 27 2021, 13:51
PiRK updated the summary of D9081: wallet: Fix typo in assert that is compile-time true.
Jan 27 2021, 11:10
PiRK requested review of D9081: wallet: Fix typo in assert that is compile-time true.
Jan 27 2021, 11:08
PiRK requested review of D9080: doc: Fix typo in Coin doxygen comment.
Jan 27 2021, 10:39
PiRK requested review of D9079: walletdb: Remove unused static functions from walletdb.h.
Jan 27 2021, 10:28
PiRK updated the summary of D9075: Get rid of unneeded CWalletTx::Init parameter.
Jan 27 2021, 10:18
PiRK requested review of D9078: Get rid of BindWallet.
Jan 27 2021, 10:17
PiRK requested review of D9077: Disable CWalletTx copy constructor.
Jan 27 2021, 10:16
PiRK requested review of D9076: Avoid copying CWalletTx in LoadToWallet.
Jan 27 2021, 10:15
PiRK requested review of D9075: Get rid of unneeded CWalletTx::Init parameter.
Jan 27 2021, 10:08
PiRK requested review of D9074: Remove CWalletTx merging logic from AddToWallet.
Jan 27 2021, 10:06
PiRK requested review of D9073: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction.
Jan 27 2021, 08:30
PiRK closed D9072: init: Remove boost from ThreadImport.
Jan 27 2021, 08:07
PiRK committed rABC521692129ee2: init: Remove boost from ThreadImport (authored by MarcoFalke <falke.marco@gmail.com>).
init: Remove boost from ThreadImport
Jan 27 2021, 08:07
PiRK closed D9071: Remove CCoinsViewCache::GetValueIn(...).
Jan 27 2021, 07:50
PiRK committed rABC96fc9f405ddf: Remove CCoinsViewCache::GetValueIn(...) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove CCoinsViewCache::GetValueIn(...)
Jan 27 2021, 07:50
PiRK closed D9069: test: Fix p2p_leak intermittent issue.
Jan 27 2021, 07:43
PiRK committed rABC635ba981570b: test: Fix p2p_leak intermittent issue (authored by MarcoFalke <falke.marco@gmail.com>).
test: Fix p2p_leak intermittent issue
Jan 27 2021, 07:42

Jan 26 2021

PiRK updated the test plan for D9072: init: Remove boost from ThreadImport.
Jan 26 2021, 19:48
PiRK updated the diff for D9072: init: Remove boost from ThreadImport.

fix LoadExternalBlockFile return type in validation.cpp

Jan 26 2021, 19:43
PiRK requested review of D9072: init: Remove boost from ThreadImport.
Jan 26 2021, 19:41
PiRK closed D9070: gui: Add close window shortcut.
Jan 26 2021, 19:36
PiRK committed rABC1e8c9d876052: gui: Add close window shortcut (authored by Miguel Herranz <miguel@ipglider.org>).
gui: Add close window shortcut
Jan 26 2021, 19:36
PiRK closed D9068: test: use unittest and test_runner for test framework unit testing.
Jan 26 2021, 19:25
PiRK committed rABC4e33fac0c9de: test: use unittest and test_runner for test framework unit testing (authored by Gloria Zhao <gzhao408@berkeley.edu>).
test: use unittest and test_runner for test framework unit testing
Jan 26 2021, 19:25
PiRK requested review of D9071: Remove CCoinsViewCache::GetValueIn(...).
Jan 26 2021, 19:21
PiRK closed D9067: rpc: Do not advertise dumptxoutset as a way to flush the chainstate.
Jan 26 2021, 19:19
PiRK committed rABC7239f66265e1: rpc: Do not advertise dumptxoutset as a way to flush the chainstate (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Do not advertise dumptxoutset as a way to flush the chainstate
Jan 26 2021, 19:19
PiRK closed D9065: test: fix message for ECC_InitSanityCheck test.
Jan 26 2021, 19:14
PiRK committed rABC5c9f38fd2d2c: test: fix message for ECC_InitSanityCheck test (authored by fanquake <fanquake@gmail.com>).
test: fix message for ECC_InitSanityCheck test
Jan 26 2021, 19:14
PiRK closed D9064: fix: update rest info on block size and json.
Jan 26 2021, 19:06
PiRK committed rABCf4ccadb3d3a6: fix: update rest info on block size and json (authored by Chris Abrams <mail@chrisabrams.com>).
fix: update rest info on block size and json
Jan 26 2021, 19:06
PiRK requested review of D9070: gui: Add close window shortcut.
Jan 26 2021, 18:20
PiRK requested review of D9069: test: Fix p2p_leak intermittent issue.
Jan 26 2021, 18:04
PiRK updated the summary of D9068: test: use unittest and test_runner for test framework unit testing.
Jan 26 2021, 17:54
PiRK updated the summary of D9067: rpc: Do not advertise dumptxoutset as a way to flush the chainstate.
Jan 26 2021, 17:52
PiRK updated the summary of D9065: test: fix message for ECC_InitSanityCheck test.
Jan 26 2021, 17:52
PiRK updated the summary of D9064: fix: update rest info on block size and json.
Jan 26 2021, 17:51
PiRK requested review of D9068: test: use unittest and test_runner for test framework unit testing.
Jan 26 2021, 17:51
PiRK closed D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 26 2021, 17:44
PiRK committed rABCbd45ab5e8e22: test: add wait_for_cookie_credentials() to framework for rpcwait tests (authored by Jon Atack <jon@atack.com>).
test: add wait_for_cookie_credentials() to framework for rpcwait tests
Jan 26 2021, 17:44
PiRK accepted D9066: [backport#18727] test: Add CreateWalletFromFile test.
Jan 26 2021, 17:28
PiRK requested review of D9067: rpc: Do not advertise dumptxoutset as a way to flush the chainstate.
Jan 26 2021, 17:12
PiRK requested review of D9065: test: fix message for ECC_InitSanityCheck test.
Jan 26 2021, 17:08
PiRK requested review of D9064: fix: update rest info on block size and json.
Jan 26 2021, 17:03
PiRK accepted D9063: tests: Add fuzzing harness for CCoinsViewCache.
Jan 26 2021, 15:28
PiRK accepted D9061: tests: Fill fuzzing coverage gaps for functions in primitives/block.h.
Jan 26 2021, 12:31
PiRK accepted D9060: fuzz: use std::optional for sep_pos variable.
Jan 26 2021, 12:27
PiRK accepted D9059: fuzz: fix vector size problem in system fuzzer.
Jan 26 2021, 12:25
PiRK requested changes to D9057: [backport#18691] test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 26 2021, 07:32
PiRK added a comment to D9057: [backport#18691] test: add wait_for_cookie_credentials() to framework for rpcwait tests.

We can take yours, it has additional code style improvements. I chose not to change the quotes to single quotes in my backport, which lead the linter not to fix those lines.
I would just put the comments on their own lines in the new function in test_node.py

Jan 26 2021, 07:29
PiRK added a comment to D9057: [backport#18691] test: add wait_for_cookie_credentials() to framework for rpcwait tests.

D8947

Jan 26 2021, 07:20

Jan 25 2021

PiRK closed D9042: test: Add mempool_updatefromblock.py.
Jan 25 2021, 17:28
PiRK committed rABC4a29fe3f7a60: test: Add mempool_updatefromblock.py (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
test: Add mempool_updatefromblock.py
Jan 25 2021, 17:28
PiRK updated the diff for D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.

rebase

Jan 25 2021, 17:13
PiRK accepted D9055: Improve asmap checks and add sanity check.
Jan 25 2021, 16:57
PiRK updated the diff for D8899: Check for overflow when calculating sum of outputs.

add tests for the case of a sum of outputs equal to MAX_MONEY, which is a valid case.

Jan 25 2021, 16:43
PiRK updated the diff for D9042: test: Add mempool_updatefromblock.py.

adjust the batch size from 25 to 50, to account for ABC's DEFAULT_ANCESTOR_LIMIT.

Jan 25 2021, 14:53
PiRK accepted D9052: [Cashtab] Match app send min to backend send min with constant.
Jan 25 2021, 13:40