Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Sep 3 2019

teamcity added a comment to D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 3 2019, 19:52
teamcity added a comment to D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 3 2019, 19:51
nakihito updated the diff for D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.

Rebased and added missing EXCLUSIVE_LOCKS_REQUIRED() to validation.cpp

Sep 3 2019, 19:51
teamcity added a comment to D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 3 2019, 19:47
nakihito updated the diff for D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Added an instance of EXCLUSIVE_LOCKS_REQUIRED() to wallet/wallet.cpp.

Sep 3 2019, 19:47
teamcity added a comment to D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 3 2019, 19:24
teamcity added a comment to D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 3 2019, 19:16
nakihito updated the diff for D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Rebased.

Sep 3 2019, 19:16
nakihito updated the test plan for D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
Sep 3 2019, 19:10
nakihito updated the test plan for D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.
Sep 3 2019, 19:06
nakihito requested review of D3980: Merge #13077: Add compile time checking for all cs_KeyStore runtime locking assertions.

Fixed test method.

Sep 3 2019, 19:06
nakihito updated the test plan for D3980: Merge #13077: Add compile time checking for all cs_KeyStore runtime locking assertions.
Sep 3 2019, 19:06
fpelliccioni abandoned D3989: Add test for GCC bug 90348.

Sorry, I'm trying some scripts to be able to build several backports at once and I sent this Diff unintentionally.

Sep 3 2019, 19:02
fpelliccioni abandoned D3988: Add Benchmark to test input de-duplication worst case.

Sorry, I'm trying some scripts to be able to build several backports at once and I sent this Diff unintentionally.

Sep 3 2019, 18:48
Harbormaster failed remote builds in B7308: Diff 11072 for D3989: Add test for GCC bug 90348!
Sep 3 2019, 18:41
teamcity added a comment to D3989: Add test for GCC bug 90348.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Sep 3 2019, 18:41
teamcity added a comment to D3989: Add test for GCC bug 90348.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 3 2019, 18:40
fpelliccioni created D3989: Add test for GCC bug 90348.
Sep 3 2019, 18:40
teamcity added a comment to D3987: wallet: Catch filesystem_error and raise InitError.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 3 2019, 18:34
Harbormaster failed remote builds in B7307: Diff 11071 for D3988: Add Benchmark to test input de-duplication worst case!
Sep 3 2019, 18:32
teamcity added a comment to D3988: Add Benchmark to test input de-duplication worst case.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Sep 3 2019, 18:32
teamcity added a comment to D3988: Add Benchmark to test input de-duplication worst case.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 3 2019, 18:30
fpelliccioni created D3988: Add Benchmark to test input de-duplication worst case.
Sep 3 2019, 18:30
teamcity added a comment to D3986: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 3 2019, 18:26
teamcity added a comment to D3987: wallet: Catch filesystem_error and raise InitError.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 3 2019, 18:26
fpelliccioni created D3987: wallet: Catch filesystem_error and raise InitError.
Sep 3 2019, 18:25
teamcity added a comment to D3986: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 3 2019, 18:19
fpelliccioni created D3986: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after.
Sep 3 2019, 18:19
Nico Guiton <nico@bitframe.org> committed rABC3bdbe4821611: Merge #13159: Don't close old debug log file handle prematurely when trying to… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13159: Don't close old debug log file handle prematurely when trying to…
Sep 3 2019, 17:49
Nico Guiton <nico@bitframe.org> closed D3979: Merge #13159: Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP).
Sep 3 2019, 17:49
Nico Guiton <nico@bitframe.org> committed rABC1d91c62d1401: Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...) (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...)
Sep 3 2019, 17:34
Nico Guiton <nico@bitframe.org> closed D3976: Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...).
Sep 3 2019, 17:34
teamcity added a comment to D3985: Add missing override keyword to DummySignatureCreator::CreateSig().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 3 2019, 13:58
deadalnix accepted D3985: Add missing override keyword to DummySignatureCreator::CreateSig().
Sep 3 2019, 13:57
teamcity added a comment to D3985: Add missing override keyword to DummySignatureCreator::CreateSig().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 3 2019, 13:48
Fabien created D3985: Add missing override keyword to DummySignatureCreator::CreateSig().
Sep 3 2019, 13:48
fpelliccioni abandoned D3983: Add linter: Enforce the source code file naming convention described in the developer notes.
Sep 3 2019, 12:58
teamcity added a comment to D3984: [LINTER] Enforce using C++ style for void parameters.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 3 2019, 10:39
teamcity added a comment to D3984: [LINTER] Enforce using C++ style for void parameters.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 3 2019, 10:29
Fabien created D3984: [LINTER] Enforce using C++ style for void parameters.
Sep 3 2019, 10:28
Fabien added a comment to D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.

See D3980

Sep 3 2019, 08:25
Fabien requested changes to D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

See D3980

Sep 3 2019, 08:24
Fabien requested changes to D3980: Merge #13077: Add compile time checking for all cs_KeyStore runtime locking assertions.

The test plan is incorrect. --enable-debug is aimed to detect races at runtime from the LOCK(), AssertLockHeld(), ... macros.
EXCLUSIVE_LOCKS_REQUIRED() and alike are compile-time directives used by Clang (only) when the -Wthread-safety-analysis compile flag is set.

Sep 3 2019, 08:17
Fabien accepted D3979: Merge #13159: Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP).
Sep 3 2019, 07:58
Fabien requested changes to D3983: Add linter: Enforce the source code file naming convention described in the developer notes.

I'm afraid this is a duplicate of D3593.
My bad, I missed there was a backport.

Sep 3 2019, 07:46
teamcity added a comment to D3983: Add linter: Enforce the source code file naming convention described in the developer notes.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 3 2019, 02:56
teamcity added a comment to D3983: Add linter: Enforce the source code file naming convention described in the developer notes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 3 2019, 02:45
fpelliccioni created D3983: Add linter: Enforce the source code file naming convention described in the developer notes.
Sep 3 2019, 02:45

Sep 2 2019

fpelliccioni committed rABC1bf9852e2c50: Default to defining endian-conversion DECLs in compat w/o config (authored by Matt Corallo <git@bluematt.me>).
Default to defining endian-conversion DECLs in compat w/o config
Sep 2 2019, 17:46
fpelliccioni closed D3966: Default to defining endian-conversion DECLs in compat w/o config.
Sep 2 2019, 17:46
fpelliccioni committed rABC51fbdf464a64: Consistently log CValidationState on failure (authored by Ben Woosley <ben.woosley@gmail.com>).
Consistently log CValidationState on failure
Sep 2 2019, 17:37
fpelliccioni closed D3967: Consistently log CValidationState on failure.
Sep 2 2019, 17:36
Fabien committed rABC9904779739dd: Remove deprecated features for the 0.20.x branch (authored by Fabien).
Remove deprecated features for the 0.20.x branch
Sep 2 2019, 07:48
Fabien closed D3978: Remove deprecated features for the 0.20.x branch.
Sep 2 2019, 07:48

Aug 31 2019

deadalnix accepted D3976: Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...).
Aug 31 2019, 14:37
teamcity added a comment to D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 31 2019, 00:52
teamcity added a comment to D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 31 2019, 00:48
teamcity added a comment to D3980: Merge #13077: Add compile time checking for all cs_KeyStore runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 31 2019, 00:42
teamcity added a comment to D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 31 2019, 00:39
nakihito updated the summary of D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
Aug 31 2019, 00:39
nakihito updated the summary of D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
Aug 31 2019, 00:38
teamcity added a comment to D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 31 2019, 00:38
nakihito created D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
Aug 31 2019, 00:38
teamcity added a comment to D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 31 2019, 00:37
nakihito created D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.
Aug 31 2019, 00:37
teamcity added a comment to D3980: Merge #13077: Add compile time checking for all cs_KeyStore runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 31 2019, 00:34
nakihito created D3980: Merge #13077: Add compile time checking for all cs_KeyStore runtime locking assertions.
Aug 31 2019, 00:34

Aug 30 2019

teamcity added a comment to D3979: Merge #13159: Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP).

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 30 2019, 21:06
nakihito requested review of D3976: Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...).

Fix completed by D3979.

Aug 30 2019, 20:54
nakihito updated the summary of D3979: Merge #13159: Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP).
Aug 30 2019, 20:53
teamcity added a comment to D3979: Merge #13159: Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP).

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 30 2019, 20:53
nakihito created D3979: Merge #13159: Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP).
Aug 30 2019, 20:53
Nico Guiton <nico@bitframe.org> committed rABCf3cacd50640f: Merge #12507: Interrupt rescan on shutdown request (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12507: Interrupt rescan on shutdown request
Aug 30 2019, 20:28
Nico Guiton <nico@bitframe.org> closed D3975: Merge #12507: Interrupt rescan on shutdown request.
Aug 30 2019, 20:28
teamcity added a comment to D3968: Merge #12885: Reduce implementation code inside CScript.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 30 2019, 18:59
teamcity added a comment to D3968: Merge #12885: Reduce implementation code inside CScript.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 30 2019, 18:48
nakihito updated the diff for D3968: Merge #12885: Reduce implementation code inside CScript.

Fixed variable type comparison warning.

Aug 30 2019, 18:47
teamcity added a comment to D3950: Merge #12953: Deprecate accounts.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 30 2019, 18:17
teamcity added a comment to D3950: Merge #12953: Deprecate accounts.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 30 2019, 18:10
nakihito updated the diff for D3950: Merge #12953: Deprecate accounts.

Rebased.

Aug 30 2019, 18:10
deadalnix accepted D3978: Remove deprecated features for the 0.20.x branch.
Aug 30 2019, 18:03
teamcity added a comment to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 30 2019, 18:02
teamcity added a comment to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 30 2019, 17:52
nakihito updated the diff for D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Rebased and moved label and account function blocks inline with Core's placement.

Aug 30 2019, 17:51
teamcity added a comment to D3978: Remove deprecated features for the 0.20.x branch.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 30 2019, 16:45
deadalnix changed the visibility for D3865: recognize bare multisigs as standard only when using minimal pushes.
Aug 30 2019, 16:37
teamcity added a comment to D3978: Remove deprecated features for the 0.20.x branch.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 30 2019, 16:33
Fabien created D3978: Remove deprecated features for the 0.20.x branch.
Aug 30 2019, 16:33
Mengerian added a revision to T653: Clean up past upgrades: D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag.
Aug 30 2019, 15:30
Mengerian added a task to D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag: T653: Clean up past upgrades.
Aug 30 2019, 15:30
deadalnix accepted D3732: Added a script to generate chainparams intermediate files.
Aug 30 2019, 14:06
deadalnix accepted D3975: Merge #12507: Interrupt rescan on shutdown request.
Aug 30 2019, 13:56
deadalnix requested changes to D3968: Merge #12885: Reduce implementation code inside CScript.

You got that wrong. The compiler is warning about it. You need to fix this.

Aug 30 2019, 13:54
Fabien committed rABCca85e129eea9: Make sure LC_ALL=C is set in all shell scripts (authored by practicalswift <practicalswift@users.noreply.github.com>).
Make sure LC_ALL=C is set in all shell scripts
Aug 30 2019, 13:50
Fabien closed D3964: Make sure LC_ALL=C is set in all shell scripts.
Aug 30 2019, 13:49
teamcity added a comment to D3964: Make sure LC_ALL=C is set in all shell scripts.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 30 2019, 13:45
teamcity added a comment to D3965: [net] Tighten scope in net_processing.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 30 2019, 13:39
teamcity added a comment to D3964: Make sure LC_ALL=C is set in all shell scripts.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 30 2019, 13:38
teamcity added a comment to D3964: Make sure LC_ALL=C is set in all shell scripts.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 30 2019, 13:37
Harbormaster failed remote builds in B7290: Diff 11044 for D3964: Make sure LC_ALL=C is set in all shell scripts!
Aug 30 2019, 13:36
First
Prev
Next