- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Sep 5 2019
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Code seems good to me. Awaiting for the IBD result.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Started IBD on this diff: https://build.bitcoinabc.org/viewLog.html?tab=buildLog&buildTypeId=BitcoinABC_ResourceIntensiveBuilds_BitcoinAbcIbdDiffTestingWOCheckpoints&buildId=18634
I will request for review when it ends successfully.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
The changes to rpc/misc.cpp are missing.
It's not from an outdated code, but applies to the logging RPC backport that you did (stack starting from D3464). You need to rebase this diff on top of it.
The setaccount change is missing from rpcwallet.cpp (alias for setlabel).
Sep 4 2019
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Rebased off D3998.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Nits fixed. Will rebase after D3997 is landed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Move to the build dir *AFTER* its creation...
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Remove setup.sh, now it is a function in build-configurations.sh.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
I will green this once D3950 is getting close to completion. Right now, there are some missing backports so it's difficult to estimate a timeline.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Gitian build added to the test plan and run successfully: https://build.bitcoinabc.org/viewLog.html?tab=buildLog&buildTypeId=BitcoinABC_ResourceIntensiveBuilds_NightlyBuilds_BitcoinAbcGitianDiffTesting&buildId=18612
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
set -eux is a good idea. I'm not yet convinced on set -o pipefail, though I think it's probably best to have it on by default rather than not.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Don't fix it if it ain't broken: https://github.com/bitcoin/bitcoin/pull/11044/files
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Sep 3 2019
Build Bitcoin-ABC / Diffs / Diff Testing passed.