While this is a pretty bad idea to have said config, it is an even worse idea to have a unit test depends on user config, not testing the software, yet ran as part as its test suite by default, running a buggy script.

Dec 4 2019, 23:29

deadalnix accepted D4635: Fix a bug where test-autopatch would fail in an env where no global git config is set.

As it turns out, having test that depends on the user's global config, not testing the actual software but running by default on the software test suite.

Dec 4 2019, 23:25

deadalnix accepted D4639: Merge #13566: Fix get balance.

Dec 4 2019, 23:19

teamcity added a comment to D4639: Merge #13566: Fix get balance.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 4 2019, 23:15

deadalnix requested changes to D4630: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD.

Looks like you broke the build.

Dec 4 2019, 23:13

teamcity added a comment to D4639: Merge #13566: Fix get balance.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 4 2019, 23:04

jasonbcox updated the diff for D4639: Merge #13566: Fix get balance.

Fixup multiline strings

Dec 4 2019, 23:04

nakihito committed rABC5b53e81f29d6: Integrate gArgs and chainparams into the Seeder (authored by nakihito).

Integrate gArgs and chainparams into the Seeder

Dec 4 2019, 23:02

nakihito closed D4300: Integrate gArgs and chainparams into the Seeder.

Dec 4 2019, 23:02

teamcity added a comment to D4641: [cuckoocache] Use matchKey instead of the == operator..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 4 2019, 22:56

Harbormaster failed remote builds in B8416: Diff 14629 for D4640: [Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly!

Dec 4 2019, 22:46

teamcity added a comment to D4640: [Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Dec 4 2019, 22:46

teamcity added a comment to D4641: [cuckoocache] Use matchKey instead of the == operator..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 4 2019, 22:45

teamcity added a comment to D4640: [Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 4 2019, 22:44

deadalnix created D4641: [cuckoocache] Use matchKey instead of the == operator..

Dec 4 2019, 22:39

ProtocolCash added a comment to D4640: [Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly.

In D4640#111734, @deadalnix wrote:

Please mention PR1243653 (with no # in the middle) in the description so that it can be searched for.

Dec 4 2019, 22:35

deadalnix added a comment to D4640: [Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly.

Please mention PR1243653 (with no # in the middle) in the description so that it can be searched for.

Dec 4 2019, 22:32

ProtocolCash abandoned D4640: [Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly.

Bad diff... missing commits.

Dec 4 2019, 22:31

ProtocolCash created D4640: [Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly.

Dec 4 2019, 22:27

deadalnix committed rABC5cf580f0f756: Various nits in cuckoocache_tests.cpp (authored by deadalnix).

Various nits in cuckoocache_tests.cpp

Dec 4 2019, 22:24

deadalnix closed D4632: Various nits in cuckoocache_tests.cpp.

Dec 4 2019, 22:24

deadalnix committed rABCeecfa67b2223: doc: Doxygen-friendly CuckooCache comments (authored by Jon Layton <me@jonl.io>).

doc: Doxygen-friendly CuckooCache comments

Dec 4 2019, 22:20

deadalnix closed D4631: doc: Doxygen-friendly CuckooCache comments.

Dec 4 2019, 22:20

teamcity added a comment to D4639: Merge #13566: Fix get balance.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 4 2019, 22:14

teamcity added a comment to D4639: Merge #13566: Fix get balance.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 4 2019, 22:03

jasonbcox planned changes to D4639: Merge #13566: Fix get balance.

Dec 4 2019, 22:03

jasonbcox created D4639: Merge #13566: Fix get balance.

Dec 4 2019, 22:03

teamcity added a comment to D4619: Merge #14451: Allow building GUI without BIP70 support.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 4 2019, 21:48

jasonbcox updated the summary of D4619: Merge #14451: Allow building GUI without BIP70 support.

Dec 4 2019, 21:38

jasonbcox retitled D4619: Merge #14451: Allow building GUI without BIP70 support from Merge #14451: Add BIP70 deprecation warning and allow building GUI without BIP70 support to Merge #14451: Allow building GUI without BIP70 support.

Dec 4 2019, 21:37

teamcity added a comment to D4619: Merge #14451: Allow building GUI without BIP70 support.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 4 2019, 21:36

jasonbcox updated the diff for D4619: Merge #14451: Allow building GUI without BIP70 support.

Remove BIP70 deprecation message

Dec 4 2019, 21:36

teamcity added a comment to D4638: Fix a bug where test-autopatch would fail when the local master branch does not have the same HEAD as origin/master.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 4 2019, 21:27

teamcity added a comment to D4637: Remove gotos in seeder/dns.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 4 2019, 21:23

jasonbcox requested changes to D4637: Remove gotos in seeder/dns.cpp.

Dec 4 2019, 21:22

teamcity added a comment to D4638: Fix a bug where test-autopatch would fail when the local master branch does not have the same HEAD as origin/master.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 4 2019, 21:16

jasonbcox created D4638: Fix a bug where test-autopatch would fail when the local master branch does not have the same HEAD as origin/master.

Dec 4 2019, 21:16

teamcity added a comment to D4637: Remove gotos in seeder/dns.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 4 2019, 21:12

nakihito created D4637: Remove gotos in seeder/dns.cpp.

Dec 4 2019, 21:12

jasonbcox accepted D4631: doc: Doxygen-friendly CuckooCache comments.

Dec 4 2019, 20:17

ProtocolCash added a comment to T575: Backport Core PR 14532: reduce attack surface of RPC server.

Working on this.

Dec 4 2019, 19:31 · Bootcamp, Restricted Project

teamcity added a comment to D4628: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 4 2019, 19:12

jasonbcox accepted D4632: Various nits in cuckoocache_tests.cpp.

Dec 4 2019, 19:04

teamcity added a comment to D4628: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 4 2019, 19:02

teamcity added a comment to D4635: Fix a bug where test-autopatch would fail in an env where no global git config is set.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 4 2019, 19:00

jasonbcox accepted D4633: Small fix in backporting.md - remove unneeded trailing . for git remote add command.

Dec 4 2019, 18:55

jasonbcox accepted D4634: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required.

Dec 4 2019, 18:54

teamcity added a comment to D4635: Fix a bug where test-autopatch would fail in an env where no global git config is set.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 4 2019, 18:49

jasonbcox created D4635: Fix a bug where test-autopatch would fail in an env where no global git config is set.

Dec 4 2019, 18:49

jasonbcox committed rABC051bdbed1ccb: Rename contrib/arcanist to source-control-tools (authored by jasonbcox).

Rename contrib/arcanist to source-control-tools

Dec 4 2019, 18:38

jasonbcox closed D4626: Rename contrib/arcanist to source-control-tools.

Dec 4 2019, 18:38

zquestz added a comment to D4619: Merge #14451: Allow building GUI without BIP70 support.

In D4619#111500, @deadalnix wrote:

Do not deprecate BIP70.

Dec 4 2019, 18:37

teamcity added a comment to D4634: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 4 2019, 18:35

teamcity added a comment to D4626: Rename contrib/arcanist to source-control-tools.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 4 2019, 18:26

teamcity added a comment to D4632: Various nits in cuckoocache_tests.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 4 2019, 18:26

teamcity added a comment to D4633: Small fix in backporting.md - remove unneeded trailing . for git remote add command.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 4 2019, 18:26

teamcity added a comment to D4634: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 4 2019, 18:18

ProtocolCash created D4634: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required.

Dec 4 2019, 18:18

teamcity added a comment to D4633: Small fix in backporting.md - remove unneeded trailing . for git remote add command.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 4 2019, 18:14

ProtocolCash created D4633: Small fix in backporting.md - remove unneeded trailing . for git remote add command.

Dec 4 2019, 18:14

teamcity added a comment to D4631: doc: Doxygen-friendly CuckooCache comments.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Dec 4 2019, 18:14

teamcity added a comment to D4626: Rename contrib/arcanist to source-control-tools.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 4 2019, 18:08

jasonbcox updated the diff for D4626: Rename contrib/arcanist to source-control-tools.

Fixed errant deleted test-commit.patch and added an appropriate .gitignore so it won't be missed again.
(*.patch are initially ignored by the top-level .gitignore)

Dec 4 2019, 18:08

teamcity added a comment to D4632: Various nits in cuckoocache_tests.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 4 2019, 18:07

deadalnix created D4632: Various nits in cuckoocache_tests.cpp.

Dec 4 2019, 18:07

teamcity added a comment to D4631: doc: Doxygen-friendly CuckooCache comments.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Dec 4 2019, 17:59

deadalnix created D4631: doc: Doxygen-friendly CuckooCache comments.

Dec 4 2019, 17:59

deadalnix accepted D4300: Integrate gArgs and chainparams into the Seeder.