Page MenuHomePhabricator
Feed All Stories

Jun 2 2020

Fabien updated the diff for D6315: [CI] Enable -Werror where possible.

Fix array extension

Jun 2 2020, 11:57
teamcity added a comment to D6315: [CI] Enable -Werror where possible.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Jun 2 2020, 11:51
teamcity added a comment to D6315: [CI] Enable -Werror where possible.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Jun 2 2020, 11:51
teamcity added a comment to D6315: [CI] Enable -Werror where possible.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Jun 2 2020, 11:51
Fabien planned changes to D6315: [CI] Enable -Werror where possible.
Jun 2 2020, 11:51
Fabien updated the diff for D6315: [CI] Enable -Werror where possible.

Use -Werror for all regular builds

Jun 2 2020, 11:51
Fabien retitled D6315: [CI] Enable -Werror where possible from [CI] Actually make build-werror build with -Werror to [CI] Enable -Werror where possible.
Jun 2 2020, 09:59
majcosta committed rABCe5537143445b: [backport#14802] rpc: faster getblockstats using BlockUndo data (authored by Felix Weis <mail@felixweis.com>).
[backport#14802] rpc: faster getblockstats using BlockUndo data
Jun 2 2020, 09:47
majcosta closed D6305: [backport#14802] rpc: faster getblockstats using BlockUndo data.
Jun 2 2020, 09:47
Fabien committed rABC45880ccf379c: [CI] Install Clang 10 and use it for the werror build (authored by Fabien).
[CI] Install Clang 10 and use it for the werror build
Jun 2 2020, 08:36
Fabien closed D6314: [CI] Install Clang 10 and use it for the werror build.
Jun 2 2020, 08:36
Fabien committed rABCe1a3a76d286f: Allow overriding default flags (authored by Jonas Nick <jonasd.nick@gmail.com>).
Allow overriding default flags
Jun 2 2020, 08:34
Fabien closed D6309: Allow overriding default flags.
Jun 2 2020, 08:34
Fabien committed rABCb2531ebe4c9c: [CMAKE] Rename secp256k1 test targets (authored by Fabien).
[CMAKE] Rename secp256k1 test targets
Jun 2 2020, 08:30
Fabien closed D6313: [CMAKE] Rename secp256k1 test targets.
Jun 2 2020, 08:30
Unknown Object (User) added a comment to D1013: Introduce combine_logs.py to combine log files from multiple bitcoinds..
Jun 2 2020, 05:01
nakihito committed rABC388b66620b94: Merge #13160: wallet: Unlock spent outputs (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13160: wallet: Unlock spent outputs
Jun 2 2020, 00:42
nakihito closed D6321: Merge #13160: wallet: Unlock spent outputs.
Jun 2 2020, 00:42

Jun 1 2020

deadalnix requested changes to D6283: [seeder] Request headers from new connections.

The trigger for getheaders call doesn't not make a lot of sense.

Jun 1 2020, 23:03
deadalnix accepted D6321: Merge #13160: wallet: Unlock spent outputs.
Jun 1 2020, 22:55
teamcity added a comment to D6321: Merge #13160: wallet: Unlock spent outputs.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Jun 1 2020, 22:47
nakihito committed rABC55beeca040c1: Merge #13507: RPC: Fix parameter count check for importpubkey (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13507: RPC: Fix parameter count check for importpubkey
Jun 1 2020, 22:46
nakihito closed D6318: Merge #13507: RPC: Fix parameter count check for importpubkey.
Jun 1 2020, 22:46
nakihito committed rABCecbe61b28994: Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent
Jun 1 2020, 22:42
nakihito closed D6319: Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent.
Jun 1 2020, 22:42
nakihito committed rABC037e7d71bfa7: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost…
Jun 1 2020, 22:41
nakihito closed D6320: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency..
Jun 1 2020, 22:40
teamcity added a comment to D6321: Merge #13160: wallet: Unlock spent outputs.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Jun 1 2020, 22:40
teamcity added a comment to D6321: Merge #13160: wallet: Unlock spent outputs.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Jun 1 2020, 22:38
teamcity added a comment to D6321: Merge #13160: wallet: Unlock spent outputs.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Jun 1 2020, 22:37
teamcity added a comment to D6321: Merge #13160: wallet: Unlock spent outputs.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Jun 1 2020, 22:37
teamcity added a comment to D6321: Merge #13160: wallet: Unlock spent outputs.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Jun 1 2020, 22:37
teamcity updated the summary of D6321: Merge #13160: wallet: Unlock spent outputs.
Jun 1 2020, 22:37
teamcity added a comment to D6321: Merge #13160: wallet: Unlock spent outputs.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 1 2020, 22:37
nakihito requested review of D6321: Merge #13160: wallet: Unlock spent outputs.
Jun 1 2020, 22:37
deadalnix accepted D6314: [CI] Install Clang 10 and use it for the werror build.

The same comment applies more or less. If we are using clang 10 then we are using clang 10. The existence of a specific werror build is dubbious.

Jun 1 2020, 22:34
deadalnix accepted D6318: Merge #13507: RPC: Fix parameter count check for importpubkey.
Jun 1 2020, 22:19
deadalnix accepted D6319: Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent.
Jun 1 2020, 22:17
deadalnix updated the summary of D6319: Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent.
Jun 1 2020, 22:17
deadalnix accepted D6320: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency..
Jun 1 2020, 22:16
teamcity added a comment to D6320: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency..

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Jun 1 2020, 22:15
nakihito closed D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.
Jun 1 2020, 22:10
nakihito committed rABC2286545cb467: Merge #13116: Add Clang thread safety annotations for variables guarded by… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13116: Add Clang thread safety annotations for variables guarded by…
Jun 1 2020, 22:10
teamcity added a comment to D6320: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency..

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Jun 1 2020, 22:10
teamcity added a comment to D6320: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency..

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Jun 1 2020, 22:08
teamcity added a comment to D6320: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency..

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Jun 1 2020, 22:07
teamcity added a comment to D6320: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency..

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Jun 1 2020, 22:07
teamcity added a comment to D6320: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency..

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Jun 1 2020, 22:07
teamcity added a comment to D6320: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency..

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 1 2020, 22:07
teamcity updated the summary of D6320: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency..
Jun 1 2020, 22:07
nakihito requested review of D6320: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency..
Jun 1 2020, 22:07
teamcity added a comment to D6319: Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Jun 1 2020, 22:03
deadalnix accepted D6305: [backport#14802] rpc: faster getblockstats using BlockUndo data.
Jun 1 2020, 22:00
deadalnix accepted D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.
Jun 1 2020, 21:59
deadalnix accepted D6309: Allow overriding default flags.
Jun 1 2020, 21:58
teamcity added a comment to D6319: Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Jun 1 2020, 21:57
teamcity added a comment to D6319: Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Jun 1 2020, 21:55
teamcity added a comment to D6319: Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Jun 1 2020, 21:54
teamcity added a comment to D6319: Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Jun 1 2020, 21:54
teamcity added a comment to D6319: Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Jun 1 2020, 21:54
nakihito requested review of D6319: Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent.
Jun 1 2020, 21:53
nakihito requested review of D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.
Jun 1 2020, 21:51
teamcity added a comment to D6318: Merge #13507: RPC: Fix parameter count check for importpubkey.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Jun 1 2020, 21:40
teamcity added a comment to D6318: Merge #13507: RPC: Fix parameter count check for importpubkey.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Jun 1 2020, 21:34
teamcity added a comment to D6318: Merge #13507: RPC: Fix parameter count check for importpubkey.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Jun 1 2020, 21:33
teamcity added a comment to D6318: Merge #13507: RPC: Fix parameter count check for importpubkey.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Jun 1 2020, 21:32
teamcity added a comment to D6318: Merge #13507: RPC: Fix parameter count check for importpubkey.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Jun 1 2020, 21:32
teamcity added a comment to D6318: Merge #13507: RPC: Fix parameter count check for importpubkey.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Jun 1 2020, 21:31
teamcity added a comment to D6318: Merge #13507: RPC: Fix parameter count check for importpubkey.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 1 2020, 21:31
teamcity updated the summary of D6318: Merge #13507: RPC: Fix parameter count check for importpubkey.
Jun 1 2020, 21:31
nakihito requested review of D6318: Merge #13507: RPC: Fix parameter count check for importpubkey.
Jun 1 2020, 21:31
teamcity added a comment to D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Jun 1 2020, 21:09
teamcity added a comment to D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Jun 1 2020, 21:03
teamcity added a comment to D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Jun 1 2020, 21:01
teamcity added a comment to D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Jun 1 2020, 21:00
teamcity added a comment to D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Jun 1 2020, 21:00
teamcity added a comment to D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Jun 1 2020, 21:00
teamcity added a comment to D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 1 2020, 20:59
teamcity updated the summary of D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.
Jun 1 2020, 20:59
nakihito planned changes to D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.
Jun 1 2020, 20:59
nakihito requested review of D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.
Jun 1 2020, 20:59
Fabien planned changes to D6315: [CI] Enable -Werror where possible.
Jun 1 2020, 20:35
Fabien requested review of D6314: [CI] Install Clang 10 and use it for the werror build.

@deadalnix OK but I think you comment applies to D6315. -Werror can be set for regular builds, and we can turn the current build-werror into a clang 10 build to prevent introducing warnings from the latest versions. I will update D6315 to reflect that.

Jun 1 2020, 20:35
teamcity added a comment to D6264: Add arcanist land bot workflow.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Jun 1 2020, 17:52
teamcity added a comment to D6264: Add arcanist land bot workflow.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Jun 1 2020, 17:49
teamcity added a comment to D6283: [seeder] Request headers from new connections.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Jun 1 2020, 17:47
teamcity added a comment to D6264: Add arcanist land bot workflow.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Jun 1 2020, 17:46
nakihito committed rABC9e6bebaac242: Merge #16481: Trivial: add missing space (authored by fanquake <fanquake@gmail.com>).
Merge #16481: Trivial: add missing space
Jun 1 2020, 17:46
nakihito closed D6316: Merge #16481: Trivial: add missing space.
Jun 1 2020, 17:46
teamcity added a comment to D6283: [seeder] Request headers from new connections.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Jun 1 2020, 17:40
teamcity added a comment to D6283: [seeder] Request headers from new connections.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Jun 1 2020, 17:38
jasonbcox accepted D6316: Merge #16481: Trivial: add missing space.
Jun 1 2020, 17:37
teamcity added a comment to D6264: Add arcanist land bot workflow.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Jun 1 2020, 17:37
teamcity added a comment to D6264: Add arcanist land bot workflow.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Jun 1 2020, 17:37
teamcity added a comment to D6283: [seeder] Request headers from new connections.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Jun 1 2020, 17:37
teamcity added a comment to D6264: Add arcanist land bot workflow.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Jun 1 2020, 17:37
teamcity added a comment to D6283: [seeder] Request headers from new connections.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Jun 1 2020, 17:37
teamcity added a comment to D6283: [seeder] Request headers from new connections.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Jun 1 2020, 17:37
jasonbcox updated the diff for D6264: Add arcanist land bot workflow.
  • Check that gpg is installed
  • Unset unencrypted Conduit token after use
Jun 1 2020, 17:36
nakihito updated the diff for D6283: [seeder] Request headers from new connections.

Added function.

Jun 1 2020, 17:36