Let's go with the stub then. It's indeed a non issue for now.

add braces, mention PR number for backport in the description, put a few comments on their own line to improve the scriptSig layout

Address comments

this is PR17720 right? missing in the summary

I still don't get why the version is jumping from 1 to 4 ?

Rebase

Remove test fix, out of scope for this diff

Please fix the test in another diff if this is unrelated. This makes the review easier, causes the fix to get landed faster, and we will not introduce the bug again should we revert this diff for any reason.

I noticed the problem and pushed a fix before the first round of builds were finished, so the build failure just above are no longer relevant. You can see that all the latest builds are actually successful.

Fix mocks for test. This does not have anything to do with this diff...not sure what change caused this. Mock
return values duplicated same output field as 'satoshis' and 'value'

add missing parenthesis

tests are failing

Undoing extension overwrite of src files

Looks like npm extension has not replaced the original web files, patching

Abandoned after squashing with D8867

squash D8867 and D8868

In D8867#203607, @PiRK wrote:

I think the clang warning that is treated as an error goes away with the following commit (D8868). Can I just make sure I land them in rapid succession, or do I need to squash them?

I think the clang warning that is treated as an error goes away with the following commit (D8868). Can I just make sure I land them in rapid succession, or do I need to squash them?

@bot build-clang

remove extra blank line added by mistake