Page MenuHomePhabricator
Feed All Stories

Jan 13 2021

Fabien accepted D8895: test: listsinceblock block height checks.
Jan 13 2021, 11:11
PiRK added inline comments to D8892: RPC: Remove final comma for last entry of fixed-size Arrays and Objects in RPCResult.
Jan 13 2021, 11:08
Fabien requested changes to D8894: Update -blocksonly documentation.

Please also backport and squash in https://github.com/bitcoin/bitcoin/pull/18464 which is a fix for this PR.

Jan 13 2021, 11:08
Fabien accepted D8893: rpc: remove unused getbalances() code.
Jan 13 2021, 10:59
Fabien requested changes to D8892: RPC: Remove final comma for last entry of fixed-size Arrays and Objects in RPCResult.
Jan 13 2021, 10:58
teamcity updated the summary of D8897: test: check that peer is connected when calling sync_*.
Jan 13 2021, 10:57
PiRK requested review of D8897: test: check that peer is connected when calling sync_*.
Jan 13 2021, 10:57
teamcity awarded D8891: util: Replace i64tostr with ToString a Haypence token.
Jan 13 2021, 10:53
Fabien added a comment to D8891: util: Replace i64tostr with ToString.

@bot build-fuzzer

Jan 13 2021, 10:53
teamcity awarded D8890: util: Remove unused itostr and replace i64tostr with ToString a Haypence token.
Jan 13 2021, 10:51
Fabien added a comment to D8890: util: Remove unused itostr and replace i64tostr with ToString.

@bot build-fuzzer

Jan 13 2021, 10:51
Fabien accepted D8889: test: add coverage for script parse error in ParseScript.
Jan 13 2021, 10:48
PiRK updated the summary of D8896: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged.
Jan 13 2021, 10:42
teamcity updated the summary of D8896: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged.
Jan 13 2021, 10:38
PiRK requested review of D8896: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged.
Jan 13 2021, 10:38
teamcity added a comment to D8895: test: listsinceblock block height checks.
Jan 13 2021, 10:13
teamcity updated the summary of D8895: test: listsinceblock block height checks.
Jan 13 2021, 10:07
PiRK requested review of D8895: test: listsinceblock block height checks.
Jan 13 2021, 10:07
teamcity updated the summary of D8894: Update -blocksonly documentation.
Jan 13 2021, 09:50
PiRK requested review of D8894: Update -blocksonly documentation.
Jan 13 2021, 09:50
teamcity updated the summary of D8893: rpc: remove unused getbalances() code.
Jan 13 2021, 09:38
PiRK requested review of D8893: rpc: remove unused getbalances() code.
Jan 13 2021, 09:38
teamcity updated the summary of D8892: RPC: Remove final comma for last entry of fixed-size Arrays and Objects in RPCResult.
Jan 13 2021, 09:31
PiRK requested review of D8892: RPC: Remove final comma for last entry of fixed-size Arrays and Objects in RPCResult.
Jan 13 2021, 09:31
teamcity updated the summary of D8891: util: Replace i64tostr with ToString.
Jan 13 2021, 09:02
PiRK requested review of D8891: util: Replace i64tostr with ToString.
Jan 13 2021, 09:02
teamcity updated the summary of D8890: util: Remove unused itostr and replace i64tostr with ToString.
Jan 13 2021, 09:00
PiRK requested review of D8890: util: Remove unused itostr and replace i64tostr with ToString.
Jan 13 2021, 09:00
teamcity updated the summary of D8889: test: add coverage for script parse error in ParseScript.
Jan 13 2021, 08:31
PiRK requested review of D8889: test: add coverage for script parse error in ParseScript.
Jan 13 2021, 08:31
PiRK closed D8884: rpc: fix broken RPCExamples for waitforblock(height).
Jan 13 2021, 07:48
PiRK committed rABC466d6dbef804: rpc: fix broken RPCExamples for waitforblock(height) (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
rpc: fix broken RPCExamples for waitforblock(height)
Jan 13 2021, 07:48
Mengerian updated the diff for D8888: Change Bitcoin Cash references to BCHA in README.

Remove the word "experimental"

Jan 13 2021, 04:34
Mengerian closed D8886: Update copyright year to 2021.
Jan 13 2021, 04:30
Mengerian committed rABCdff41f52ccad: Update copyright year to 2021 (authored by Mengerian).
Update copyright year to 2021
Jan 13 2021, 04:30

Jan 12 2021

deadalnix accepted D8886: Update copyright year to 2021.
Jan 12 2021, 23:12
bytesofman requested changes to D8888: Change Bitcoin Cash references to BCHA in README.
Jan 12 2021, 23:12
Mengerian added a comment to D8888: Change Bitcoin Cash references to BCHA in README.

You can see what it looks like here: https://github.com/Mengerian/bitcoin-abc/tree/readme-update

Jan 12 2021, 22:36
Mengerian requested review of D8888: Change Bitcoin Cash references to BCHA in README.
Jan 12 2021, 22:31
Mengerian closed D8887: [website] Update Copyright year to 2021.
Jan 12 2021, 22:23
Mengerian committed rABCWEB9622eeaaec37: [website] Update Copyright year to 2021 (authored by Mengerian).
[website] Update Copyright year to 2021
Jan 12 2021, 22:23
bytesofman accepted D8887: [website] Update Copyright year to 2021.

Looks good, change works desktop + mobile

Jan 12 2021, 21:49
Mengerian requested review of D8887: [website] Update Copyright year to 2021.
Jan 12 2021, 21:18
Mengerian requested review of D8886: Update copyright year to 2021.
Jan 12 2021, 20:43
majcosta accepted D8884: rpc: fix broken RPCExamples for waitforblock(height).
Jan 12 2021, 18:31
bytesofman requested review of D8885: [Cashtab] Prepare for migration to psf bch-api with new utxo key.
Jan 12 2021, 16:31
PiRK closed D8883: Limit decimal range of numbers ParseScript accepts.
Jan 12 2021, 16:23
PiRK committed rABCa8bad1d2bd26: Limit decimal range of numbers ParseScript accepts (authored by pierrenn <git@pnn.sh>).
Limit decimal range of numbers ParseScript accepts
Jan 12 2021, 16:23
teamcity updated the summary of D8884: rpc: fix broken RPCExamples for waitforblock(height).
Jan 12 2021, 16:09
PiRK requested review of D8884: rpc: fix broken RPCExamples for waitforblock(height).
Jan 12 2021, 16:09
PiRK closed D8878: Replace std::to_string with locale-independent alternative.
Jan 12 2021, 16:06
PiRK committed rABC47a5b8aad9e2: Replace std::to_string with locale-independent alternative (authored by Ben Woosley <ben.woosley@gmail.com>).
Replace std::to_string with locale-independent alternative
Jan 12 2021, 16:06
PiRK closed D8882: util: Fail to parse space-only strings in ParseMoney(...) (instead of parsing as zero).
Jan 12 2021, 16:00
PiRK committed rABC6a46b5411203: util: Fail to parse space-only strings in ParseMoney(...) (instead of parsing… (authored by practicalswift <practicalswift@users.noreply.github.com>).
util: Fail to parse space-only strings in ParseMoney(...) (instead of parsing…
Jan 12 2021, 15:59
deadalnix accepted D8883: Limit decimal range of numbers ParseScript accepts.
Jan 12 2021, 15:54
teamcity updated the summary of D8883: Limit decimal range of numbers ParseScript accepts.
Jan 12 2021, 15:50
PiRK requested review of D8883: Limit decimal range of numbers ParseScript accepts.
Jan 12 2021, 15:50
Fabien accepted D8878: Replace std::to_string with locale-independent alternative.
Jan 12 2021, 15:48
deadalnix accepted D8882: util: Fail to parse space-only strings in ParseMoney(...) (instead of parsing as zero).
Jan 12 2021, 15:34
teamcity updated the summary of D8882: util: Fail to parse space-only strings in ParseMoney(...) (instead of parsing as zero).
Jan 12 2021, 15:25
PiRK requested review of D8882: util: Fail to parse space-only strings in ParseMoney(...) (instead of parsing as zero).
Jan 12 2021, 15:25
PiRK closed D8880: lockedpool: avoid sensitive data in core files (FreeBSD).
Jan 12 2021, 15:24
PiRK committed rABC72559fd6560a: lockedpool: avoid sensitive data in core files (FreeBSD) (authored by Vasil Dimov <vd@FreeBSD.org>).
lockedpool: avoid sensitive data in core files (FreeBSD)
Jan 12 2021, 15:24
majcosta accepted D8878: Replace std::to_string with locale-independent alternative.
Jan 12 2021, 15:18
Joey King <joseph.roy.king@gmail.com> closed D8870: [Cashtab] extension with new pkgs, version bump.
Jan 12 2021, 14:57
Joey King <joseph.roy.king@gmail.com> committed rABCcd5beaf5074e: [Cashtab] extension with new pkgs, version bump (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] extension with new pkgs, version bump
Jan 12 2021, 14:57
Fabien accepted D8870: [Cashtab] extension with new pkgs, version bump.
Jan 12 2021, 14:56
bytesofman requested review of D8870: [Cashtab] extension with new pkgs, version bump.
Jan 12 2021, 14:55
PiRK updated the summary of D8878: Replace std::to_string with locale-independent alternative.
Jan 12 2021, 14:53
PiRK updated the diff for D8878: Replace std::to_string with locale-independent alternative.

add std::to_string to LocaleDependenceLinter.php (this is a backport of Core PR17851), replace std::to_string in a few more source files detected by the linter and remove #include <util/string.h> from setup_common.cpp when it is already included in the header file.

Jan 12 2021, 14:51
teamcity closed T1431: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Jan 12 2021, 14:40
teamcity triaged T1431: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Jan 12 2021, 14:30
PiRK closed D8879: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps.
Jan 12 2021, 14:23
PiRK committed rABCebb8bddb6c10: lockedpool: When possible, use madvise to avoid including sensitive information… (authored by Luke Dashjr <luke-jr+git@utopios.org>).
lockedpool: When possible, use madvise to avoid including sensitive information…
Jan 12 2021, 14:23
Fabien closed D8881: test: Fix restart node race.
Jan 12 2021, 14:17
Fabien committed rABCb1a28d9a77a6: test: Fix restart node race (authored by MarcoFalke <falke.marco@gmail.com>).
test: Fix restart node race
Jan 12 2021, 14:17
PiRK closed D8872: test: add unit test for non-standard "scriptsig-not-pushonly" txs.
Jan 12 2021, 14:16
PiRK committed rABC58733a6c8be9: test: add unit test for non-standard "scriptsig-not-pushonly" txs (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: add unit test for non-standard "scriptsig-not-pushonly" txs
Jan 12 2021, 14:16
majcosta accepted D8881: test: Fix restart node race.
Jan 12 2021, 13:55
teamcity updated the summary of D8881: test: Fix restart node race.
Jan 12 2021, 13:39
Fabien requested review of D8881: test: Fix restart node race.
Jan 12 2021, 13:38
Fabien accepted D8880: lockedpool: avoid sensitive data in core files (FreeBSD).
Jan 12 2021, 12:09
Fabien accepted D8879: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps.
Jan 12 2021, 12:09
deadalnix closed D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..
Jan 12 2021, 11:35
deadalnix committed rABC42a8d3bc2caa: [avalanche] Initiate avalanche when the service bit is present and we have a… (authored by deadalnix).
[avalanche] Initiate avalanche when the service bit is present and we have a…
Jan 12 2021, 11:35
majcosta accepted D8872: test: add unit test for non-standard "scriptsig-not-pushonly" txs.
Jan 12 2021, 11:16
majcosta requested changes to D8878: Replace std::to_string with locale-independent alternative.
Jan 12 2021, 11:04
deadalnix accepted D8879: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps.
Jan 12 2021, 10:58
deadalnix accepted D8880: lockedpool: avoid sensitive data in core files (FreeBSD).
Jan 12 2021, 10:57
PiRK updated the diff for D8872: test: add unit test for non-standard "scriptsig-not-pushonly" txs.

more comments on the own line, fix comment location scriptSig

Jan 12 2021, 10:48
teamcity awarded D8879: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps a Haypence token.
Jan 12 2021, 10:46
Fabien added a comment to D8879: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps.

@bot gitian-linux gitian-osx gitian-win

Jan 12 2021, 10:46
Fabien requested changes to D8878: Replace std::to_string with locale-independent alternative.

Please also backport https://github.com/bitcoin/bitcoin/pull/17851. You can easily squash them, and that will prevent from introducing the issue again.

Jan 12 2021, 10:38
majcosta requested changes to D8872: test: add unit test for non-standard "scriptsig-not-pushonly" txs.
Jan 12 2021, 10:32
PiRK updated the summary of D8880: lockedpool: avoid sensitive data in core files (FreeBSD).
Jan 12 2021, 10:27
PiRK updated the summary of D8880: lockedpool: avoid sensitive data in core files (FreeBSD).
Jan 12 2021, 10:26
teamcity updated the summary of D8880: lockedpool: avoid sensitive data in core files (FreeBSD).
Jan 12 2021, 10:23
PiRK requested review of D8880: lockedpool: avoid sensitive data in core files (FreeBSD).
Jan 12 2021, 10:23
teamcity updated the summary of D8879: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps.
Jan 12 2021, 10:18
PiRK requested review of D8879: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps.
Jan 12 2021, 10:18