Page MenuHomePhabricator
Feed All Stories

Nov 2 2024

PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

merge imports

Nov 2 2024, 19:36
PiRK abandoned D17056: [electrum] remove outdated error message.
Nov 2 2024, 19:28
bytesofman published D17063: [Cashtab] Patch bug in manage agora offers for review.
Nov 2 2024, 14:46
bytesofman closed D17046: [new lokad] Add spec for onchain trollbox for tokens.
Nov 2 2024, 14:39
bytesofman committed rABC7a59b64e4ccc: [new lokad] Add spec for onchain trollbox for tokens (authored by bytesofman).
[new lokad] Add spec for onchain trollbox for tokens
Nov 2 2024, 14:39
tobias_ruck added inline comments to D17046: [new lokad] Add spec for onchain trollbox for tokens.
Nov 2 2024, 08:18
tobias_ruck accepted D17046: [new lokad] Add spec for onchain trollbox for tokens.
Nov 2 2024, 05:05
bytesofman closed D17053: [Cashtab] Implement typescript.
Nov 2 2024, 03:11
bytesofman committed rABCabacec78b2a7: [Cashtab] Implement typescript (authored by bytesofman).
[Cashtab] Implement typescript
Nov 2 2024, 03:11
emack accepted D17053: [Cashtab] Implement typescript.
Nov 2 2024, 00:54

Nov 1 2024

bytesofman published D17062: [token-server] Improve organization of test files for review.
Nov 1 2024, 23:28
bytesofman updated the diff for D17046: [new lokad] Add spec for onchain trollbox for tokens.

specy little-endian for tokenId push

Nov 1 2024, 23:15
bytesofman closed D16944: [ecash-agora] Add validation to _acceptTxBuilder to prevent creation of unspendable offers.
Nov 1 2024, 23:08
bytesofman committed rABCb27c743f6c10: [ecash-agora] Add validation to _acceptTxBuilder to prevent creation of… (authored by bytesofman).
[ecash-agora] Add validation to _acceptTxBuilder to prevent creation of…
Nov 1 2024, 23:08
bytesofman updated the diff for D16944: [ecash-agora] Add validation to _acceptTxBuilder to prevent creation of unspendable offers.

rebase, fix antipattern in validation (return if we have no remainder instead of only check if we do), make sure to validate if allowUnspendable is undefined, confirm with test

Nov 1 2024, 22:56
bytesofman published D17060: [ecash-herald] Implement typescript for review.
Nov 1 2024, 22:48
teamcity closed T3672: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Nov 1 2024, 22:28
roqqit closed D17058: Fix lock order inversion in promoteStakeContendersToTip.
Nov 1 2024, 22:12
roqqit committed rABC88a5faa04223: Fix lock order inversion in promoteStakeContendersToTip (authored by roqqit).
Fix lock order inversion in promoteStakeContendersToTip
Nov 1 2024, 22:12
Fabien accepted D17058: Fix lock order inversion in promoteStakeContendersToTip.
Nov 1 2024, 21:59
roqqit added a comment to D17058: Fix lock order inversion in promoteStakeContendersToTip.

https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/845463?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&hideProblemsFromDependencies=false

Nov 1 2024, 21:58
teamcity awarded D17058: Fix lock order inversion in promoteStakeContendersToTip a Haypence token.
Nov 1 2024, 21:18
Fabien added a comment to D17058: Fix lock order inversion in promoteStakeContendersToTip.

@bot build-tsan

Nov 1 2024, 21:18
roqqit abandoned D17059: Revert "[avalanche] Promote stake contenders when the chain tip updates".
Nov 1 2024, 21:17
roqqit published D17058: Fix lock order inversion in promoteStakeContendersToTip for review.
Nov 1 2024, 21:17
tobias_ruck added inline comments to D17037: [chronik] index scripts by scripthashes in the mempool.
Nov 1 2024, 19:36
tobias_ruck added inline comments to D17037: [chronik] index scripts by scripthashes in the mempool.
Nov 1 2024, 19:34
tobias_ruck requested changes to D17037: [chronik] index scripts by scripthashes in the mempool.
Nov 1 2024, 19:31
tobias_ruck added inline comments to D16937: [chronik] add scripthash option to the various script endpoints.
Nov 1 2024, 19:28
tobias_ruck accepted D16937: [chronik] add scripthash option to the various script endpoints.

One nit

Nov 1 2024, 19:27
tobias_ruck accepted D16944: [ecash-agora] Add validation to _acceptTxBuilder to prevent creation of unspendable offers.

Otherwise lgtm

Nov 1 2024, 19:19
bytesofman added inline comments to D17046: [new lokad] Add spec for onchain trollbox for tokens.
Nov 1 2024, 18:51
roqqit requested review of D17059: Revert "[avalanche] Promote stake contenders when the chain tip updates".
Nov 1 2024, 18:17
roqqit added a reverting change for D17027: [avalanche] Promote stake contenders when the chain tip updates: D17059: Revert "[avalanche] Promote stake contenders when the chain tip updates".
Nov 1 2024, 18:17
roqqit added a reverting change for rABCf223acc35389: [avalanche] Promote stake contenders when the chain tip updates: D17059: Revert "[avalanche] Promote stake contenders when the chain tip updates".
Nov 1 2024, 18:16
tobias_ruck requested changes to D17046: [new lokad] Add spec for onchain trollbox for tokens.

Otherwise seems good to go, the timeFirstSeen seems fine.

Nov 1 2024, 17:42
bytesofman published D17053: [Cashtab] Implement typescript for review.
Nov 1 2024, 17:00
teamcity triaged T3672: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Nov 1 2024, 16:03
bytesofman added inline comments to D17046: [new lokad] Add spec for onchain trollbox for tokens.
Nov 1 2024, 15:53
roqqit closed D17027: [avalanche] Promote stake contenders when the chain tip updates.
Nov 1 2024, 15:48
roqqit committed rABCf223acc35389: [avalanche] Promote stake contenders when the chain tip updates (authored by roqqit).
[avalanche] Promote stake contenders when the chain tip updates
Nov 1 2024, 15:48
bytesofman added inline comments to D17046: [new lokad] Add spec for onchain trollbox for tokens.
Nov 1 2024, 14:04
bytesofman closed D17057: [ecash-herald] Patch axios syntax bug in getNextStakingReward.
Nov 1 2024, 13:38
bytesofman committed rABC4b78a30b555d: [ecash-herald] Patch axios syntax bug in getNextStakingReward (authored by bytesofman).
[ecash-herald] Patch axios syntax bug in getNextStakingReward
Nov 1 2024, 13:38
Fabien added inline comments to D17046: [new lokad] Add spec for onchain trollbox for tokens.
Nov 1 2024, 13:27
Fabien accepted D17057: [ecash-herald] Patch axios syntax bug in getNextStakingReward.

Good catch !

Nov 1 2024, 13:25
bytesofman closed D17054: [Cashtab] Lint GoogleAnalytics.js.
Nov 1 2024, 13:07
bytesofman committed rABCcd1d35645a2b: [Cashtab] Lint GoogleAnalytics.js (authored by bytesofman).
[Cashtab] Lint GoogleAnalytics.js
Nov 1 2024, 13:07
bytesofman closed D17055: [Cashtab] Remove debug statement from test file.
Nov 1 2024, 13:06
bytesofman committed rABCe25bd3a5c125: [Cashtab] Remove debug statement from test file (authored by bytesofman).
[Cashtab] Remove debug statement from test file
Nov 1 2024, 13:06
bytesofman closed D17052: [Cashtab] Improved styling for OrderBook.
Nov 1 2024, 12:58
bytesofman committed rABC5cf9d4e27431: [Cashtab] Improved styling for OrderBook (authored by bytesofman).
[Cashtab] Improved styling for OrderBook
Nov 1 2024, 12:58
bytesofman committed rABCb1a8ebc9bda4: [Cashtab] Organize OrderBook and styles (authored by bytesofman).
[Cashtab] Organize OrderBook and styles
Nov 1 2024, 12:58
bytesofman closed D17051: [Cashtab] Organize OrderBook and styles.
Nov 1 2024, 12:58
bytesofman published D17057: [ecash-herald] Patch axios syntax bug in getNextStakingReward for review.
Nov 1 2024, 12:56
PiRK planned changes to D17043: [chronik] implement scripthash type for utxos endpoints.

still need to fix the decompress_script injection which currently breaks tests

Nov 1 2024, 09:26
emack accepted D17052: [Cashtab] Improved styling for OrderBook.
Nov 1 2024, 00:11
emack accepted D17054: [Cashtab] Lint GoogleAnalytics.js.
Nov 1 2024, 00:06

Oct 31 2024

emack accepted D17055: [Cashtab] Remove debug statement from test file.
Oct 31 2024, 23:30
emack accepted D17051: [Cashtab] Organize OrderBook and styles.
Oct 31 2024, 23:29
abc-bot committed rABCb34fd41f36a8: [Automated] Update electrum checkpoints (authored by abc-bot).
[Automated] Update electrum checkpoints
Oct 31 2024, 23:13
teamcity added a comment to D17043: [chronik] implement scripthash type for utxos endpoints.
Oct 31 2024, 20:36
teamcity added a comment to D17043: [chronik] implement scripthash type for utxos endpoints.
Oct 31 2024, 20:25
PiRK planned changes to D17056: [electrum] remove outdated error message.

Actually I'm not sure we should remove it. It seems like this was reused and re-removed even after D4576 (see D5283). Maybe we should keep looking for it in Electrum it for another potential future node consensus upgrade?

Oct 31 2024, 20:21
teamcity added a comment to D17043: [chronik] implement scripthash type for utxos endpoints.
Oct 31 2024, 20:19
PiRK requested review of D17056: [electrum] remove outdated error message.
Oct 31 2024, 20:16
PiRK updated the diff for D17043: [chronik] implement scripthash type for utxos endpoints.

rebase

Oct 31 2024, 20:08
PiRK updated the diff for D17037: [chronik] index scripts by scripthashes in the mempool.

rebase

Oct 31 2024, 20:07
bytesofman published D17055: [Cashtab] Remove debug statement from test file for review.
Oct 31 2024, 18:04
bytesofman published D17054: [Cashtab] Lint GoogleAnalytics.js for review.
Oct 31 2024, 18:04
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

remove now useless functions and imports

Oct 31 2024, 16:38
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

remove the need to access db for checking if the index is enabled

Oct 31 2024, 16:29
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

no more need for the todo

Oct 31 2024, 13:49
PiRK updated the diff for D17037: [chronik] index scripts by scripthashes in the mempool.

then_some, don't allocate

Oct 31 2024, 13:48
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

revert accidental squashing

Oct 31 2024, 13:43
PiRK planned changes to D16937: [chronik] add scripthash option to the various script endpoints.

I accidentaly squashed the child diff while trying to reabase and amend it

Oct 31 2024, 13:31
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

use then_some, don't allocate to query the hashmap

Oct 31 2024, 13:28
PiRK added inline comments to D17037: [chronik] index scripts by scripthashes in the mempool.
Oct 31 2024, 13:22
bytesofman published D17052: [Cashtab] Improved styling for OrderBook for review.
Oct 31 2024, 12:56
bytesofman closed D17045: [Cashtab] Render a token info page for any tokenId, regardless of user balance.
Oct 31 2024, 12:55
bytesofman committed rABC3c7e1086cad6: [Cashtab] Render a token info page for any tokenId, regardless of user balance (authored by bytesofman).
[Cashtab] Render a token info page for any tokenId, regardless of user balance
Oct 31 2024, 12:55
bytesofman closed D17047: [ecash-herald] Parse NFTs and agora oneshot txs.
Oct 31 2024, 12:50
bytesofman committed rABCe242cfdf72d7: [ecash-herald] Parse NFTs and agora oneshot txs (authored by bytesofman).
[ecash-herald] Parse NFTs and agora oneshot txs
Oct 31 2024, 12:50
bytesofman closed D17050: [token-server] Patch bug in token validation function.
Oct 31 2024, 12:50
bytesofman committed rABCc2795be8090d: [token-server] Patch bug in token validation function (authored by bytesofman).
[token-server] Patch bug in token validation function
Oct 31 2024, 12:50
bytesofman published D17051: [Cashtab] Organize OrderBook and styles for review.
Oct 31 2024, 12:49
emack accepted D17045: [Cashtab] Render a token info page for any tokenId, regardless of user balance.
Oct 31 2024, 12:11
emack accepted D17047: [ecash-herald] Parse NFTs and agora oneshot txs.
Oct 31 2024, 12:05
emack accepted D17050: [token-server] Patch bug in token validation function.
Oct 31 2024, 12:04
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

return a better error if the scripthash index is disabled

Oct 31 2024, 11:54
bytesofman updated the diff for D17046: [new lokad] Add spec for onchain trollbox for tokens.

improve spec description in line with suggested comments, provide spec for Cashtab planned implementation

Oct 31 2024, 11:21
bytesofman closed D17049: [Cashtab] Update bad tokenId validation function.
Oct 31 2024, 11:13
bytesofman committed rABC54b031295447: [Cashtab] Update bad tokenId validation function (authored by bytesofman).
[Cashtab] Update bad tokenId validation function
Oct 31 2024, 11:13
bytesofman requested review of D17047: [ecash-herald] Parse NFTs and agora oneshot txs.
Oct 31 2024, 11:11
bytesofman updated the diff for D17045: [Cashtab] Render a token info page for any tokenId, regardless of user balance.

handle invalid tokenId, handle /token/ route, confirm with test

Oct 31 2024, 11:07
bytesofman added a comment to D17045: [Cashtab] Render a token info page for any tokenId, regardless of user balance.

http://localhost:3000/#/token/ just renders a blank page with the header - perhaps default to / route?.

Oct 31 2024, 11:07
emack accepted D17049: [Cashtab] Update bad tokenId validation function.
Oct 31 2024, 11:05
bytesofman published D17050: [token-server] Patch bug in token validation function for review.
Oct 31 2024, 10:34
bytesofman published D17049: [Cashtab] Update bad tokenId validation function for review.
Oct 31 2024, 10:34
tobias_ruck requested changes to D17046: [new lokad] Add spec for onchain trollbox for tokens.
Oct 31 2024, 07:56