There's a 3 second lag to scrolling on this test site. Unlikely to be caused by this diff and I guess we haven't had a diff that necessitated the scrolling of tx history but it is a material issue.

check also the id in the response matches the one in the query

Changed cargo build to cargo build --locked to ensure reproducible builds

Build Bitcoin ABC Diffs / Diff Testing (preview-explorer) passed.
Preview is available at http://51.178.130.230:41946 for the next 60 minutes.

@bot preview-explorer

Probably needs another look at how the tests are organized, since they were written to test a different class compared to what we have now. But imo worth pushing this update as it shows this now-improved class is capable of the same behaviors before this review, but with better style.

refactor for fluency, address feedback, improve encode and decode functions in cashaddr for legacy address, update tests

feedback

address review

This doesn't break the explorer deployment because it doesn't use the --locked flag. In a follow-up @hazzarust can you update the Dockerfile to use the --locked flag ? This will require to:

• move it to the root so the Cargo.lock is in the docker context
• update the build-configurations.yml to use the appropriated file in the preview-explorer build

For the test plan, you can run the build on your machine just like it's run on CI:
./contrib/teamcity/build-configurations.py build-explorer
You might need to install some pip packages, just follow what python fails to import.

Updated lint

Updated formatting

fix potential deadlock

version bump, rebase

rebase onto D17304

add missing braces for clang-tidy

missing braces