Page MenuHomePhabricator
Feed All Stories

Mon, Dec 16

PiRK updated the diff for D17314: [chronik] add a test for the new JSON RPC interface.

reduce port range to 3000 to keep the same effective range of ports

Mon, Dec 16, 14:03
Fabien accepted D17347: [chronik] add macros to extract params from a JSONRPC request.
Mon, Dec 16, 13:54
PiRK closed D17354: [electrum] use blockchain.transaction.get_height method.
Mon, Dec 16, 13:53
PiRK committed rABC26ca7aa70c44: [electrum] use blockchain.transaction.get_height method (authored by PiRK).
[electrum] use blockchain.transaction.get_height method
Mon, Dec 16, 13:53
Fabien closed D17360: [chronik-docs] Fix download links.
Mon, Dec 16, 13:51
Fabien committed rABC951384487677: [chronik-docs] Fix download links (authored by Fabien).
[chronik-docs] Fix download links
Mon, Dec 16, 13:50
Fabien closed D17359: [chronik-docs] Update the latest client version.
Mon, Dec 16, 13:50
Fabien committed rABCacf701c2ff16: [chronik-docs] Update the latest client version (authored by Fabien).
[chronik-docs] Update the latest client version
Mon, Dec 16, 13:50
PiRK planned changes to D17356: [chronik] add electrum method blockchain.transaction.get_height.

Collision on port 33380, Lets try to reduce the port range first to not conflict with docker ports (see D16048)

Mon, Dec 16, 13:47
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

adding docs, style clean-ups, remove default type as it is not used anymore, remove unnecessary code duplication

Mon, Dec 16, 13:45
teamcity added a comment to D17356: [chronik] add electrum method blockchain.transaction.get_height.
Mon, Dec 16, 13:38
PiRK updated the test plan for D17354: [electrum] use blockchain.transaction.get_height method.
Mon, Dec 16, 13:38
tobias_ruck accepted D17347: [chronik] add macros to extract params from a JSONRPC request.

very cool!

Mon, Dec 16, 13:38
PiRK updated the summary of D17356: [chronik] add electrum method blockchain.transaction.get_height.
Mon, Dec 16, 13:37
PiRK updated the diff for D17356: [chronik] add electrum method blockchain.transaction.get_height.

do this without the macro from D17355 (need to study macros more to make it work), fix clippy::needless-question-mark

Mon, Dec 16, 13:28
bytesofman closed D17358: [ecash-herald] patch docker.
Mon, Dec 16, 13:26
bytesofman committed rABC9c49d22f48d3: [ecash-herald] patch docker (authored by bytesofman).
[ecash-herald] patch docker
Mon, Dec 16, 13:26
teamcity added a comment to D17323: [chronik] add electrum method blockchain.transaction.get.
Mon, Dec 16, 13:07
teamcity added a comment to D17347: [chronik] add macros to extract params from a JSONRPC request.
Mon, Dec 16, 12:56
PiRK updated the diff for D17347: [chronik] add macros to extract params from a JSONRPC request.

rebase

Mon, Dec 16, 12:50
PiRK updated the diff for D17323: [chronik] add electrum method blockchain.transaction.get.

use consistent error message "Unknown transaction id"

Mon, Dec 16, 12:49
PiRK planned changes to D17347: [chronik] add macros to extract params from a JSONRPC request.
Mon, Dec 16, 12:47
PiRK updated the diff for D17347: [chronik] add macros to extract params from a JSONRPC request.

test all errors responses

Mon, Dec 16, 12:42
tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Mon, Dec 16, 12:27
PiRK accepted D17359: [chronik-docs] Update the latest client version.
Mon, Dec 16, 11:25
PiRK accepted D17360: [chronik-docs] Fix download links.
Mon, Dec 16, 11:25
Fabien accepted D17354: [electrum] use blockchain.transaction.get_height method.

now it works even if electrum is not synced to the tip btw

Mon, Dec 16, 11:10
Fabien requested changes to D17347: [chronik] add macros to extract params from a JSONRPC request.

I would love to see a test for these error cases, since blockchain.transaction.get has both a mandatory and an optional arg it fits perfectly

Mon, Dec 16, 11:06
Fabien accepted D17323: [chronik] add electrum method blockchain.transaction.get.
Mon, Dec 16, 11:01
Fabien requested review of D17360: [chronik-docs] Fix download links.
Mon, Dec 16, 10:50
Fabien requested review of D17359: [chronik-docs] Update the latest client version.
Mon, Dec 16, 10:36
tobias_ruck requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Mon, Dec 16, 10:11
tobias_ruck accepted D17314: [chronik] add a test for the new JSON RPC interface.
Mon, Dec 16, 10:03
Fabien requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Mon, Dec 16, 09:52
Fabien requested changes to D17349: [seeder] Bump thread stacksize.
Mon, Dec 16, 09:15
PiRK accepted D17358: [ecash-herald] patch docker.
Mon, Dec 16, 06:09
bytesofman added a comment to D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.

This may be subjective but I'm not seeing a drastic improvement after updating to latest and hard refreshing twice. In some instances prod loaded the home screen and agora pages quicker than the test site, though that could also be the hosting infra playing a part. Tests were done with wallets having agora txs in tx history

Mon, Dec 16, 05:06
bytesofman updated the diff for D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.

=== p2pkh instead of !== p2sh

Mon, Dec 16, 05:05
bytesofman published D17358: [ecash-herald] patch docker for review.
Mon, Dec 16, 04:53
emack requested changes to D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.

confirm there that load times are significantly improved for wallets with Agora txs

Mon, Dec 16, 04:51
bytesofman updated the diff for D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.

rebase

Mon, Dec 16, 00:49
bytesofman updated the test plan for D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.
Mon, Dec 16, 00:47
bytesofman closed D17353: [Cashtab] Convert Home screen to typescript.
Mon, Dec 16, 00:40
bytesofman committed rABC9b4c6905cbae: [Cashtab] Convert Home screen to typescript (authored by bytesofman).
[Cashtab] Convert Home screen to typescript
Mon, Dec 16, 00:40
bytesofman added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Mon, Dec 16, 00:39
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

implementing feedback (add parse method, clean up existing methods, doc, remove unused interfaces and imports now that stuff is cleaned up)

Mon, Dec 16, 00:38
emack accepted D17353: [Cashtab] Convert Home screen to typescript.
Mon, Dec 16, 00:27

Sun, Dec 15

tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Sun, Dec 15, 23:38
teamcity added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Sun, Dec 15, 22:47
teamcity added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Sun, Dec 15, 22:43
teamcity added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Sun, Dec 15, 22:41
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

ts build lint

Sun, Dec 15, 22:41
teamcity added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Sun, Dec 15, 22:40
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

simplify constructor, pure functions for legacy() and cash(), better error handling for withPrefix

Sun, Dec 15, 22:36
bytesofman added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Sun, Dec 15, 22:35
abc-bot committed rABC5782e63f3348: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Sun, Dec 15, 22:11
abc-bot committed rABCeaa7b1f28c26: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Sun, Dec 15, 22:04
bytesofman updated the diff for D17353: [Cashtab] Convert Home screen to typescript.

Use '===' and not '=='

Sun, Dec 15, 21:55
bytesofman added inline comments to D17353: [Cashtab] Convert Home screen to typescript.
Sun, Dec 15, 21:55
bytesofman closed D17351: [ecash-herald] Correct upgraded mock chronik client in script.
Sun, Dec 15, 21:51
bytesofman committed rABC83bf5311bb43: [ecash-herald] Correct upgraded mock chronik client in script (authored by bytesofman).
[ecash-herald] Correct upgraded mock chronik client in script
Sun, Dec 15, 21:51
abc-bot committed rABCe2fe260bbaa1: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Sun, Dec 15, 21:37
emack requested changes to D17353: [Cashtab] Convert Home screen to typescript.
Sun, Dec 15, 21:07
emack accepted D17351: [ecash-herald] Correct upgraded mock chronik client in script.
Sun, Dec 15, 20:42
bytesofman published D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen for review.
Sun, Dec 15, 18:20

Sat, Dec 14

teamcity added a comment to D17356: [chronik] add electrum method blockchain.transaction.get_height.
Sat, Dec 14, 21:52
teamcity added a comment to D17356: [chronik] add electrum method blockchain.transaction.get_height.
Sat, Dec 14, 21:48
PiRK planned changes to D17356: [chronik] add electrum method blockchain.transaction.get_height.

Let's wait to see if tests pass on CI or we get port collisions. The direct parent diff is a draft, this one was supposed to be one too.

Sat, Dec 14, 21:42
PiRK requested review of D17356: [chronik] add electrum method blockchain.transaction.get_height.
Sat, Dec 14, 21:40
PiRK updated the diff for D17347: [chronik] add macros to extract params from a JSONRPC request.

rebase

Sat, Dec 14, 21:37
hazzarust updated the diff for D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

Moved modules/bitcoinsuite-chronik-client next to other modules in workspace. Moved chronik-proto = { path = "../../chronik/chronik-proto/"} to other local dependencies

Sat, Dec 14, 19:13
PiRK requested review of D17354: [electrum] use blockchain.transaction.get_height method.
Sat, Dec 14, 15:03
hazzarust closed D17352: [explorer.Dockerfile][build-configurations.yml] Removed --locked flag.
Sat, Dec 14, 14:42
hazzarust committed rABC01827d42bc72: [explorer.Dockerfile][build-configurations.yml] Removed --locked flag (authored by hazzarust).
[explorer.Dockerfile][build-configurations.yml] Removed --locked flag
Sat, Dec 14, 14:42
tobias_ruck added inline comments to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Sat, Dec 14, 13:29
tobias_ruck requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Sat, Dec 14, 13:29
teamcity awarded D17347: [chronik] add macros to extract params from a JSONRPC request a Haypence token.
Sat, Dec 14, 12:17
PiRK added a comment to D17347: [chronik] add macros to extract params from a JSONRPC request.

@bot build-chronik build-chronik-plugins

Sat, Dec 14, 12:17
Fabien accepted D17352: [explorer.Dockerfile][build-configurations.yml] Removed --locked flag.

This unbreaks the explorer deployment, however we should find a fix for this issue

Sat, Dec 14, 12:08
PiRK added a comment to D17347: [chronik] add macros to extract params from a JSONRPC request.

These issues are likely port collisions

2024-12-13T20:49:51.570827Z [chronik/chronik-lib/src/bridge.rs:181] [<chronik unknown>] Starting Chronik Electrum interface bound to [(127.0.0.1:33252, Tcp)]
2024-12-13T20:49:51.574474Z [chronik/chronik-indexer/src/indexer.rs:1491] [<chronik unknown>] Chronik Electrum failed serving: Address already in use (os error 98)
2024-12-13T20:49:51.574503Z [/work/src/shutdown.cpp:22] [AbortNode] *** ERROR Chronik in ChronikElectrumServer::serve
2024-12-13T20:49:51.574521Z [/work/src/noui.cpp:42] [noui_ThreadSafeMessageBox] Error: Chronik Electrum failed serving: Address already in use (os error 98)
Sat, Dec 14, 11:01
• redball4az added a comment to D17349: [seeder] Bump thread stacksize.
Sat, Dec 14, 07:31
• redball4az added a comment to D17352: [explorer.Dockerfile][build-configurations.yml] Removed --locked flag.
Sat, Dec 14, 07:30
bytesofman published D17353: [Cashtab] Convert Home screen to typescript for review.
Sat, Dec 14, 05:34
hazzarust updated the test plan for D17352: [explorer.Dockerfile][build-configurations.yml] Removed --locked flag.
Sat, Dec 14, 01:08
hazzarust updated the summary of D17352: [explorer.Dockerfile][build-configurations.yml] Removed --locked flag.
Sat, Dec 14, 01:08
hazzarust updated the diff for D17352: [explorer.Dockerfile][build-configurations.yml] Removed --locked flag.

Updating lint

Sat, Dec 14, 00:54
hazzarust requested review of D17352: [explorer.Dockerfile][build-configurations.yml] Removed --locked flag.
Sat, Dec 14, 00:53

Fri, Dec 13

bytesofman published D17351: [ecash-herald] Correct upgraded mock chronik client in script for review.
Fri, Dec 13, 23:36
PiRK planned changes to D17347: [chronik] add macros to extract params from a JSONRPC request.

There seems to be some kind if intermittent issue introduced by this diff or it's parent. To be investigated.

Fri, Dec 13, 22:01
hazzarust updated the diff for D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

Deleted newline in hash.rs

Fri, Dec 13, 21:39
hazzarust updated the summary of D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Fri, Dec 13, 21:20
hazzarust updated the diff for D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

Import chronik-proto from /chronik

Fri, Dec 13, 21:19
teamcity closed T3704: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Resolved.
Fri, Dec 13, 21:11
roqqit closed D17348: [seeder] Return an error when thread creation fails.
Fri, Dec 13, 21:06
roqqit committed rABC200513e58adb: [seeder] Return an error when thread creation fails (authored by roqqit).
[seeder] Return an error when thread creation fails
Fri, Dec 13, 21:06
roqqit closed D17350: [seeder] Reword outdated note in readme.
Fri, Dec 13, 21:05
roqqit committed rABC82d1ab6e576c: [seeder] Reword outdated note in readme (authored by roqqit).
[seeder] Reword outdated note in readme
Fri, Dec 13, 21:05
PiRK accepted D17348: [seeder] Return an error when thread creation fails.
Fri, Dec 13, 21:04
PiRK accepted D17350: [seeder] Reword outdated note in readme.
Fri, Dec 13, 21:00
teamcity added a comment to D17347: [chronik] add macros to extract params from a JSONRPC request.
Fri, Dec 13, 20:52