New line added + updated server to make explicit

Removed assert_eq

no need for the list conversion. In our codebase bip39_list is already a list because we use Trezor's mnemonic library (so we can support multiple languages for restoring seeds) https://github.com/trezor/python-mnemonic/blob/master/src/mnemonic/mnemonic.py#L56

restore https://github.com/Bitcoin-ABC/ElectrumABC/commit/e2d0f7f804a0b805644957f423e04120cff921b3 and https://github.com/Bitcoin-ABC/ElectrumABC/commit/ac0da1446ed153c291b065cd9ef8a20ef561081d

I may have lost a few Electron Cash improvements in keyPressEvent in the process

Removed useless comment

Deleted second test, made socket error handling verbose

Made changes suggested

Back out unrelated package-lock.json changes

greening this as I don't want to block it when I go to bed, but the package-lock.json changes should be backed out before landing

So look at the code:

• The second test is doing the same as the first plus some more. This makes it clear that you don't need both because they are overlapping
• As a result you don't need serial. To be honest I don't know why you needed it in the first place, but after it's obvious that it's no longer needed.
• Because you only need a single test, you can build on top of the one from the dependency diff D17564, which will avoid me requesting the same changes again.

Please fix the typos in the summary, and fix the test plan which doesn't work.
To format commands you can either use backticks (example) or on a newline prepend with two spaces:

like so

Don't use quotes for "Depends on xxxxx" (I edited your summary to remove them)

The test plan doesn't work

Fix the ordering icons

In D17562#399652, @bytesofman wrote:

mb this issue is just from me running it locally?

sorting is broken at explorer.e.cash, but I do see the arrow highlighted on clicking to show sort:

Running this diff, the sorting is fixed, but I do not see the up or down arrows highlight on click to indicate sort:

The arrow highlighting still works on the "size" sort option but not Age or Date. Probably since Age and Date are now actually sorting by timestamp, so the templating is not picking up the effect.

probably still worth landing the diff to fix the behavior. I am not sure how I would fix this style issue with rust templating.

mb this issue is just from me running it locally?

Note that I had to first revert D17457 to test this, because D17457 introduces a new bug preventing pairing with a Trezor 1