Feed All Stories
Jan 25 2025
Jan 25 2025
bytesofman committed rABC81de6074a0f9: [Cashtab] Make listing amounts more readable in agora listing notifications (authored by bytesofman).
[Cashtab] Make listing amounts more readable in agora listing notifications
Fabien requested changes to D17590: [avalanche] Check that avalanche invalidated items no longer poll in the dont_poll_invalid_item test case.
This is not testing what you think, as it's not testing the node stops polling the invalidated item. It checks that it rejects a unexpected vote, which is the correct behavior but will happen whatever the vote status of the item is.
Fabien requested changes to D17589: [avalanche] Clear updates on each call to registerVotes.
Bump the timeout in p2p_ibd_stalling
Bump the timeout for the feature_cltv test
bytesofman committed rABCe1f8ecba93fe: [Cashtab] Reduce tx autoclose time from 5s to 2s (authored by bytesofman).
[Cashtab] Reduce tx autoclose time from 5s to 2s
bytesofman published D17591: [Cashtab] Reduce tx autoclose time from 5s to 2s for review.
[cashtab] Token view UI updates
Jan 24 2025
Jan 24 2025
johnkuney updated the diff for D17588: [cashtab] Token view UI updates.
delete balancetokenheader component as no longer used anywhere
bytesofman requested changes to D17588: [cashtab] Token view UI updates.
nice looks much better.
roqqit requested review of D17589: [avalanche] Clear updates on each call to registerVotes.
johnkuney published D17588: [cashtab] Token view UI updates for review.
hazzarust updated the diff for D17564: [chronik] Add test runner to bitcoinsuite-chronik-client.
Asserted at the end of test to make sure we return an error. Killing child process won't return an error, so we get the returned error from assert
PiRK requested review of D17587: [electrum] push release notification for 5.4.0.
hazzarust updated the diff for D17565: [Chronik] Add unix socket listener to test_runner.rs.
Removed timeout
hazzarust updated the diff for D17564: [chronik] Add test runner to bitcoinsuite-chronik-client.
Added error handling
Fabien requested changes to D17582: [avalanche] Add an invalidation latch to contender cache.
Invalidated invs are removed from the polling list anyway so I'm not sure what the use case is for this. Clearing my queue for now.
Fabien committed rABC55ae02dedb89: [e.cash] Add a link to the chronik documentation (authored by Fabien).
[e.cash] Add a link to the chronik documentation
Fabien requested review of D17586: Bump the timeout in p2p_ibd_stalling.
Fabien requested review of D17585: Bump the timeout for the feature_cltv test.
johnkuney planned changes to D17584: [cashtab] Token view UI updates.
Jan 23 2025
Jan 23 2025
teamcity added a comment to D17584: [cashtab] Token view UI updates.
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
johnkuney planned changes to D17584: [cashtab] Token view UI updates.
teamcity added a comment to D17584: [cashtab] Token view UI updates.
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
johnkuney requested review of D17584: [cashtab] Token view UI updates.
PiRK committed rABC25bf4ca369b9: [electrum] bump version to 5.4.0 and add release notes (authored by PiRK).
[electrum] bump version to 5.4.0 and add release notes
PiRK committed rABC491b7cda88c1: [electrum] fix lib versions for windows release scripts (authored by PiRK).
[electrum] fix lib versions for windows release scripts
PiRK updated the diff for D17581: [electrum] bump version to 5.4.0 and add release notes.
use 5.4.0 because of the new features
teamcity added a comment to D17583: [e.cash] Add a link to the chronik documentation.
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41191 for the next 60 minutes.
teamcity awarded D17583: [e.cash] Add a link to the chronik documentation a Haypence token.
Fabien added a comment to D17583: [e.cash] Add a link to the chronik documentation.
@bot preview-e.cash
Fabien requested review of D17583: [e.cash] Add a link to the chronik documentation.
roqqit requested review of D17582: [avalanche] Add an invalidation latch to contender cache.
roqqit committed rABC8a22e311702c: [avalanche] Fixup incorrect comment about contender cache vote status (authored by roqqit).
[avalanche] Fixup incorrect comment about contender cache vote status
PiRK requested review of D17581: [electrum] bump version to 5.4.0 and add release notes.
PiRK updated the test plan for D17580: [electrum] fix lib versions for windows release scripts.
PiRK committed rABCfb94895b4483: [electrum] Implement SLIP-0039 wallet recovery. (authored by Andrew Kozlik <andrew.kozlik@gmail.com>).
[electrum] Implement SLIP-0039 wallet recovery.
PiRK updated the summary of D17577: [electrum] Implement SLIP-0039 wallet recovery..
PiRK requested review of D17580: [electrum] fix lib versions for windows release scripts.
Fabien committed rABC9fe5282e5388: [electrum][trezor] 1-click install of the eCash logo as a homescreen (authored by Fabien).
[electrum][trezor] 1-click install of the eCash logo as a homescreen
Mengerian added a comment to D17579: [electrum][trezor] 1-click install of the eCash logo as a homescreen.
[electrum][trezor] Fix homescreen reset
PiRK retitled D17577: [electrum] Implement SLIP-0039 wallet recovery. from Implement SLIP-0039 wallet recovery. to [electrum] Implement SLIP-0039 wallet recovery..
PiRK committed rABC92e7592a5448: [electrum] pass the bip32 rootseed to the derivation path scanner (authored by PiRK).
[electrum] pass the bip32 rootseed to the derivation path scanner
PiRK added a comment to D17579: [electrum][trezor] 1-click install of the eCash logo as a homescreen.
will test a dummy release later to make sure the image files are properly packaged and relative paths work as expected
probably broken in some major trezor API change (looks like they passed images as strings before, or maybe it was a python2 thing) https://github.com/spesmilo/electrum/commit/dda9d4b746700bfc095c80d84f1ac5de46c5f2ca
Fabien requested review of D17579: [electrum][trezor] 1-click install of the eCash logo as a homescreen.
PiRK updated the diff for D17577: [electrum] Implement SLIP-0039 wallet recovery..
minor improvements
Fabien requested review of D17578: [electrum][trezor] Fix homescreen reset.
PiRK planned changes to D17577: [electrum] Implement SLIP-0039 wallet recovery..
found a couple of minor fixups to backport
PiRK published D17577: [electrum] Implement SLIP-0039 wallet recovery. for review.
PiRK requested review of D17576: [electrum] pass the bip32 rootseed to the derivation path scanner.
bytesofman committed rABC63dc3deda632: [Cashtab] No double notifications for SLP partial lists (authored by bytesofman).
[Cashtab] No double notifications for SLP partial lists
Jan 22 2025
Jan 22 2025
bytesofman published D17575: [Cashtab] No double notifications for SLP partial lists for review.
bytesofman added a comment to D17464: [ecash-lib] attach ecc and hashes to globalThis.
Some alt options on this diff
Unknown Object (User) added a comment to D7441: [CMAKE] Fix issues when looking for libraries installed with homebrew.
Jan 21 2025
Jan 21 2025
bytesofman committed rABCf840614d26c6: [Cashtab] Make sure selectedOffer cannot be undefined after a ws update (authored by bytesofman).
[Cashtab] Make sure selectedOffer cannot be undefined after a ws update
roqqit requested review of D17574: [avalanche] Fixup incorrect comment about contender cache vote status.
Fabien requested changes to D17565: [Chronik] Add unix socket listener to test_runner.rs.
Fabien requested changes to D17564: [chronik] Add test runner to bitcoinsuite-chronik-client.
PiRK committed rABCb7a52c79e63d: [electrum] refactor: introduce a Wordlist class for seed phrases (authored by PiRK).
[electrum] refactor: introduce a Wordlist class for seed phrases