Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Apr 25 2019
Apr 25 2019
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D2877: [DOC] Add headers inclusion guidelines to the developer notes: deadalnix.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Rebase
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Rebase
Fabien committed rABCd97910652534: Use angle bracket in include for wallet test (authored by Fabien).
Use angle bracket in include for wallet test
jasonbcox committed rABCaeb3ff3467ce: [qt] Simplifies boolean expression model && model->haveWatchOnly() (authored by 251 <13120787+251Labs@users.noreply.github.com>).
[qt] Simplifies boolean expression model && model->haveWatchOnly()
jasonbcox committed rABC370d6146a348: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked… (authored by practicalswift <practicalswift@users.noreply.github.com>).
[qt] Avoid potential null pointer dereference in TransactionView::exportClicked…
Realized my comment isn't really standardizable across all source files, so ignore me.
Harbormaster failed remote builds in B5597: Diff 8266 for D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration!
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Move to the root CMakeLists.txt
Fabien requested changes to D2872: blockfilter: Refactor and add tests for BlockFilter construction.
Use angle bracket in include for seeder
Use angle bracket in include for wallet
schancel committed rABCa9acc46b47f0: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction` (authored by schancel).
[nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`
Going to try to revive this for Nov 2019 Upgrade
Although this backport looks ok, I do think we should investigate test coverage in the future
markblundeberg requested review of D2873: serialize: Serialization support for big-endian 32-bit ints..
In D2873#68026, @jasonbcox wrote:I don't see this being used in https://github.com/bitcoin/bitcoin/pull/14121/files Why is it needed?
Apr 24 2019
Apr 24 2019
schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
schancel requested review of D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
I don't see this being used in https://github.com/bitcoin/bitcoin/pull/14121/files Why is it needed?
jasonbcox updated the summary of D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.
jasonbcox requested changes to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Fixed minor changes that shouldn't have deviated from the backport
teamcity added a comment to D2876: [qt] Simplifies boolean expression model && model->haveWatchOnly().
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2875: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked().
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2876: [qt] Simplifies boolean expression model && model->haveWatchOnly().
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D2876: [qt] Simplifies boolean expression model && model->haveWatchOnly(): Restricted Project.
teamcity added a comment to D2875: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked().
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D2875: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked(): Restricted Project.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Doing another round of self review and annotating deviations from the original PR.
Herald added a reviewer for D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp: Restricted Project.
Fabien added a comment to D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.
From the cmake mailing list, this tends to confirm that this property has no impact outside of a windows build: https://cmake.org/pipermail/cmake/2008-March/020577.html
Fabien requested changes to D2846: Do not allow users to get keys from keypool without reserving them.
If -deprecatedrpc=fundrawtransaction is set and the reserveChangeKey option is true, you end up removing the key twice.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D2873: serialize: Serialization support for big-endian 32-bit ints.: deadalnix.
Fabien added a comment to D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.
teamcity added a comment to D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Fabien requested review of D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.
Fabien updated the diff for D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.
I discovered by chance that cmake targets have a property which does exactly the same
(setting the exact same flag) in a more cmake fashion way.
This property has no impact if the build is not a windows executable, so no need to
make it explicitely windows only.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Fix bugs in the contrib/convert-prl-libs-to-cmake.pl. This allows for
converting the windows plugin prl script rather than manually linking
the dependencies.
teamcity added a comment to D2872: blockfilter: Refactor and add tests for BlockFilter construction.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2872: blockfilter: Refactor and add tests for BlockFilter construction.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D2872: blockfilter: Refactor and add tests for BlockFilter construction: deadalnix.
schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
schancel requested review of D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
getting commit fef5adcc3 looks like it should be done after T590, though it looks like the rest of backports can proceed independently of that.
markblundeberg added a parent task for T590: Backport Core 14555: Move util files to new directory: T589: BIP157 & BIP158 backports.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D2871: Remove direct bitcoin calls from qt/optionsdialog.cpp: Restricted Project.