Page MenuHomePhabricator
Feed All Stories

Jul 19 2019

teamcity added a comment to D3697: Merge #11714: [tests] Test that mempool rejects coinbase transactions.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 19 2019, 01:11
nakihito updated the test plan for D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Jul 19 2019, 01:06
nakihito updated the test plan for D3697: Merge #11714: [tests] Test that mempool rejects coinbase transactions.
Jul 19 2019, 01:06
nakihito added inline comments to D3697: Merge #11714: [tests] Test that mempool rejects coinbase transactions.
Jul 19 2019, 01:05
teamcity added a comment to D3697: Merge #11714: [tests] Test that mempool rejects coinbase transactions.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 19 2019, 01:05
nakihito planned changes to D3697: Merge #11714: [tests] Test that mempool rejects coinbase transactions.
Jul 19 2019, 01:04
nakihito created D3697: Merge #11714: [tests] Test that mempool rejects coinbase transactions.
Jul 19 2019, 01:04

Jul 18 2019

teamcity added a comment to D3696: Merge #10036: Fix init README format to render correctly on github.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 18 2019, 21:49
teamcity added a comment to D3695: Merge #11133: Document assumptions that are beoing made to avoid division by zero.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 18 2019, 21:41
teamcity added a comment to D3696: Merge #10036: Fix init README format to render correctly on github.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 18 2019, 21:40
nakihito planned changes to D3696: Merge #10036: Fix init README format to render correctly on github.
Jul 18 2019, 21:40
nakihito created D3696: Merge #10036: Fix init README format to render correctly on github.
Jul 18 2019, 21:39
teamcity added a comment to D3695: Merge #11133: Document assumptions that are beoing made to avoid division by zero.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 18 2019, 21:35
nakihito planned changes to D3695: Merge #11133: Document assumptions that are beoing made to avoid division by zero.
Jul 18 2019, 21:34
nakihito created D3695: Merge #11133: Document assumptions that are beoing made to avoid division by zero.
Jul 18 2019, 21:34
deadalnix accepted D3693: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks.
Jul 18 2019, 21:18
deadalnix requested changes to D3694: Update the github issue template to include disclosure policy.

Reddit is not a good place for this kind of questions.

Jul 18 2019, 21:18
teamcity added a comment to D3694: Update the github issue template to include disclosure policy.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 18 2019, 18:36
teamcity added a comment to D3694: Update the github issue template to include disclosure policy.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 18 2019, 18:30
jasonbcox created D3694: Update the github issue template to include disclosure policy.
Jul 18 2019, 18:30
teamcity added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 18 2019, 18:11
teamcity added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 18 2019, 18:05
nakihito updated the diff for D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Added CMake.

Jul 18 2019, 18:05
teamcity added a comment to D3693: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 18 2019, 17:35
teamcity added a comment to D3693: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 18 2019, 17:28
jasonbcox created D3693: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks.
Jul 18 2019, 17:28
jasonbcox committed rABC440b7dd61e8d: [test_runner] Fix unidash option for junit output to be one character (authored by jasonbcox).
[test_runner] Fix unidash option for junit output to be one character
Jul 18 2019, 16:32
jasonbcox closed D3692: [test_runner] Fix unidash option for junit output to be one character.
Jul 18 2019, 16:31
deadalnix requested changes to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

cmake build

Jul 18 2019, 12:06
markblundeberg added a comment to D3589: [5 of 5] Style cleanup..

system.h/cpp needs to be backported first

Jul 18 2019, 06:13
deadalnix accepted D3692: [test_runner] Fix unidash option for junit output to be one character.
Jul 18 2019, 02:24
teamcity added a comment to D3692: [test_runner] Fix unidash option for junit output to be one character.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 18 2019, 01:39
jasonbcox committed rABC17c55af363ab: [gitian-build] Fix repo directory to point at bitcoin-abc (authored by jasonbcox).
[gitian-build] Fix repo directory to point at bitcoin-abc
Jul 18 2019, 01:37
jasonbcox closed D3686: [gitian-build] Fix repo directory to point at bitcoin-abc.
Jul 18 2019, 01:37
jasonbcox committed rABC1074449cb5db: [gitian-build] Bump default memory setting (authored by jasonbcox).
[gitian-build] Bump default memory setting
Jul 18 2019, 01:36
jasonbcox closed D3688: [gitian-build] Bump default memory setting.
Jul 18 2019, 01:36
jasonbcox committed rABC241b84a9d7c9: [gitian-build] Default the number of jobs to the number of CPUs (authored by jasonbcox).
[gitian-build] Default the number of jobs to the number of CPUs
Jul 18 2019, 01:35
jasonbcox closed D3687: [gitian-build] Default the number of jobs to the number of CPUs.
Jul 18 2019, 01:35
jasonbcox added inline comments to D3690: [test_runner] Fix junitoutput typo.
Jul 18 2019, 01:32
teamcity added a comment to D3692: [test_runner] Fix unidash option for junit output to be one character.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 18 2019, 01:32
jasonbcox created D3692: [test_runner] Fix unidash option for junit output to be one character.
Jul 18 2019, 01:32
jasonbcox committed rABC463b1c7d5a3d: [test_runner] Fix junitoutput typo (authored by jasonbcox).
[test_runner] Fix junitoutput typo
Jul 18 2019, 01:28
jasonbcox closed D3690: [test_runner] Fix junitoutput typo.
Jul 18 2019, 01:28
jasonbcox committed rABC1f0ae2d1ccc9: Fix a bug where the TeamCity build only reports one of the test_runner runs (authored by jasonbcox).
Fix a bug where the TeamCity build only reports one of the test_runner runs
Jul 18 2019, 01:26
jasonbcox closed D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.
Jul 18 2019, 01:26
jasonbcox added inline comments to D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.
Jul 18 2019, 01:25

Jul 17 2019

deadalnix accepted D3688: [gitian-build] Bump default memory setting.
Jul 17 2019, 23:30
deadalnix accepted D3686: [gitian-build] Fix repo directory to point at bitcoin-abc.
Jul 17 2019, 23:29
deadalnix accepted D3687: [gitian-build] Default the number of jobs to the number of CPUs.
Jul 17 2019, 23:29
deadalnix accepted D3690: [test_runner] Fix junitoutput typo.
Jul 17 2019, 23:28
deadalnix accepted D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.

ju is probably about the worse name possible.

Jul 17 2019, 23:27
jasonbcox requested review of D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.
Jul 17 2019, 22:08
jasonbcox updated the test plan for D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.
Jul 17 2019, 22:08
teamcity added a comment to D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 17 2019, 22:06
teamcity added a comment to D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 17 2019, 22:00
jasonbcox updated the summary of D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.
Jul 17 2019, 21:56
teamcity added a comment to D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 17 2019, 21:54
teamcity added a comment to D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 17 2019, 21:48
jasonbcox planned changes to D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.
Jul 17 2019, 21:48
jasonbcox created D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.
Jul 17 2019, 21:48
teamcity added a comment to D3690: [test_runner] Fix junitoutput typo.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 17 2019, 21:34
teamcity added a comment to D3690: [test_runner] Fix junitoutput typo.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 17 2019, 21:28
jasonbcox created D3690: [test_runner] Fix junitoutput typo.
Jul 17 2019, 21:28
teamcity added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 17 2019, 21:00
teamcity added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 17 2019, 20:52
nakihito created D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Jul 17 2019, 20:51
teamcity added a comment to D3688: [gitian-build] Bump default memory setting.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 17 2019, 18:55
jasonbcox retitled D3686: [gitian-build] Fix repo directory to point at bitcoin-abc from Fix gitian-build.py repo directory to point at bitcoin-abc to [gitian-build] Fix repo directory to point at bitcoin-abc.
Jul 17 2019, 18:50
teamcity added a comment to D3688: [gitian-build] Bump default memory setting.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 17 2019, 18:49
jasonbcox created D3688: [gitian-build] Bump default memory setting.
Jul 17 2019, 18:49
teamcity added a comment to D3687: [gitian-build] Default the number of jobs to the number of CPUs.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 17 2019, 18:47
teamcity added a comment to D3687: [gitian-build] Default the number of jobs to the number of CPUs.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 17 2019, 18:41
jasonbcox created D3687: [gitian-build] Default the number of jobs to the number of CPUs.
Jul 17 2019, 18:41
jasonbcox abandoned D3679: Remove config as a class member of BlockAssembler.
Jul 17 2019, 18:26
teamcity added a comment to D3471: Merge #9868: Abstract out the command line options for block assembly.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 17 2019, 18:24
jasonbcox updated the summary of D3471: Merge #9868: Abstract out the command line options for block assembly.
Jul 17 2019, 18:18
teamcity added a comment to D3471: Merge #9868: Abstract out the command line options for block assembly.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 17 2019, 18:17
jasonbcox updated the diff for D3471: Merge #9868: Abstract out the command line options for block assembly.
  • Rebase
  • Remove ComputeMaxGeneratedBlockSize() as it's no longer needed
Jul 17 2019, 18:17
teamcity added a comment to D3686: [gitian-build] Fix repo directory to point at bitcoin-abc.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 17 2019, 17:13
teamcity added a comment to D3686: [gitian-build] Fix repo directory to point at bitcoin-abc.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 17 2019, 17:07
jasonbcox created D3686: [gitian-build] Fix repo directory to point at bitcoin-abc.
Jul 17 2019, 17:07
deadalnix requested changes to D3679: Remove config as a class member of BlockAssembler.

This has not addressed the concern one bit.

Jul 17 2019, 16:57
teamcity added a comment to D3679: Remove config as a class member of BlockAssembler.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 17 2019, 16:34
jasonbcox updated the summary of D3471: Merge #9868: Abstract out the command line options for block assembly.
Jul 17 2019, 16:29
jasonbcox abandoned D3683: Remove config as a class member of BlockAssembler.
Jul 17 2019, 16:29
jasonbcox abandoned D3682: Refactor TestForBlock() to take config as a parameter.
Jul 17 2019, 16:28
jasonbcox abandoned D3681: Refactor addPriorityTxs to take config as a parameter.
Jul 17 2019, 16:28
jasonbcox abandoned D3680: Refactor adding package txs to use config as a parameter.
Jul 17 2019, 16:28
jasonbcox retitled D3679: Remove config as a class member of BlockAssembler from Refactor CreateNewBlock() to use a config parameter instead of the class member to Remove config as a class member of BlockAssembler.
Jul 17 2019, 16:28
teamcity added a comment to D3679: Remove config as a class member of BlockAssembler.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 17 2019, 16:28
jasonbcox updated the diff for D3679: Remove config as a class member of BlockAssembler.

Pulled in D3680 - D3683 to make the API consistent. This removes the config member all in one go.

Jul 17 2019, 16:27
Nico Guiton <nico@bitframe.org> committed rABC4f6623155efe: Merge #11495: [trivial] Make namespace explicit for is_regular_file (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11495: [trivial] Make namespace explicit for is_regular_file
Jul 17 2019, 00:58
Nico Guiton <nico@bitframe.org> closed D3685: Merge #11495: [trivial] Make namespace explicit for is_regular_file.
Jul 17 2019, 00:58
jasonbcox accepted D3685: Merge #11495: [trivial] Make namespace explicit for is_regular_file.
Jul 17 2019, 00:10

Jul 16 2019

deadalnix requested changes to D3679: Remove config as a class member of BlockAssembler.

It doesn't looks like this is creating a self consistent API. In fact, you are importing assumption about the whole program (namely, that there is one config) into BlockAssembler, which a very clear and very bad regression.

Jul 16 2019, 23:47
teamcity added a comment to D3685: Merge #11495: [trivial] Make namespace explicit for is_regular_file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 16 2019, 23:42
teamcity added a comment to D3685: Merge #11495: [trivial] Make namespace explicit for is_regular_file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 16 2019, 23:34
nakihito created D3685: Merge #11495: [trivial] Make namespace explicit for is_regular_file.
Jul 16 2019, 23:34
jasonbcox accepted D3464: [rpc] Add logging RPC.
Jul 16 2019, 23:14
nakihito accepted D3587: [3 of 5] Move CDiskBlockPos from chain to flatfile..
Jul 16 2019, 23:09