Build Bitcoin-ABC / Diffs / Diff Testing started.
Feed All Stories
Dec 4 2019
Dec 4 2019
teamcity added a comment to D4626: Rename contrib/arcanist to source-control-tools.
jasonbcox updated the diff for D4626: Rename contrib/arcanist to source-control-tools.
Fixed errant deleted test-commit.patch and added an appropriate .gitignore so it won't be missed again.
(*.patch are initially ignored by the top-level .gitignore)
teamcity added a comment to D4632: Various nits in cuckoocache_tests.cpp.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4631: doc: Doxygen-friendly CuckooCache comments.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien planned changes to D4415: [CI] Allow to pass addditional arguments to bitcoind.
Harbormaster failed remote builds in B8403: Diff 14613 for D4630: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD!
teamcity added a comment to D4630: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
teamcity added a comment to D4630: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4629: fuzz: Script validation flags.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4629: fuzz: Script validation flags.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4615: test: Build fuzz targets into seperate executables.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4628: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Harbormaster failed remote builds in B8401: Diff 14611 for D4628: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp!
teamcity added a comment to D4628: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
teamcity added a comment to D4615: test: Build fuzz targets into seperate executables.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4628: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien updated the diff for D4628: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp.
Rebase
teamcity added a comment to D4615: test: Build fuzz targets into seperate executables.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien updated the diff for D4615: test: Build fuzz targets into seperate executables.
Newline
teamcity added a comment to D4628: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien updated the diff for D4628: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp.
Rebase
teamcity added a comment to D4615: test: Build fuzz targets into seperate executables.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien updated the diff for D4615: test: Build fuzz targets into seperate executables.
Pick better names
teamcity added a comment to D4628: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4628: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4627: qa: Add test/fuzz/test_runner.py.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
teamcity added a comment to D4627: qa: Add test/fuzz/test_runner.py.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4548: Fix compilation errors in support/lockedpool.cpp.
Build Bitcoin-ABC / Diffs (Staging) / Diff Testing passed.
teamcity added a comment to D4548: Fix compilation errors in support/lockedpool.cpp.
Build Bitcoin-ABC / Diffs (Staging) / Diff Testing started.
Fabien updated the test plan for D4613: build: Allow to configure --with-sanitizers=fuzzer.
deadalnix requested changes to D4625: Cleanup test-autopatch output during `ninja check`.
That whole thing depends on a gazillion environments variables, internet connectivity, and whatever else, and doesn't check at all that bitcoin-abc is working. I really don't see why someone who want to checkout the ABC sources and run the tests to make sure it works have to go through the bullshit of installing arc, setting up an auth token and alike. That makes no sense whatsoever. The software is supposed to get better *FOR USERS* over time. What does it do in the middle of ninja check? How come, when the output of ninja check is polluted, nobody stops one second to ask themsleves "Wait, why is that thing in the output to begin with? Does it need to be?" but instead go on changing all the output formatting so that the main problem remains, but is less visible?
majcosta added inline comments to D4624: refactoring: add a method for determining if a block is pruned or not.
deadalnix requested changes to D4619: Merge #14451: Allow building GUI without BIP70 support.
Do not deprecate BIP70.
Dec 3 2019
Dec 3 2019
Various nits in Seeder files
PS: I think your test plan indentation is broken.
jasonbcox requested changes to D4624: refactoring: add a method for determining if a block is pruned or not.
teamcity added a comment to D4626: Rename contrib/arcanist to source-control-tools.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
jasonbcox requested review of D4619: Merge #14451: Allow building GUI without BIP70 support.
jasonbcox updated the test plan for D4619: Merge #14451: Allow building GUI without BIP70 support.
jasonbcox updated the test plan for D4619: Merge #14451: Allow building GUI without BIP70 support.
teamcity added a comment to D4626: Rename contrib/arcanist to source-control-tools.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4625: Cleanup test-autopatch output during `ninja check`.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCeb8ed1fc6683: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage
jasonbcox added inline comments to D4625: Cleanup test-autopatch output during `ninja check`.
teamcity added a comment to D4625: Cleanup test-autopatch output during `ninja check`.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Build Bitcoin-ABC / Diffs / Diff Testing started.
markblundeberg updated the diff for D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
rm assert & update comment
teamcity added a comment to D4624: refactoring: add a method for determining if a block is pruned or not.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4624: refactoring: add a method for determining if a block is pruned or not.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4623: Various nits in Seeder files.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4623: Various nits in Seeder files.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien committed rABCed3b45c4b998: Fix -Wunused-const-variable in descriptor_tests.cpp (authored by Fabien).
Fix -Wunused-const-variable in descriptor_tests.cpp
teamcity added a comment to D4548: Fix compilation errors in support/lockedpool.cpp.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).
Build Bitcoin-ABC / Diffs / Diff Testing passed.
nakihito updated the summary of D4548: Fix compilation errors in support/lockedpool.cpp.
teamcity added a comment to D4548: Fix compilation errors in support/lockedpool.cpp.
Build Bitcoin-ABC / Diffs / Diff Testing started.
nakihito updated the diff for D4548: Fix compilation errors in support/lockedpool.cpp.
Rebase and added CPPFLAGS=-DARENA_DEBUG to asan build.
teamcity added a comment to D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).
Build Bitcoin-ABC / Diffs / Diff Testing started.
nakihito updated the diff for D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).
Rebase.
deadalnix requested changes to D4621: allow cuckoocache to function as a map.
You probably want to investigate why the build failed.
markblundeberg added inline comments to D4621: allow cuckoocache to function as a map.
Fabien committed rABCe2dc6148fb29: Bugfix: Include <memory> for std::unique_ptr (authored by Luke Dashjr <luke-jr+git@utopios.org>).
Bugfix: Include <memory> for std::unique_ptr
teamcity added a comment to D4622: Fix -Wunused-const-variable in descriptor_tests.cpp.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4622: Fix -Wunused-const-variable in descriptor_tests.cpp.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4611: Bugfix: Include <memory> for std::unique_ptr.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4611: Bugfix: Include <memory> for std::unique_ptr.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien updated the diff for D4611: Bugfix: Include <memory> for std::unique_ptr.
Rebase.
Break the dependency to D4588, which will temporarly add a useless include for the sake of avoinding a rebase hell.
Fabien updated the summary of D4611: Bugfix: Include <memory> for std::unique_ptr.
Harbormaster failed remote builds in B8385: Diff 14590 for D4621: allow cuckoocache to function as a map!
teamcity added a comment to D4621: allow cuckoocache to function as a map.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
teamcity added a comment to D4621: allow cuckoocache to function as a map.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Build Bitcoin-ABC / Diffs / Diff Testing started.