Page MenuHomePhabricator
Feed All Stories

Feb 28 2020

jasonbcox created D5361: Spoof DISPLAY on headless build servers when generating manpages for bitcoin-qt.
Feb 28 2020, 02:21
nakihito committed rABC0c9c1fa7b21a: Remove GotVersion() (authored by nakihito).
Remove GotVersion()
Feb 28 2020, 02:13
nakihito closed D5344: Remove GotVersion().
Feb 28 2020, 02:12
deadalnix updated the diff for D5353: JNI: fix use sig array.

rebase

Feb 28 2020, 01:46
deadalnix accepted D5337: [automated-commits] Add update-timings.

Pulling this from teamcity would be better, but we can live with this.

Feb 28 2020, 01:45
deadalnix updated the diff for D5346: [cmake] Build bench by default.

rebase

Feb 28 2020, 01:43
deadalnix accepted D5360: Make gen-manpages.sh return non-zero if the script fails at any point.
Feb 28 2020, 01:40
deadalnix committed rABC30ed56545064: Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails. (authored by Gregory Maxwell <greg@xiph.org>).
Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails.
Feb 28 2020, 01:39
deadalnix closed D5347: Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails..
Feb 28 2020, 01:39
deadalnix committed rABCf6b2ace37ed7: Add a descriptive comment for secp256k1_ecmult_const. (authored by Gregory Maxwell <greg@xiph.org>).
Add a descriptive comment for secp256k1_ecmult_const.
Feb 28 2020, 01:38
deadalnix closed D5349: Add a descriptive comment for secp256k1_ecmult_const..
Feb 28 2020, 01:37
deadalnix committed rABC7116a8096f6b: secp256k1/src/tests.c: Properly handle sscanf return value (authored by Mustapha Abiola <mustapha@trilemma.net>).
secp256k1/src/tests.c: Properly handle sscanf return value
Feb 28 2020, 01:36
deadalnix closed D5356: secp256k1/src/tests.c: Properly handle sscanf return value.
Feb 28 2020, 01:36
nakihito accepted D5347: Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails..
Feb 28 2020, 01:34
deadalnix committed rABC30b847e3177a: Fix typo (authored by practicalswift <practicalswift@users.noreply.github.com>).
Fix typo
Feb 28 2020, 01:34
deadalnix closed D5355: Fix typo.
Feb 28 2020, 01:34
jasonbcox committed rABCe4fb108e3fde: Fix missing update to bitcoin-qt manpages (authored by jasonbcox).
Fix missing update to bitcoin-qt manpages
Feb 28 2020, 01:33
jasonbcox closed D5359: Fix missing update to bitcoin-qt manpages.
Feb 28 2020, 01:33
deadalnix committed rABC571f87cc42be: Fix typo in secp256k1_preallocated.h (authored by Jan Xie <jan.h.xie@gmail.com>).
Fix typo in secp256k1_preallocated.h
Feb 28 2020, 01:33
deadalnix closed D5351: Fix typo in secp256k1_preallocated.h.
Feb 28 2020, 01:32
teamcity added a comment to D5357: Fix a nit in the recovery tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 01:32
jasonbcox created D5360: Make gen-manpages.sh return non-zero if the script fails at any point.
Feb 28 2020, 01:32
nakihito accepted D5356: secp256k1/src/tests.c: Properly handle sscanf return value.
Feb 28 2020, 01:31
deadalnix committed rABCa326d61f584e: Make ./configure string consistent (authored by Tim Ruffing <crypto@timruffing.de>).
Make ./configure string consistent
Feb 28 2020, 01:30
deadalnix closed D5358: Make ./configure string consistent.
Feb 28 2020, 01:30
teamcity added a comment to D5355: Fix typo.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 01:29
nakihito accepted D5349: Add a descriptive comment for secp256k1_ecmult_const..
Feb 28 2020, 01:29
deadalnix committed rABC84df61acffad: [seeder] Various nits in the cmake build (authored by deadalnix).
[seeder] Various nits in the cmake build
Feb 28 2020, 01:28
deadalnix closed D5345: [seeder] Various nits in the cmake build.
Feb 28 2020, 01:28
nakihito accepted D5358: Make ./configure string consistent.
Feb 28 2020, 01:27
nakihito accepted D5351: Fix typo in secp256k1_preallocated.h.
Feb 28 2020, 01:27
deadalnix accepted D5359: Fix missing update to bitcoin-qt manpages.
Feb 28 2020, 01:26
deadalnix committed rABC7119d300be05: Fix a nit in the recovery tests (authored by Elichai Turkel <elichai.turkel@gmail.com>).
Fix a nit in the recovery tests
Feb 28 2020, 01:23
deadalnix closed D5357: Fix a nit in the recovery tests.
Feb 28 2020, 01:23
teamcity added a comment to D5358: Make ./configure string consistent.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 01:22
teamcity added a comment to D5356: secp256k1/src/tests.c: Properly handle sscanf return value.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 01:21
teamcity added a comment to D5359: Fix missing update to bitcoin-qt manpages.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 01:19
deadalnix committed rABC63a363d822d2: typo in comment for secp256k1_ec_pubkey_tweak_mul () (authored by philsmd <921533+philsmd@users.noreply.github.com>).
typo in comment for secp256k1_ec_pubkey_tweak_mul ()
Feb 28 2020, 01:17
deadalnix closed D5348: typo in comment for secp256k1_ec_pubkey_tweak_mul ().
Feb 28 2020, 01:17
deadalnix committed rABCbf4703e70a3a: scalar_impl.h: fix includes (authored by Marko Bencun <mbencun+pgp@gmail.com>).
scalar_impl.h: fix includes
Feb 28 2020, 01:15
deadalnix closed D5350: scalar_impl.h: fix includes.
Feb 28 2020, 01:14
deadalnix committed rABCf4a6d50e4e12: Moved a dereference so the null check will be before the dereferencing (authored by Elichai Turkel <elichai.turkel@gmail.com>).
Moved a dereference so the null check will be before the dereferencing
Feb 28 2020, 01:12
deadalnix closed D5352: Moved a dereference so the null check will be before the dereferencing.
Feb 28 2020, 01:12
deadalnix committed rABC181d54fa7045: Fix typo in docs for _context_set_illegal_callback (authored by Tim Ruffing <crypto@timruffing.de>).
Fix typo in docs for _context_set_illegal_callback
Feb 28 2020, 01:10
deadalnix closed D5354: Fix typo in docs for _context_set_illegal_callback.
Feb 28 2020, 01:10
nakihito accepted D5355: Fix typo.
Feb 28 2020, 01:09
teamcity added a comment to D5359: Fix missing update to bitcoin-qt manpages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 01:09
jasonbcox created D5359: Fix missing update to bitcoin-qt manpages.
Feb 28 2020, 01:09
nakihito accepted D5357: Fix a nit in the recovery tests.
Feb 28 2020, 01:09
nakihito accepted D5345: [seeder] Various nits in the cmake build.
Feb 28 2020, 01:08
teamcity added a comment to D5358: Make ./configure string consistent.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 01:06
deadalnix created D5358: Make ./configure string consistent.
Feb 28 2020, 01:06
teamcity added a comment to D5354: Fix typo in docs for _context_set_illegal_callback.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 01:05
teamcity added a comment to D5357: Fix a nit in the recovery tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 01:04
deadalnix created D5357: Fix a nit in the recovery tests.
Feb 28 2020, 01:03
teamcity added a comment to D5356: secp256k1/src/tests.c: Properly handle sscanf return value.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 01:01
teamcity added a comment to D5352: Moved a dereference so the null check will be before the dereferencing.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 01:01
deadalnix created D5356: secp256k1/src/tests.c: Properly handle sscanf return value.
Feb 28 2020, 01:01
teamcity added a comment to D5355: Fix typo.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 01:01
deadalnix created D5355: Fix typo.
Feb 28 2020, 00:59
jasonbcox accepted D5354: Fix typo in docs for _context_set_illegal_callback.
Feb 28 2020, 00:59
abc-bot committed rABC967188ad5e4e: [Automated] Update manpages (authored by abc-bot).
[Automated] Update manpages
Feb 28 2020, 00:57
jasonbcox accepted D5348: typo in comment for secp256k1_ec_pubkey_tweak_mul ().
Feb 28 2020, 00:56
nakihito accepted D5352: Moved a dereference so the null check will be before the dereferencing.
Feb 28 2020, 00:55
teamcity added a comment to D5354: Fix typo in docs for _context_set_illegal_callback.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 00:55
deadalnix created D5354: Fix typo in docs for _context_set_illegal_callback.
Feb 28 2020, 00:55
jasonbcox accepted D5350: scalar_impl.h: fix includes.
Feb 28 2020, 00:55
teamcity added a comment to D5353: JNI: fix use sig array.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 00:55
teamcity added a comment to D5350: scalar_impl.h: fix includes.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 00:54
teamcity added a comment to D5351: Fix typo in secp256k1_preallocated.h.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 00:51
teamcity added a comment to D5353: JNI: fix use sig array.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 00:45
deadalnix created D5353: JNI: fix use sig array.
Feb 28 2020, 00:45
teamcity added a comment to D5348: typo in comment for secp256k1_ec_pubkey_tweak_mul ().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 00:43
teamcity added a comment to D5349: Add a descriptive comment for secp256k1_ecmult_const..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 00:43
teamcity added a comment to D5352: Moved a dereference so the null check will be before the dereferencing.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 00:42
deadalnix created D5352: Moved a dereference so the null check will be before the dereferencing.
Feb 28 2020, 00:42
teamcity added a comment to D5351: Fix typo in secp256k1_preallocated.h.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 00:39
deadalnix created D5351: Fix typo in secp256k1_preallocated.h.
Feb 28 2020, 00:39
teamcity added a comment to D5350: scalar_impl.h: fix includes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 00:37
deadalnix created D5350: scalar_impl.h: fix includes.
Feb 28 2020, 00:37
teamcity added a comment to D5349: Add a descriptive comment for secp256k1_ecmult_const..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 00:33
deadalnix created D5349: Add a descriptive comment for secp256k1_ecmult_const..
Feb 28 2020, 00:33
teamcity added a comment to D5347: Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 00:32
teamcity added a comment to D5348: typo in comment for secp256k1_ec_pubkey_tweak_mul ().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 00:28
deadalnix created D5348: typo in comment for secp256k1_ec_pubkey_tweak_mul ().
Feb 28 2020, 00:28
teamcity added a comment to D5347: Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 00:23
deadalnix created D5347: Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails..
Feb 28 2020, 00:23
teamcity added a comment to D5346: [cmake] Build bench by default.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 00:21
teamcity added a comment to D5345: [seeder] Various nits in the cmake build.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 28 2020, 00:21
teamcity added a comment to D5346: [cmake] Build bench by default.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 00:11
deadalnix created D5346: [cmake] Build bench by default.
Feb 28 2020, 00:11
teamcity added a comment to D5345: [seeder] Various nits in the cmake build.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 28 2020, 00:04
deadalnix created D5345: [seeder] Various nits in the cmake build.
Feb 28 2020, 00:04

Feb 27 2020

deadalnix requested changes to D5339: [CMAKE] Improve FindBerkeleyDB.
Feb 27 2020, 23:41
teamcity added a comment to D5344: Remove GotVersion().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 27 2020, 23:33
majcosta committed rABCd70c6bbf1463: [backport] Qt: Replace remaining 0 with nullptr #15114 (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport] Qt: Replace remaining 0 with nullptr #15114
Feb 27 2020, 23:31
majcosta closed D5341: [backport] Qt: Replace remaining 0 with nullptr #15114.
Feb 27 2020, 23:31
deadalnix requested changes to D5333: [CMAKE] Fix build with make as a generator.
Feb 27 2020, 23:30
deadalnix added inline comments to D5333: [CMAKE] Fix build with make as a generator.
Feb 27 2020, 23:30
deadalnix added a comment to D5319: Move lcov-filter.py to cmake/utils.

It is test related, but this is not a test. IMO, you can move it somewhere down cmake/util or something like that, so that it gets exported to libsecp256k1.

Feb 27 2020, 23:27