Page MenuHomePhabricator
Feed All Stories

May 28 2020

deadalnix requested changes to D6279: Prevent -Wcast-align in sha256_shani.cpp.

I think you should create a LoadInteger128Unaligned/StoreInteger128Unaligned an limit the pragma to these functions. Mark the static and always inline and you'll be set.

May 28 2020, 14:59
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 28 2020, 14:58
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 28 2020, 14:52
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 28 2020, 14:49
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 28 2020, 14:48
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 28 2020, 14:48
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 28 2020, 14:48
Fabien updated the diff for D6279: Prevent -Wcast-align in sha256_shani.cpp.

Rebase

May 28 2020, 14:46
Fabien committed rABCfa124e895bd6: Avoid non-trivial global constants in SHA-NI code (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Avoid non-trivial global constants in SHA-NI code
May 28 2020, 14:45
Fabien closed D6278: Avoid non-trivial global constants in SHA-NI code.
May 28 2020, 14:45
Fabien committed rABCeb87697b0e40: Fix deprecated ByteSize() for protobuf >= 3.1 (authored by Fabien).
Fix deprecated ByteSize() for protobuf >= 3.1
May 28 2020, 14:45
Fabien added a reverting change for D5386: Stop using the deprecated google::protobuf::MessageLite::ByteSize(): rABCeb87697b0e40: Fix deprecated ByteSize() for protobuf >= 3.1.
May 28 2020, 14:45
Fabien closed D6275: Fix deprecated ByteSize() for protobuf >= 3.1.
May 28 2020, 14:44
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Gitian Diff Testing (win) passed.

May 28 2020, 14:31
deadalnix accepted D6275: Fix deprecated ByteSize() for protobuf >= 3.1.
May 28 2020, 14:30
deadalnix accepted D6278: Avoid non-trivial global constants in SHA-NI code.
May 28 2020, 14:29
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Gitian Diff Testing (linux) passed.

May 28 2020, 14:27
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Gitian Diff Testing (osx) passed.

May 28 2020, 14:26
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Gitian Diff Testing (win) started.

May 28 2020, 14:25
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Gitian Diff Testing (osx) started.

May 28 2020, 14:21
majcosta committed rABC861bd1645c2c: [backport#15713] Add BroadcastTransaction utility usage in Chain interface (authored by Antoine Riard <ariard@student.42.fr>).
[backport#15713] Add BroadcastTransaction utility usage in Chain interface
May 28 2020, 14:11
majcosta closed D6273: [backport#15713] Add BroadcastTransaction utility usage in Chain interface.
May 28 2020, 14:11
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 28 2020, 14:11
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Gitian Diff Testing (linux) started.

May 28 2020, 14:11
majcosta committed rABCac6a10c8b69a: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility (authored by Antoine Riard <ariard@student.42.fr>).
[backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility
May 28 2020, 14:10
majcosta closed D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.
May 28 2020, 14:10
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 28 2020, 14:06
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 28 2020, 14:03
majcosta committed rABC1250f70c3737: [backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion (authored by majcosta).
[backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion
May 28 2020, 14:01
majcosta closed D6262: [backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion.
May 28 2020, 14:01
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 28 2020, 14:01
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 28 2020, 14:01
teamcity added a comment to D6279: Prevent -Wcast-align in sha256_shani.cpp.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 28 2020, 14:01
Fabien requested review of D6279: Prevent -Wcast-align in sha256_shani.cpp.
May 28 2020, 14:00
majcosta committed rABCdc38fa1b733c: [backport#15435] Merge #15435: rpc: Add missing #include (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#15435] Merge #15435: rpc: Add missing #include
May 28 2020, 14:00
majcosta closed D6270: [backport#15435] Merge #15435: rpc: Add missing #include.
May 28 2020, 14:00
teamcity added a comment to D6278: Avoid non-trivial global constants in SHA-NI code.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 28 2020, 12:58
Fabien committed rABCe61415e7b52c: refactor: Fix implicit value conversion in formatPingTime (authored by Ben Woosley <ben.woosley@gmail.com>).
refactor: Fix implicit value conversion in formatPingTime
May 28 2020, 12:49
Fabien closed D6277: refactor: Fix implicit value conversion in formatPingTime.
May 28 2020, 12:49
Fabien committed rABC27fcccc7d329: Fix deprecated copy warning for PrecomputedTransactionData (authored by Fabien).
Fix deprecated copy warning for PrecomputedTransactionData
May 28 2020, 12:48
Fabien closed D6276: Fix deprecated copy warning for PrecomputedTransactionData.
May 28 2020, 12:48
teamcity added a comment to D6278: Avoid non-trivial global constants in SHA-NI code.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 28 2020, 12:48
Fabien committed rABCba85dd611645: Fix shadow warning (authored by Fabien).
Fix shadow warning
May 28 2020, 12:47
Fabien closed D6274: Fix shadow warning.
May 28 2020, 12:47
teamcity added a comment to D6278: Avoid non-trivial global constants in SHA-NI code.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 28 2020, 12:46
teamcity added a comment to D6278: Avoid non-trivial global constants in SHA-NI code.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 28 2020, 12:45
teamcity added a comment to D6278: Avoid non-trivial global constants in SHA-NI code.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 28 2020, 12:45
teamcity added a comment to D6278: Avoid non-trivial global constants in SHA-NI code.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 28 2020, 12:45
teamcity added a comment to D6278: Avoid non-trivial global constants in SHA-NI code.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 28 2020, 12:45
teamcity updated the summary of D6278: Avoid non-trivial global constants in SHA-NI code.
May 28 2020, 12:44
Fabien requested review of D6278: Avoid non-trivial global constants in SHA-NI code.
May 28 2020, 12:44
Fabien added inline comments to D6275: Fix deprecated ByteSize() for protobuf >= 3.1.
May 28 2020, 12:38
deadalnix added inline comments to D6275: Fix deprecated ByteSize() for protobuf >= 3.1.
May 28 2020, 12:32
deadalnix accepted D6276: Fix deprecated copy warning for PrecomputedTransactionData.
May 28 2020, 12:29
deadalnix accepted D6262: [backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion.
May 28 2020, 12:28
deadalnix accepted D6277: refactor: Fix implicit value conversion in formatPingTime.
May 28 2020, 12:28
deadalnix accepted D6274: Fix shadow warning.
May 28 2020, 12:26
teamcity added a comment to D6277: refactor: Fix implicit value conversion in formatPingTime.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 28 2020, 12:22
teamcity added a comment to D6277: refactor: Fix implicit value conversion in formatPingTime.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 28 2020, 12:17
teamcity added a comment to D6277: refactor: Fix implicit value conversion in formatPingTime.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 28 2020, 12:14
teamcity added a comment to D6277: refactor: Fix implicit value conversion in formatPingTime.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 28 2020, 12:11
teamcity added a comment to D6277: refactor: Fix implicit value conversion in formatPingTime.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 28 2020, 12:11
teamcity added a comment to D6277: refactor: Fix implicit value conversion in formatPingTime.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 28 2020, 12:11
teamcity added a comment to D6277: refactor: Fix implicit value conversion in formatPingTime.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 28 2020, 12:11
teamcity updated the summary of D6277: refactor: Fix implicit value conversion in formatPingTime.
May 28 2020, 12:11
Fabien requested review of D6277: refactor: Fix implicit value conversion in formatPingTime.
May 28 2020, 12:11
teamcity added a comment to D6276: Fix deprecated copy warning for PrecomputedTransactionData.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 28 2020, 11:27
teamcity added a comment to D6276: Fix deprecated copy warning for PrecomputedTransactionData.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 28 2020, 11:20
teamcity added a comment to D6276: Fix deprecated copy warning for PrecomputedTransactionData.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 28 2020, 11:17
teamcity added a comment to D6276: Fix deprecated copy warning for PrecomputedTransactionData.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 28 2020, 11:14
teamcity added a comment to D6276: Fix deprecated copy warning for PrecomputedTransactionData.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 28 2020, 11:14
teamcity added a comment to D6276: Fix deprecated copy warning for PrecomputedTransactionData.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 28 2020, 11:14
Fabien requested review of D6276: Fix deprecated copy warning for PrecomputedTransactionData.
May 28 2020, 11:14
teamcity added a comment to D6275: Fix deprecated ByteSize() for protobuf >= 3.1.

Build Bitcoin ABC Diffs / Gitian Diff Testing (linux) passed.

May 28 2020, 10:23
teamcity added a comment to D6275: Fix deprecated ByteSize() for protobuf >= 3.1.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 28 2020, 10:17
teamcity added a comment to D6275: Fix deprecated ByteSize() for protobuf >= 3.1.

Build Bitcoin ABC Diffs / Gitian Diff Testing (win) passed.

May 28 2020, 10:13
teamcity added a comment to D6275: Fix deprecated ByteSize() for protobuf >= 3.1.

Build Bitcoin ABC Diffs / Gitian Diff Testing (osx) passed.

May 28 2020, 10:10
teamcity added a comment to D6275: Fix deprecated ByteSize() for protobuf >= 3.1.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 28 2020, 10:08
teamcity added a comment to D6275: Fix deprecated ByteSize() for protobuf >= 3.1.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 28 2020, 10:06
teamcity added a comment to D6275: Fix deprecated ByteSize() for protobuf >= 3.1.

Build Bitcoin ABC Diffs / Gitian Diff Testing (win) started.

May 28 2020, 10:05
teamcity added a comment to D6275: Fix deprecated ByteSize() for protobuf >= 3.1.

Build Bitcoin ABC Diffs / Gitian Diff Testing (osx) started.

May 28 2020, 10:05
teamcity added a comment to D6275: Fix deprecated ByteSize() for protobuf >= 3.1.

Build Bitcoin ABC Diffs / Gitian Diff Testing (linux) started.

May 28 2020, 10:05
teamcity added a comment to D6275: Fix deprecated ByteSize() for protobuf >= 3.1.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 28 2020, 10:05
teamcity added a comment to D6275: Fix deprecated ByteSize() for protobuf >= 3.1.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 28 2020, 10:05
teamcity added a comment to D6275: Fix deprecated ByteSize() for protobuf >= 3.1.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 28 2020, 10:05
Fabien requested review of D6275: Fix deprecated ByteSize() for protobuf >= 3.1.
May 28 2020, 10:04
Fabien added a reverting change for D5386: Stop using the deprecated google::protobuf::MessageLite::ByteSize(): D6275: Fix deprecated ByteSize() for protobuf >= 3.1.
May 28 2020, 10:04
teamcity added a comment to D6274: Fix shadow warning.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 28 2020, 09:21
teamcity added a comment to D6274: Fix shadow warning.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 28 2020, 09:13
teamcity added a comment to D6274: Fix shadow warning.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 28 2020, 09:10
teamcity added a comment to D6274: Fix shadow warning.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 28 2020, 09:08
teamcity added a comment to D6274: Fix shadow warning.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 28 2020, 09:08
teamcity added a comment to D6274: Fix shadow warning.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 28 2020, 09:08
Fabien requested review of D6274: Fix shadow warning.
May 28 2020, 09:07
Fabien accepted D6273: [backport#15713] Add BroadcastTransaction utility usage in Chain interface.
May 28 2020, 08:34
Fabien accepted D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.
May 28 2020, 08:16
Fabien accepted D6270: [backport#15435] Merge #15435: rpc: Add missing #include.

It's fantastic to see a diff entitled Add missing #include which only removes an #include :)

May 28 2020, 08:10
abc-bot committed rABC73dde8a964f7: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
May 28 2020, 03:09
teamcity closed T906: Build Bitcoin-ABC / Master / Health Checks / Bitcoin-ABC Check Seeds is broken. as Resolved.
May 28 2020, 03:03
abc-bot committed rABCe7fb8a3440b9: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
May 28 2020, 02:11