Page MenuHomePhabricator
Feed All Stories

Jul 15 2020

teamcity added a comment to D6947: [backport#17051] tests: Add deserialization fuzzing harnesses.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 15 2020, 20:57
teamcity updated the summary of D6947: [backport#17051] tests: Add deserialization fuzzing harnesses.
Jul 15 2020, 20:57
majcosta requested review of D6947: [backport#17051] tests: Add deserialization fuzzing harnesses.
Jul 15 2020, 20:57
Fabien accepted D6946: Add doc.bitcoinabc.org to the nav bar.
Jul 15 2020, 20:13
Fabien accepted D6943: Add Doxyfile to build-master artifacts.
Jul 15 2020, 20:12
jasonbcox requested review of D6946: Add doc.bitcoinabc.org to the nav bar.
Jul 15 2020, 20:04
teamcity updated the summary of D6945: [backport#17136] tests: Add fuzzing harness for various PSBT related functions.
Jul 15 2020, 19:56
teamcity added a comment to D6945: [backport#17136] tests: Add fuzzing harness for various PSBT related functions.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 15 2020, 19:56
majcosta requested review of D6945: [backport#17136] tests: Add fuzzing harness for various PSBT related functions.
Jul 15 2020, 19:56
jasonbcox requested review of D6943: Add Doxyfile to build-master artifacts.
Jul 15 2020, 19:30
teamcity added a comment to D6940: [backport#15971] validation: Add compile-time checking for negative locking requirement in LimitValidationInterfaceQueue.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 15 2020, 18:05
teamcity updated the summary of D6940: [backport#15971] validation: Add compile-time checking for negative locking requirement in LimitValidationInterfaceQueue.
Jul 15 2020, 18:05
majcosta requested review of D6940: [backport#15971] validation: Add compile-time checking for negative locking requirement in LimitValidationInterfaceQueue.
Jul 15 2020, 18:05
jasonbcox committed rABC5c15a59e352b: Install base-devel by default for the example Arch Linux build in build-unix.md (authored by jasonbcox).
Install base-devel by default for the example Arch Linux build in build-unix.md
Jul 15 2020, 17:41
jasonbcox closed D6931: Install base-devel by default for the example Arch Linux build in build-unix.md.
Jul 15 2020, 17:41
Fabien accepted D6931: Install base-devel by default for the example Arch Linux build in build-unix.md.
Jul 15 2020, 17:25
Fabien committed rABCc16e18621ac8: Use ninja for the debian packages build (authored by Fabien).
Use ninja for the debian packages build
Jul 15 2020, 17:15
Fabien closed D6934: Use ninja for the debian packages build.
Jul 15 2020, 17:15
jasonbcox retitled D6931: Install base-devel by default for the example Arch Linux build in build-unix.md from Install clang by default for the example Arch Linux build in build-unix.md to Install base-devel by default for the example Arch Linux build in build-unix.md.
Jul 15 2020, 16:51
jasonbcox updated the diff for D6931: Install base-devel by default for the example Arch Linux build in build-unix.md.

Install base-devel instead of clang

Jul 15 2020, 16:51
jasonbcox committed rABC80b9a642cecb: Disable optional Jemalloc for the example Arch Linux build in build-unix.md (authored by jasonbcox).
Disable optional Jemalloc for the example Arch Linux build in build-unix.md
Jul 15 2020, 16:46
jasonbcox closed D6933: Disable optional Jemalloc for the example Arch Linux build in build-unix.md.
Jul 15 2020, 16:46
jasonbcox committed rABC1aaffa457bbf: Add --distro flag to PPA release script (authored by jasonbcox).
Add --distro flag to PPA release script
Jul 15 2020, 16:46
jasonbcox closed D6928: Add --distro flag to PPA release script.
Jul 15 2020, 16:45
majcosta updated the diff for D6906: [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding.

used fuzzed input for the prefix as well, that increased coverage a bit

Jul 15 2020, 15:37
majcosta committed rABCfddb00fc8ce1: [backport#10953] [Refactor] Combine scriptPubKey and amount as CTxOut in… (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[backport#10953] [Refactor] Combine scriptPubKey and amount as CTxOut in…
Jul 15 2020, 14:52
majcosta closed D6932: [backport#10953] [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck.
Jul 15 2020, 14:52
Fabien committed rABC5153554d3e7d: [GITIAN] Make the setup feature from gitian-build.py create a debian VM (authored by Fabien).
[GITIAN] Make the setup feature from gitian-build.py create a debian VM
Jul 15 2020, 14:36
Fabien closed D6935: [GITIAN] Make the setup feature from gitian-build.py create a debian VM.
Jul 15 2020, 14:36
deadalnix accepted D6935: [GITIAN] Make the setup feature from gitian-build.py create a debian VM.
Jul 15 2020, 14:25
deadalnix accepted D6934: Use ninja for the debian packages build.
Jul 15 2020, 14:24
Fabien requested review of D6935: [GITIAN] Make the setup feature from gitian-build.py create a debian VM.
Jul 15 2020, 14:08
Fabien requested review of D6934: Use ninja for the debian packages build.
Jul 15 2020, 13:29
kevinjohnson edited a custom field on kevinjohnson.
Jul 15 2020, 07:32
Fabien requested changes to D6931: Install base-devel by default for the example Arch Linux build in build-unix.md.

Use the development meta group instead: base-devel. This is somewhat the equivalent for the Debian build-essential and should already be installed on most Arch boxes.

Jul 15 2020, 07:05
Fabien accepted D6932: [backport#10953] [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck.
Jul 15 2020, 07:00
Fabien accepted D6928: Add --distro flag to PPA release script.
Jul 15 2020, 06:49
Fabien accepted D6933: Disable optional Jemalloc for the example Arch Linux build in build-unix.md.
Jul 15 2020, 06:45
jasonbcox committed rABC1a1cf51fa914: Use cat to output help text in PPA release script (authored by jasonbcox).
Use cat to output help text in PPA release script
Jul 15 2020, 00:05
jasonbcox closed D6927: Use cat to output help text in PPA release script.
Jul 15 2020, 00:05

Jul 14 2020

jasonbcox requested review of D6933: Disable optional Jemalloc for the example Arch Linux build in build-unix.md.
Jul 14 2020, 22:08
teamcity added a comment to D6932: [backport#10953] [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 14 2020, 22:07
teamcity updated the summary of D6932: [backport#10953] [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck.
Jul 14 2020, 22:07
majcosta requested review of D6932: [backport#10953] [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck.
Jul 14 2020, 22:07
jasonbcox requested review of D6931: Install base-devel by default for the example Arch Linux build in build-unix.md.
Jul 14 2020, 22:05
majcosta accepted D6927: Use cat to output help text in PPA release script.
Jul 14 2020, 21:11
jasonbcox committed rABCc3bbc613c4b6: Refactor FormatStateMessage() to better match Core (authored by jasonbcox).
Refactor FormatStateMessage() to better match Core
Jul 14 2020, 21:06
jasonbcox closed D6862: Refactor FormatStateMessage() to better match Core.
Jul 14 2020, 21:06
jasonbcox committed rABC5ee3ff23f524: Bump version to 0.21.12 (authored by jasonbcox).
Bump version to 0.21.12
Jul 14 2020, 21:01
jasonbcox closed D6926: Bump version to 0.21.12.
Jul 14 2020, 21:01
jasonbcox committed rABC0704a943d9a8: Merge #15921: validation: Tidy up ValidationState interface (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #15921: validation: Tidy up ValidationState interface
Jul 14 2020, 20:51
jasonbcox closed D6860: Merge #15921: validation: Tidy up ValidationState interface.
Jul 14 2020, 20:51
jasonbcox committed rABC848640a7a499: Merge #17746: refactor: rpc: Remove vector copy from listtransactions (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #17746: refactor: rpc: Remove vector copy from listtransactions
Jul 14 2020, 20:45
jasonbcox closed D6930: Merge #17746: refactor: rpc: Remove vector copy from listtransactions.
Jul 14 2020, 20:45
deadalnix accepted D6926: Bump version to 0.21.12.
Jul 14 2020, 20:31
jasonbcox committed rABC98ae0278f748: Fix uninitialized variable caught by cppcheck (authored by jasonbcox).
Fix uninitialized variable caught by cppcheck
Jul 14 2020, 20:22
jasonbcox closed D6929: Fix uninitialized variable caught by cppcheck.
Jul 14 2020, 20:22
majcosta accepted D6930: Merge #17746: refactor: rpc: Remove vector copy from listtransactions.
Jul 14 2020, 20:10
majcosta accepted D6929: Fix uninitialized variable caught by cppcheck.
Jul 14 2020, 20:08
jasonbcox updated the summary of D6860: Merge #15921: validation: Tidy up ValidationState interface.
Jul 14 2020, 18:09
jasonbcox updated the diff for D6860: Merge #15921: validation: Tidy up ValidationState interface.

Rebase on linter fixes...

Jul 14 2020, 18:08
teamcity updated the summary of D6930: Merge #17746: refactor: rpc: Remove vector copy from listtransactions.
Jul 14 2020, 18:07
teamcity added a comment to D6930: Merge #17746: refactor: rpc: Remove vector copy from listtransactions.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 14 2020, 18:07
jasonbcox requested review of D6930: Merge #17746: refactor: rpc: Remove vector copy from listtransactions.
Jul 14 2020, 18:06
jasonbcox requested review of D6929: Fix uninitialized variable caught by cppcheck.
Jul 14 2020, 17:56
jasonbcox requested review of D6928: Add --distro flag to PPA release script.
Jul 14 2020, 17:35
jasonbcox requested review of D6927: Use cat to output help text in PPA release script.
Jul 14 2020, 17:09
jasonbcox requested review of D6926: Bump version to 0.21.12.
Jul 14 2020, 16:56
deadalnix accepted D6860: Merge #15921: validation: Tidy up ValidationState interface.
Jul 14 2020, 14:31
majcosta committed rABCf432e7ff62d3: [refactor] refactor FinalizeBlockAndInvalidate (authored by majcosta).
[refactor] refactor FinalizeBlockAndInvalidate
Jul 14 2020, 01:44
majcosta closed D6861: [refactor] refactor FinalizeBlockAndInvalidate.
Jul 14 2020, 01:43
deadalnix accepted D6861: [refactor] refactor FinalizeBlockAndInvalidate.
Jul 14 2020, 00:28
teamcity closed T993: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Jul 14 2020, 00:06
jasonbcox committed rABC19491d131486: [land-bot] Pass committer name/email to land bot endpoint (authored by jasonbcox).
[land-bot] Pass committer name/email to land bot endpoint
Jul 14 2020, 00:01
jasonbcox closed D6799: [land-bot] Pass committer name/email to land bot endpoint.
Jul 14 2020, 00:01

Jul 13 2020

jasonbcox committed rABC99589edae440: [validation] Remove fMissingInputs from AcceptToMemoryPool() (authored by John Newbery <john@johnnewbery.com>).
[validation] Remove fMissingInputs from AcceptToMemoryPool()
Jul 13 2020, 23:39
jasonbcox closed D6923: [validation] Remove fMissingInputs from AcceptToMemoryPool().
Jul 13 2020, 23:39
jasonbcox updated the summary of D6860: Merge #15921: validation: Tidy up ValidationState interface.
Jul 13 2020, 23:37
jasonbcox updated the diff for D6860: Merge #15921: validation: Tidy up ValidationState interface.

Rebased on the partial backports. This patch should only be the remaining
changes directly related to ValidationState.

Jul 13 2020, 23:37
majcosta updated the diff for D6861: [refactor] refactor FinalizeBlockAndInvalidate.

missed a few callsites, fixed a log output to point to the right place

Jul 13 2020, 23:35
majcosta planned changes to D6861: [refactor] refactor FinalizeBlockAndInvalidate.
Jul 13 2020, 23:30
majcosta updated the diff for D6861: [refactor] refactor FinalizeBlockAndInvalidate.

Hm, since the private function set the CChainState pointer for the finalized block, it's more fitting for it to get the "Mark" name. The public facing API should be FinalizeBlock then

Jul 13 2020, 23:29
deadalnix requested changes to D6861: [refactor] refactor FinalizeBlockAndInvalidate.

Simple name change are required, but otherwise, it looks good.

Jul 13 2020, 22:13
majcosta updated the diff for D6861: [refactor] refactor FinalizeBlockAndInvalidate.

now that FinalizeBlockInternal is a private member of CChainState and has its own declaration, the lock annotation can go there instead of its definition

Jul 13 2020, 21:18
majcosta planned changes to D6861: [refactor] refactor FinalizeBlockAndInvalidate.

missed a spurious EXCLUSIVE_LOCKS_REQUIRED on CChainState::FinalizeBlock definition

Jul 13 2020, 21:03
majcosta updated the diff for D6861: [refactor] refactor FinalizeBlockAndInvalidate.

It appears I have gotten ahead of myself and overcomplicated this diff. The previous diff changed behavior in a way that isn't needed until https://github.com/bitcoin/bitcoin/pull/15971. That one comes next and will incorporate the feedback given so far.

Jul 13 2020, 20:57
deadalnix committed rABC454b88ccaea6: [avalanche] Add buildavalanchproof RPC call (authored by deadalnix).
[avalanche] Add buildavalanchproof RPC call
Jul 13 2020, 19:40
deadalnix closed D6914: [avalanche] Add buildavalanchproof RPC call.
Jul 13 2020, 19:39
majcosta committed rABCefd365b98e8a: [backport#17291] tests: Add fuzzing harness for ISO-8601 related functions (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#17291] tests: Add fuzzing harness for ISO-8601 related functions
Jul 13 2020, 19:11
majcosta closed D6898: [backport#17291] tests: Add fuzzing harness for ISO-8601 related functions.
Jul 13 2020, 19:10
majcosta committed rABCc1d515d3d0f6: [backport#17083] tests: Add fuzzing harness for various CScript related… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#17083] tests: Add fuzzing harness for various CScript related…
Jul 13 2020, 19:08
majcosta closed D6896: [backport#17083] tests: Add fuzzing harness for various CScript related functions.
Jul 13 2020, 19:08
Fabien accepted D6923: [validation] Remove fMissingInputs from AcceptToMemoryPool().
Jul 13 2020, 18:53
deadalnix committed rABC228156f14092: [avalanche] Do not add invalid proof in PeerManager (authored by deadalnix).
[avalanche] Do not add invalid proof in PeerManager
Jul 13 2020, 18:46
deadalnix closed D6922: [avalanche] Do not add invalid proof in PeerManager.
Jul 13 2020, 18:46
Fabien accepted D6922: [avalanche] Do not add invalid proof in PeerManager.
Jul 13 2020, 18:40
Fabien accepted D6914: [avalanche] Add buildavalanchproof RPC call.
Jul 13 2020, 18:31
Fabien accepted D6799: [land-bot] Pass committer name/email to land bot endpoint.
Jul 13 2020, 18:30
teamcity added a comment to D6923: [validation] Remove fMissingInputs from AcceptToMemoryPool().

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 13 2020, 18:28
teamcity updated the summary of D6923: [validation] Remove fMissingInputs from AcceptToMemoryPool().
Jul 13 2020, 18:28