Page MenuHomePhabricator
Feed All Stories

May 19 2021

bytesofman requested review of D9555: [Cashtab] Reduce default fee.
May 19 2021, 12:58
PiRK updated the diff for D9509: [avalanche] Send the proof master pubkey with AVAHELLO.

pass a limited proof id to Delegation::verify instead of the already computed proofid, and refactor the code that generates a proofid from a limited id to avoid code duplication.

May 19 2021, 12:52
Fabien updated the diff for D9548: Add txrequest unit tests.

Fix a couple nits in names

May 19 2021, 12:04
PiRK added inline comments to D9548: Add txrequest unit tests.
May 19 2021, 10:36
teamcity updated the summary of D9554: Report and verify expirations.
May 19 2021, 09:23
Fabien requested review of D9554: Report and verify expirations.
May 19 2021, 09:23
teamcity updated the summary of D9553: Delete limitedmap as it is unused now.
May 19 2021, 09:07
Fabien requested review of D9553: Delete limitedmap as it is unused now.
May 19 2021, 09:07
Fabien updated the summary of D9552: Expedite removal of tx requests that are no longer needed.
May 19 2021, 09:02
teamcity updated the summary of D9552: Expedite removal of tx requests that are no longer needed.
May 19 2021, 09:02
Fabien requested review of D9552: Expedite removal of tx requests that are no longer needed.
May 19 2021, 09:02
teamcity updated the summary of D9551: Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers.
May 19 2021, 08:55
Fabien requested review of D9551: Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers.
May 19 2021, 08:55
teamcity updated the summary of D9550: Change transaction request logic to use txrequest.
May 19 2021, 08:36
Fabien requested review of D9550: Change transaction request logic to use txrequest.
May 19 2021, 08:36

May 18 2021

deadalnix requested changes to D9509: [avalanche] Send the proof master pubkey with AVAHELLO.
May 18 2021, 20:46
deadalnix accepted D9544: [avalanche] introduce LimitedProofId.
May 18 2021, 20:44
teamcity closed T1618: Build Bitcoin-ABC / Master / Coverage is broken. as Resolved.
May 18 2021, 19:54
teamcity closed T1617: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
May 18 2021, 19:16
Fabien closed D9546: test: Check that peers with forcerelay permission are not asked to feefilter.
May 18 2021, 18:53
Fabien committed rABCac3faaf599b6: test: Check that peers with forcerelay permission are not asked to feefilter (authored by MarcoFalke <falke.marco@gmail.com>).
test: Check that peers with forcerelay permission are not asked to feefilter
May 18 2021, 18:53
PiRK accepted D9546: test: Check that peers with forcerelay permission are not asked to feefilter.
May 18 2021, 18:42
jasonbcox closed D9541: Fix a race in abc_mining_basic.
May 18 2021, 17:47
jasonbcox committed rABC1c5084bfe3aa: Fix a race in abc_mining_basic (authored by jasonbcox).
Fix a race in abc_mining_basic
May 18 2021, 17:47
PiRK updated the summary of D9509: [avalanche] Send the proof master pubkey with AVAHELLO.
May 18 2021, 16:12
PiRK updated the summary of D9509: [avalanche] Send the proof master pubkey with AVAHELLO.
May 18 2021, 16:12
PiRK updated the diff for D9509: [avalanche] Send the proof master pubkey with AVAHELLO.

Rebase on D9544

May 18 2021, 16:08
teamcity updated the summary of D9549: Add txrequest fuzz tests.
May 18 2021, 15:32
Fabien requested review of D9549: Add txrequest fuzz tests.
May 18 2021, 15:32
teamcity updated the summary of D9548: Add txrequest unit tests.
May 18 2021, 15:29
Fabien requested review of D9548: Add txrequest unit tests.
May 18 2021, 15:29
majcosta abandoned D9540: [backport#19988 5/9] Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers.
May 18 2021, 15:25
majcosta abandoned D9539: [backport#19988 4/9] Change transaction request logic to use txrequest.
May 18 2021, 15:24
majcosta abandoned D9538: [backport#19988 3/9] Add txrequest fuzz tests.
May 18 2021, 15:24
majcosta abandoned D9537: [backport#19988 2/9] Add txrequest unit tests.
May 18 2021, 15:24
majcosta abandoned D9536: [backport#19988 1/9] Add txrequest module.

already done D9547

May 18 2021, 15:23
teamcity updated the summary of D9547: Add txrequest module.
May 18 2021, 15:22
Fabien requested review of D9547: Add txrequest module.
May 18 2021, 15:22
Fabien added a comment to D9546: test: Check that peers with forcerelay permission are not asked to feefilter.

Unrelated failure, restarting the build.

May 18 2021, 15:03
teamcity added a comment to D9546: test: Check that peers with forcerelay permission are not asked to feefilter.
May 18 2021, 14:52
teamcity updated the summary of D9546: test: Check that peers with forcerelay permission are not asked to feefilter.
May 18 2021, 14:41
Fabien requested review of D9546: test: Check that peers with forcerelay permission are not asked to feefilter.
May 18 2021, 14:41
teamcity triaged T1618: Build Bitcoin-ABC / Master / Coverage is broken. as Unbreak Now! priority.
May 18 2021, 14:27
PiRK abandoned D9497: [avalanche] enforce at least one delegation level in avahello.
May 18 2021, 14:08
PiRK updated the diff for D9544: [avalanche] introduce LimitedProofId.

avoid computing the limited proofid twice

May 18 2021, 14:05
teamcity triaged T1617: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
May 18 2021, 13:59
teamcity closed T1616: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Resolved.
May 18 2021, 13:48
teamcity triaged T1616: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Unbreak Now! priority.
May 18 2021, 13:37
Fabien closed D9542: Use mockable time everywhere in net_processing.
May 18 2021, 13:30
Fabien committed rABC6f09bb224dc6: Use mockable time everywhere in net_processing (authored by Pieter Wuille <pieter@wuille.net>).
Use mockable time everywhere in net_processing
May 18 2021, 13:30
PiRK added a comment to D9543: [avalanche] change how the proof id is computed.

The proofs with expected invalid signatures did not need to be recomputed, only their ID changed. But for the valid ones I needed to know all the private keys for each UTXO to be able to recompute the signatures.
And then there are a bunch of tests that are derived from the valid proof, to show that the proof id changes if a parameter is changed.

May 18 2021, 13:30
Fabien closed D9545: Bump version to 0.23.5.
May 18 2021, 13:28
Fabien committed rABC066a92985e67: Bump version to 0.23.5 (authored by Fabien).
Bump version to 0.23.5
May 18 2021, 13:28
deadalnix accepted D9542: Use mockable time everywhere in net_processing.
May 18 2021, 13:22
deadalnix requested changes to D9543: [avalanche] change how the proof id is computed.

Can you explain why so many things need to be fully recomputed?

May 18 2021, 13:21
deadalnix requested changes to D9544: [avalanche] introduce LimitedProofId.
May 18 2021, 13:14
deadalnix accepted D9545: Bump version to 0.23.5.
May 18 2021, 13:12
Fabien requested review of D9545: Bump version to 0.23.5.
May 18 2021, 11:36
teamcity closed T1615: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Resolved.
May 18 2021, 11:25
PiRK updated the diff for D9544: [avalanche] introduce LimitedProofId.

ss2 -> ss

May 18 2021, 10:55
PiRK closed D9527: [avalanche] remove proof details from getavalanchepeerinfo RPC.
May 18 2021, 10:47
PiRK committed rABC5fa3c6e67e43: [avalanche] remove proof details from getavalanchepeerinfo RPC (authored by PiRK).
[avalanche] remove proof details from getavalanchepeerinfo RPC
May 18 2021, 10:47
PiRK closed D9526: [avalanche] add a decodeavalancheproof RPC.
May 18 2021, 10:46
PiRK committed rABC7a6b18076c65: [avalanche] add a decodeavalancheproof RPC (authored by PiRK).
[avalanche] add a decodeavalancheproof RPC
May 18 2021, 10:46
PiRK requested review of D9544: [avalanche] introduce LimitedProofId.
May 18 2021, 10:40
PiRK requested review of D9543: [avalanche] change how the proof id is computed.
May 18 2021, 10:18
teamcity updated the summary of D9542: Use mockable time everywhere in net_processing.
May 18 2021, 10:11
Fabien requested review of D9542: Use mockable time everywhere in net_processing.
May 18 2021, 10:10
• rickymatin updated • rickymatin.
May 18 2021, 09:11
Fabien accepted D9526: [avalanche] add a decodeavalancheproof RPC.
May 18 2021, 07:09
• Mann123 added a comment to D9482: remove misleading comment.
May 18 2021, 06:59
PiRK updated the diff for D9526: [avalanche] add a decodeavalancheproof RPC.

show the signature in base64, cast vout in uint64_t

May 18 2021, 06:10

May 17 2021

deadalnix accepted D9541: Fix a race in abc_mining_basic.
May 17 2021, 22:29
jasonbcox requested review of D9541: Fix a race in abc_mining_basic.
May 17 2021, 18:25
teamcity added a comment to D9540: [backport#19988 5/9] Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers.
May 17 2021, 18:09
teamcity added a comment to D9540: [backport#19988 5/9] Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers.
May 17 2021, 18:08
teamcity added a comment to D9540: [backport#19988 5/9] Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers.
May 17 2021, 18:07
teamcity added a comment to D9539: [backport#19988 4/9] Change transaction request logic to use txrequest.
May 17 2021, 18:06
teamcity added a comment to D9539: [backport#19988 4/9] Change transaction request logic to use txrequest.
May 17 2021, 18:05
teamcity added a comment to D9539: [backport#19988 4/9] Change transaction request logic to use txrequest.
May 17 2021, 18:05
teamcity added a comment to D9538: [backport#19988 3/9] Add txrequest fuzz tests.
May 17 2021, 18:03
majcosta planned changes to D9537: [backport#19988 2/9] Add txrequest unit tests.
May 17 2021, 18:03
majcosta planned changes to D9538: [backport#19988 3/9] Add txrequest fuzz tests.
May 17 2021, 18:03
majcosta planned changes to D9539: [backport#19988 4/9] Change transaction request logic to use txrequest.
May 17 2021, 18:02
teamcity added a comment to D9538: [backport#19988 3/9] Add txrequest fuzz tests.
May 17 2021, 18:02
majcosta planned changes to D9540: [backport#19988 5/9] Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers.
May 17 2021, 18:02
majcosta planned changes to D9536: [backport#19988 1/9] Add txrequest module.
May 17 2021, 18:01
teamcity added a comment to D9538: [backport#19988 3/9] Add txrequest fuzz tests.
May 17 2021, 18:01
teamcity updated the summary of D9540: [backport#19988 5/9] Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers.
May 17 2021, 17:59
majcosta requested review of D9540: [backport#19988 5/9] Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers.
May 17 2021, 17:59
teamcity updated the summary of D9539: [backport#19988 4/9] Change transaction request logic to use txrequest.
May 17 2021, 17:58
teamcity added a comment to D9537: [backport#19988 2/9] Add txrequest unit tests.
May 17 2021, 17:58
majcosta requested review of D9539: [backport#19988 4/9] Change transaction request logic to use txrequest.
May 17 2021, 17:58
teamcity added a comment to D9537: [backport#19988 2/9] Add txrequest unit tests.
May 17 2021, 17:57
teamcity updated the summary of D9538: [backport#19988 3/9] Add txrequest fuzz tests.
May 17 2021, 17:57
teamcity added a comment to D9537: [backport#19988 2/9] Add txrequest unit tests.
May 17 2021, 17:56
majcosta requested review of D9538: [backport#19988 3/9] Add txrequest fuzz tests.
May 17 2021, 17:56
teamcity added a comment to D9536: [backport#19988 1/9] Add txrequest module.
May 17 2021, 17:55
teamcity added a comment to D9536: [backport#19988 1/9] Add txrequest module.
May 17 2021, 17:55
teamcity added a comment to D9536: [backport#19988 1/9] Add txrequest module.
May 17 2021, 17:55