Feed All Stories
Nov 10 2023
Nov 10 2023
Mengerian committed rABCb342fba9440b: [e.cash] Rename CustomLink to ExternalLink (authored by Mengerian).
[e.cash] Rename CustomLink to ExternalLink
teamcity updated the summary of D14772: net, refactor: Rename CNetMessage::m_command with CNetMessage::m_type.
PiRK requested review of D14772: net, refactor: Rename CNetMessage::m_command with CNetMessage::m_type.
teamcity updated the summary of D14771: Rename and move PoissonNextSend functions.
PiRK requested review of D14771: Rename and move PoissonNextSend functions.
Fabien requested review of D14770: [CI] Unbreak the win64 build.
teamcity awarded D14770: [CI] Unbreak the win64 build a Piece of Eight token.
teamcity awarded D14770: [CI] Unbreak the win64 build a Haypence token.
Fabien planned changes to D14770: [CI] Unbreak the win64 build.
Let's see if the CI agrees with my machine
Fabien requested review of D14770: [CI] Unbreak the win64 build.
Fabien requested changes to D14766: [chronik-client] Improve websocket failover proxy.
teamcity updated the summary of D14769: More Span simplifications.
PiRK requested review of D14769: More Span simplifications.
teamcity updated the summary of D14768: Replace MakeSpan helper with Span deduction guide.
PiRK requested review of D14768: Replace MakeSpan helper with Span deduction guide.
Fabien requested review of D14767: Remove some debug leftover from D14614.
bytesofman added inline comments to D14766: [chronik-client] Improve websocket failover proxy.
bytesofman updated the diff for D14766: [chronik-client] Improve websocket failover proxy.
better code commenting, variable naming
bytesofman updated the diff for D14766: [chronik-client] Improve websocket failover proxy.
remove unnecessary break
bytesofman requested review of D14766: [chronik-client] Improve websocket failover proxy.
PiRK committed rABC21da021453b0: [electrum] log: only log in verbose mode in CachedWalletPasswordWidget (authored by PiRK).
[electrum] log: only log in verbose mode in CachedWalletPasswordWidget
PiRK committed rABC7641cb827d03: [electrum] bump version to 5.2.9 and add release notes (authored by PiRK).
[electrum] bump version to 5.2.9 and add release notes
Thanks, much better
PiRK requested review of D14765: [electrum] log: only log in verbose mode in CachedWalletPasswordWidget.
PiRK requested review of D14764: [electrum] bump version to 5.2.9 and add release notes.
Nov 9 2023
Nov 9 2023
Mengerian requested review of D14763: [e.cash] Rename CustomLink to ExternalLink.
Mengerian requested review of D14762: [e.cash] Add staking page.
PiRK committed rABCdcf5792b97bd: [electrum] implement removal of coins in the proof editor (authored by PiRK).
[electrum] implement removal of coins in the proof editor
PiRK committed rABCe8e8b8986550: [electrum] refactor: extract stakes widget from proof editor (authored by PiRK).
[electrum] refactor: extract stakes widget from proof editor
PiRK updated the diff for D14761: [electrum] implement removal of coins in the proof editor.
export the icon as plain svg with Inkscape, check that the license metadata is preserved and the resulting file is a lot more compact.
PiRK planned changes to D14761: [electrum] implement removal of coins in the proof editor.
the svg obviously need some optimization, 140 kB for a red cross is a bit excessive
PiRK requested review of D14761: [electrum] implement removal of coins in the proof editor.
• assetplus updated • assetplus.
PiRK updated the summary of D14760: [electrum] refactor: extract stakes widget from proof editor.
PiRK requested review of D14760: [electrum] refactor: extract stakes widget from proof editor.
Fabien requested changes to D14728: [Cashtab][Alias] Sync pricing on new blocks.
This is just wrong. You're not using the correct price.
PiRK committed rABCdeaad9c4ff71: [net_processing] fix compact block related comment (authored by PiRK).
[net_processing] fix compact block related comment
PiRK committed rABCc0c2c145abf7: [net processing] Dont request compact blocks in blocks-only mode (authored by Niklas Gögge <n.goeggi@gmail.com>).
[net processing] Dont request compact blocks in blocks-only mode
teamcity added a comment to D14751: [CI] Fix the Win64 build failing due to wine issue.
Build Bitcoin ABC Diffs / Diff Testing (build-win64) failed.
teamcity awarded D14751: [CI] Fix the Win64 build failing due to wine issue a Piece of Eight token.
PiRK added a comment to D14751: [CI] Fix the Win64 build failing due to wine issue.
@bot build-win64
teamcity added a comment to D14755: fuzz: Check for addrv1 compatibility before using serializers.
Build Bitcoin ABC Diffs / Diff Testing (build-win64) failed.
emack planned changes to D14759: [Cashtab][Swap] ChangeNow integration.
Reaching out to the ChangeNow team on this. Potentially because local dev cashtab is accessed via http and there may be policies mandating https sources.
emack updated the summary of D14759: [Cashtab][Swap] ChangeNow integration.
emack requested review of D14759: [Cashtab][Swap] ChangeNow integration.
teamcity awarded D14755: fuzz: Check for addrv1 compatibility before using serializers a Haypence token.
PiRK added a comment to D14755: fuzz: Check for addrv1 compatibility before using serializers.
@bot build-win64
emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.
Removed debug logs
bytesofman committed rABC7e6681f098c7: [Cashtab] Add function to generate an OP_RETURN output for an airdrop tx (authored by bytesofman).
[Cashtab] Add function to generate an OP_RETURN output for an airdrop tx
bytesofman planned changes to D14758: [chronik-client] [DRAFT] Support in-node chronik.
- need to fix the websocket mgmt in failover proxy
- better file organization, total nightmare dealing with two "kinda the same except very different in certain ways" classes that interact with these servers ... imo keeping them siloed is the best way to do it, but it's almost worth just having a separate library
bytesofman updated the diff for D14758: [chronik-client] [DRAFT] Support in-node chronik.
rebase
Nov 8 2023
Nov 8 2023
emack committed rABC8b10270ebb71: [Cashtab][Swap] Add swap component with SideShift integration (authored by emack).
[Cashtab][Swap] Add swap component with SideShift integration
emack updated the diff for D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Updated nit
emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.
Removed aliasFee state far and updated component to access directly from the aliasPrices object
bytesofman requested changes to D14728: [Cashtab][Alias] Sync pricing on new blocks.
calling 'accepted' as requested change is more of a nit
bytesofman requested changes to D14708: [Cashtab][Swap] Add swap component with SideShift integration.
bytesofman added a comment to D14758: [chronik-client] [DRAFT] Support in-node chronik.
sample output from websocket subscribed to blocks and a single address:
bytesofman planned changes to D14758: [chronik-client] [DRAFT] Support in-node chronik.
to be rebased on latest master
bytesofman requested review of D14758: [chronik-client] [DRAFT] Support in-node chronik.
teamcity added a comment to D14748: [net processing] Remove CNode::nServices.
Build Bitcoin ABC Diffs / Diff Testing (build-win64) failed.
teamcity added a comment to D14746: [tests] Connect peer in outbound_slow_chain_eviction by sending p2p messages.
Build Bitcoin ABC Diffs / Diff Testing (build-win64) failed.
teamcity added a comment to D14752: Introduce well-defined CAddress disk serialization.
Build Bitcoin ABC Diffs / Diff Testing (build-win64) failed.
teamcity added a comment to D14753: refactor: move CAddress-without-nTime logic to net_processing.
Build Bitcoin ABC Diffs / Diff Testing (build-win64) failed.
teamcity added a comment to D14745: [net processing] Add m_our_services and m_their_services to Peer.
Build Bitcoin ABC Diffs / Diff Testing (build-win64) failed.
teamcity awarded D14748: [net processing] Remove CNode::nServices a Haypence token.
PiRK added a comment to D14748: [net processing] Remove CNode::nServices.
@bot build-win64
teamcity awarded D14746: [tests] Connect peer in outbound_slow_chain_eviction by sending p2p messages a Haypence token.
PiRK added a comment to D14746: [tests] Connect peer in outbound_slow_chain_eviction by sending p2p messages.
@bot build-win64
teamcity awarded D14745: [net processing] Add m_our_services and m_their_services to Peer a Haypence token.
PiRK added a comment to D14745: [net processing] Add m_our_services and m_their_services to Peer.
@bot build-win64
teamcity awarded D14753: refactor: move CAddress-without-nTime logic to net_processing a Haypence token.
PiRK added a comment to D14753: refactor: move CAddress-without-nTime logic to net_processing.
@bot build-win64
teamcity awarded D14752: Introduce well-defined CAddress disk serialization a Haypence token.
PiRK added a comment to D14752: Introduce well-defined CAddress disk serialization.
@bot build-win64
Amandaofthedeep awarded T351: Create an abandon-diff bot a Like token.