Feed All Stories
Nov 8 2023
Nov 8 2023
PiRK requested review of D14757: [net_processing] fix compact block related comment.
teamcity updated the summary of D14756: [net processing] Dont request compact blocks in blocks-only mode.
PiRK requested review of D14756: [net processing] Dont request compact blocks in blocks-only mode.
PiRK committed rABC81be7b59d93e: [net processing] Remove CNode::nLocalServices (authored by John Newbery <john@johnnewbery.com>).
[net processing] Remove CNode::nLocalServices
PiRK committed rABC105ec9bd23db: [net] Return CService from GetLocalAddrForPeer and GetLocalAddress (authored by dergoegge <n.goeggi@gmail.com>).
[net] Return CService from GetLocalAddrForPeer and GetLocalAddress
PiRK committed rABC3c955cd36ead: [net processing] Remove CNode::nServices (authored by John Newbery <john@johnnewbery.com>).
[net processing] Remove CNode::nServices
PiRK committed rABC6a62c795ad47: [net processing] Remove fClient and m_limited_node (authored by John Newbery <john@johnnewbery.com>).
[net processing] Remove fClient and m_limited_node
PiRK committed rABCf59dbfefff35: [net processing] Add m_our_services and m_their_services to Peer (authored by John Newbery <john@johnnewbery.com>).
[net processing] Add m_our_services and m_their_services to Peer
remove unused CAddress::Init() definition
PiRK committed rABC8808e1dd123a: [tests] Connect peer in outbound_slow_chain_eviction by sending p2p messages (authored by MacroFake <falke.marco@gmail.com>).
[tests] Connect peer in outbound_slow_chain_eviction by sending p2p messages
PiRK committed rABCb9b72a7667d2: refactor: move CAddress-without-nTime logic to net_processing (authored by Pieter Wuille <pieter@wuille.net>).
refactor: move CAddress-without-nTime logic to net_processing
PiRK committed rABC7a098167fe03: Introduce well-defined CAddress disk serialization (authored by Pieter Wuille <pieter@wuille.net>).
Introduce well-defined CAddress disk serialization
PiRK committed rABCe4a1f43c41ea: fuzz: Check for addrv1 compatibility before using serializers (authored by practicalswift <practicalswift@users.noreply.github.com>).
fuzz: Check for addrv1 compatibility before using serializers
PiRK updated the diff for D14752: Introduce well-defined CAddress disk serialization.
rebase onto D14755 and include the fuzzer changes
teamcity updated the summary of D14755: fuzz: Check for addrv1 compatibility before using serializers.
PiRK requested review of D14755: fuzz: Check for addrv1 compatibility before using serializers.
PiRK updated the test plan for D14752: Introduce well-defined CAddress disk serialization.
PiRK updated the diff for D14750: [net processing] Remove CNode::nLocalServices.
restore doxygen comment and rebase
PiRK updated the diff for D14749: [net] Return CService from GetLocalAddrForPeer and GetLocalAddress.
rebase and comment nit
PiRK updated the diff for D14747: [net processing] Remove fClient and m_limited_node.
rebase
PiRK updated the diff for D14746: [tests] Connect peer in outbound_slow_chain_eviction by sending p2p messages.
rebase, inline the CAddress serialization (D14753) and limit SendMessage to peerman
PiRK updated the diff for D14745: [net processing] Add m_our_services and m_their_services to Peer.
rebase
PiRK added a comment to D14752: Introduce well-defined CAddress disk serialization.
I can do that. I'll need https://github.com/bitcoin/bitcoin/pull/20355 first
Fabien requested changes to D14752: Introduce well-defined CAddress disk serialization.
Please run IBD as well in the test so the node runs for longer and connects many peers outside of the controlled test environment
Fabien added a comment to D14752: Introduce well-defined CAddress disk serialization.
Why didn't you backport the fuzzer change ?
Fabien requested changes to D14750: [net processing] Remove CNode::nLocalServices.
Fabien committed rABC6cab93edd473: [CI] Fix the Win64 build failing due to wine issue (authored by Fabien).
[CI] Fix the Win64 build failing due to wine issue
PiRK requested review of D14754: remove unused CAddress::Init() definition.
teamcity updated the summary of D14753: refactor: move CAddress-without-nTime logic to net_processing.
PiRK requested review of D14753: refactor: move CAddress-without-nTime logic to net_processing.
teamcity updated the summary of D14752: Introduce well-defined CAddress disk serialization.
PiRK requested review of D14752: Introduce well-defined CAddress disk serialization.
emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.
Added real time localized pricing displays per alias input, improved not null checks, added default value for aliasPAram in queryAliasServer args.
LocalString formatting applied to pricing since it's likely to eventually be a large number in prod.
Nov 7 2023
Nov 7 2023
teamcity awarded D14751: [CI] Fix the Win64 build failing due to wine issue a Haypence token.
Fabien added a comment to D14751: [CI] Fix the Win64 build failing due to wine issue.
@bot build-win64
Fabien committed rABC0f2dc0a1d6c6: [avalanche] Add invalidateavalancheproof and reconsideravalancheproof RPCs (authored by Fabien).
[avalanche] Add invalidateavalancheproof and reconsideravalancheproof RPCs
Fabien requested review of D14751: [CI] Fix the Win64 build failing due to wine issue.
bytesofman requested changes to D14728: [Cashtab][Alias] Sync pricing on new blocks.
PiRK added inline comments to D14750: [net processing] Remove CNode::nLocalServices.
PiRK updated the diff for D14750: [net processing] Remove CNode::nLocalServices.
nits
teamcity updated the summary of D14750: [net processing] Remove CNode::nLocalServices.
PiRK requested review of D14750: [net processing] Remove CNode::nLocalServices.
teamcity updated the summary of D14749: [net] Return CService from GetLocalAddrForPeer and GetLocalAddress.
PiRK requested review of D14749: [net] Return CService from GetLocalAddrForPeer and GetLocalAddress.
PiRK updated the diff for D14748: [net processing] Remove CNode::nServices.
fix rebase accident
PiRK planned changes to D14748: [net processing] Remove CNode::nServices.
teamcity updated the summary of D14748: [net processing] Remove CNode::nServices.
PiRK requested review of D14748: [net processing] Remove CNode::nServices.
PiRK updated the diff for D14745: [net processing] Add m_our_services and m_their_services to Peer.
rebase
PiRK added a comment to D14745: [net processing] Add m_our_services and m_their_services to Peer.
The test failure is a segfault in an unrelated test. I'm going to have a look at it separately, and just rerun the tests here.
PiRK updated the diff for D14747: [net processing] Remove fClient and m_limited_node.
comment style
teamcity updated the summary of D14747: [net processing] Remove fClient and m_limited_node.
PiRK requested review of D14747: [net processing] Remove fClient and m_limited_node.
teamcity added a comment to D14745: [net processing] Add m_our_services and m_their_services to Peer.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
teamcity updated the summary of D14746: [tests] Connect peer in outbound_slow_chain_eviction by sending p2p messages.
PiRK requested review of D14746: [tests] Connect peer in outbound_slow_chain_eviction by sending p2p messages.
teamcity updated the summary of D14745: [net processing] Add m_our_services and m_their_services to Peer.
PiRK requested review of D14745: [net processing] Add m_our_services and m_their_services to Peer.
PiRK committed rABC0a6c34edfd3e: [electrum] tests: raise on RPC error with proper error message (authored by EchterAgo).
[electrum] tests: raise on RPC error with proper error message
PiRK committed rABC7a8b1e4af5ed: [electrum] regtest: fix fulcrum stats query and raise timeout error in… (authored by PiRK).
[electrum] regtest: fix fulcrum stats query and raise timeout error in…
Fabien updated the diff for D14744: [avalanche] Add invalidateavalancheproof and reconsideravalancheproof RPCs.
Fix release note
Fabien added inline comments to D14744: [avalanche] Add invalidateavalancheproof and reconsideravalancheproof RPCs.
PiRK retitled D14743: [electrum] tests: raise on RPC error with proper error message from [electrum] tests: raise on RPC error or timeout error with proper error message to [electrum] tests: raise on RPC error with proper error message.
Klakurka added inline comments to D14744: [avalanche] Add invalidateavalancheproof and reconsideravalancheproof RPCs.
emack updated the diff for D14708: [Cashtab][Swap] Add swap component with SideShift integration.
Backing out extension changes
emack added inline comments to D14728: [Cashtab][Alias] Sync pricing on new blocks.
emack updated the diff for D14728: [Cashtab][Alias] Sync pricing on new blocks.
Alias.js now pulls aliasPrices as a context variable and triggers a regresh if none exist.
Nov 6 2023
Nov 6 2023
bytesofman requested changes to D14708: [Cashtab][Swap] Add swap component with SideShift integration.
This doesn't work in the extension -- prob violates the security policy pulling in scripts from another website.
Fabien requested review of D14744: [avalanche] Add invalidateavalancheproof and reconsideravalancheproof RPCs.