I reviewed the previous revision, the TODO is indeed done
Feed All Stories
Wed, Feb 19
Wed, Feb 19
Fabien added inline comments to D17676: [chronik] implement server.version electrum method.
teamcity awarded D17659: [WIP] CI investigation a Love token.
Fabien requested review of D17677: Improve reliability of abc_rpc_getavalancheproofs.
PiRK updated the diff for D17676: [chronik] implement server.version electrum method.
remove done TODO
PiRK added inline comments to D17676: [chronik] implement server.version electrum method.
PiRK updated the summary of D17676: [chronik] implement server.version electrum method.
PiRK requested review of D17676: [chronik] implement server.version electrum method.
Fabien requested review of D17675: [chronik] Consistently sync the validation queue in functional tests.
teamcity awarded D17659: [WIP] CI investigation a Like token.
Tue, Feb 18
Tue, Feb 18
teamcity triaged T3755: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Unbreak Now! priority.
teamcity awarded D17659: [WIP] CI investigation a Love token.
Fabien committed rABCc78d17424346: [avalanche] Deprecate the node availability score in the peerinfo RPC (authored by Fabien).
[avalanche] Deprecate the node availability score in the peerinfo RPC
Fabien requested review of D17674: [avalanche] Deprecate the node availability score in the peerinfo RPC.
teamcity awarded D17659: [WIP] CI investigation a Like token.
teamcity triaged T3754: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
PiRK committed rABC9205e1004401: test: Add explicit onion bind to p2p_permissions (authored by Ava Chow <github@achow101.com>).
test: Add explicit onion bind to p2p_permissions
teamcity awarded D17659: [WIP] CI investigation a Love token.
teamcity updated the summary of D17673: test: Add explicit onion bind to p2p_permissions.
PiRK requested review of D17673: test: Add explicit onion bind to p2p_permissions.
teamcity triaged T3753: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
teamcity triaged T3752: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
PiRK committed rABCe09df7e9e3ab: [chronik] Implement blockchain.scripthash.listunspent electrum method (authored by PiRK).
[chronik] Implement blockchain.scripthash.listunspent electrum method
PiRK committed rABC36570956a320: [electrum] support newer protobuf library versions (authored by PiRK).
[electrum] support newer protobuf library versions
teamcity awarded D17659: [WIP] CI investigation a Like token.
Re-enable the getavaaddr_interval_test
let's see if it pops up on CI again
PiRK requested review of D17672: [chronik] Implement blockchain.scripthash.listunspent electrum method.
Fabien requested review of D17671: Re-enable the getavaaddr_interval_test.
Fabien committed rABC6eb30eafac84: [avalanche] Deprecate the peer availability score (authored by Fabien).
[avalanche] Deprecate the peer availability score
Bump version to 0.30.12
Mon, Feb 17
Mon, Feb 17
Mengerian added a comment to D17669: [avalanche] Deprecate the peer availability score.
PiRK added a comment to D17670: [electrum] support newer protobuf library versions.
This was the error, fyi
Traceback (most recent call last):
File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/fusion.py", line 518, in run
if self.run_round(covert):
^^^^^^^^^^^^^^^^^^^^^^
File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/fusion.py", line 518, in run
if self.run_round(covert):
^^^^^^^^^^^^^^^^^^^^^^
File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/fusion.py", line 1341, in run_round
inpcomp = validate_proof_internal(
^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/validation.py", line 179, in validate_proof_internal
msg = proto_strict_parse(pb.Proof(), proofblob)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/validation.py", line 84, in proto_strict_parse
check(not msg.UnknownFields(), "has extra fields")
^^^^^^^^^^^^^^^^^^^
File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/fusion.py", line 1341, in run_round
inpcomp = validate_proof_internal(
^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/validation.py", line 179, in validate_proof_internal
msg = proto_strict_parse(pb.Proof(), proofblob)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NotImplementedError: unknown field accessor
File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/validation.py", line 84, in proto_strict_parse
check(not msg.UnknownFields(), "has extra fields")
^^^^^^^^^^^^^^^^^^^
NotImplementedError: unknown field accessorPiRK requested review of D17670: [electrum] support newer protobuf library versions.
Fabien requested review of D17669: [avalanche] Deprecate the peer availability score.
Fabien requested review of D17668: Bump version to 0.30.12.
Unknown Object (User) added a comment to D16087: [ecash-agora] Add `AgoraOneshot`.
Unknown Object (User) added a comment to D16087: [ecash-agora] Add `AgoraOneshot`.
Sun, Feb 16
Sun, Feb 16
[Cashtab] Dep upgrades
teamcity triaged T3750: Build Bitcoin-ABC / Master / Make Generator is broken. as Unbreak Now! priority.
[Automated] Update seeds
[Automated] Update chainparams
[Automated] Update timing.json
tobias_ruck committed rABCb9c39dc25864: [ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc` (authored by tobias_ruck).
[ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc`
PiRK requested changes to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
I was wrong in my previous comment, changing the name of fields in protobuf files does not break compatibility for clients of Chronik.
PiRK committed rABC0372571b7f77: [chronik] implement electrum RPC method blockchain.scripthash.get_history (authored by PiRK).
[chronik] implement electrum RPC method blockchain.scripthash.get_history
Sat, Feb 15
Sat, Feb 15
please update the ecash-lib change-log per usual version bump (link to this diff, brief description)
tobias_ruck updated the diff for D17667: [ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc`.
bump ecash-lib version
tobias_ruck updated the summary of D17667: [ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc`.
tobias_ruck requested review of D17667: [ecash-lib] Add `signRecoverable` and `recoverSig` to `Ecc`.
bytesofman published D17666: [Cashtab] Dep upgrades for review.
PiRK added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Partial review up to and including ecash-agora (just a comment nit)
PiRK added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Partial review (everything cashtab)
PiRK added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Partial review up to and including cashtab/src/airdrop/index.ts
PiRK updated the diff for D17664: [chronik] implement electrum RPC method blockchain.scripthash.get_history.
remove debugging print
Fri, Feb 14
Fri, Feb 14
roqqit committed rABC2c29ef6261c7: [avalanche] Improve API for setContenderStatusForLocalWinners (authored by roqqit).
[avalanche] Improve API for setContenderStatusForLocalWinners
Fabien requested changes to D17664: [chronik] implement electrum RPC method blockchain.scripthash.get_history.
PiRK updated the diff for D17664: [chronik] implement electrum RPC method blockchain.scripthash.get_history.
clippy
teamcity added a comment to D17664: [chronik] implement electrum RPC method blockchain.scripthash.get_history.
Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.
teamcity added a comment to D17664: [chronik] implement electrum RPC method blockchain.scripthash.get_history.
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.
PiRK requested review of D17664: [chronik] implement electrum RPC method blockchain.scripthash.get_history.
Thu, Feb 13
Thu, Feb 13
roqqit updated the diff for D17660: [avalanche] Improve API for setContenderStatusForLocalWinners.
Avoid unused pollableContenders at call sites for now
roqqit added inline comments to D17660: [avalanche] Improve API for setContenderStatusForLocalWinners.
Fabien committed rABC7ca27c8ac51b: [electrum] Sign stakes using Trezor devices (authored by Fabien).
[electrum] Sign stakes using Trezor devices
Fabien committed rABC7b83b32c468e: Make it possible to disable Tor binds and abort startup on bind failure (authored by Vasil Dimov <vd@FreeBSD.org>).
Make it possible to disable Tor binds and abort startup on bind failure
Fabien committed rABCaa54d91d30c7: Bump the block sync timeout in p2p_ibd_stalling (authored by Fabien).
Bump the block sync timeout in p2p_ibd_stalling
Fabien committed rABC87480fe74d5d: Better port collision management for the functional tests (authored by Fabien).
Better port collision management for the functional tests