Page MenuHomePhabricator
Differential D4045

Revert change to ActivateBestChain() comments made in D1182
ClosedPublic
Actions

Authored by nakihito on Sep 11 2019, 20:40.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING62ec58375ca4: Revert change to ActivateBestChain() comments made in D1182
rABC62ec58375ca4: Revert change to ActivateBestChain() comments made in D1182
Summary

Reverts changes to the comments for ActivateBestChain() in validation.cpp that were made in D1182. This reduces our code ownership and reduces merge conflicts.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
revertactivatebestchaincomment
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7408
Build 12859: Bitcoin ABC Buildbot (legacy)
Build 12858: arc lint + arc unit

Event Timeline

nakihito created this revision.Sep 11 2019, 20:40
Owners added a reviewer: Restricted Owners Package.Sep 11 2019, 20:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2019, 20:40
teamcity added a comment.Sep 11 2019, 20:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 11 2019, 20:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added a child revision: D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.Sep 11 2019, 20:42
teamcity added a comment.Sep 11 2019, 20:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 11 2019, 20:53

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7403: Diff 11224.Sep 11 2019, 20:53
jasonbcox accepted this revision.Sep 11 2019, 21:21
This revision is now accepted and ready to land.Sep 11 2019, 21:21
nakihito updated this revision to Diff 11229.Sep 11 2019, 23:50

Removed punctuation at end of comment.

teamcity added a comment.Sep 11 2019, 23:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 11 2019, 23:59

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7408: Diff 11229.Sep 11 2019, 23:59
deadalnix edited the summary of this revision. (Show Details)Sep 12 2019, 14:15
deadalnix added a comment.Sep 12 2019, 14:19

I fixed the diff's description. Don't create code blocks to put text in it.

src/validation.cpp
2850

What does this even mean?

Closed by commit rABC62ec58375ca4: Revert change to ActivateBestChain() comments made in D1182 (authored by nakihito). · Explain WhySep 19 2019, 20:28
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC62ec58375ca4: Revert change to ActivateBestChain() comments made in D1182.
nakihito mentioned this in D4138: Revert change to PreciousBlock() comment made in D1182.Sep 23 2019, 17:44
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING62ec58375ca4: Revert change to ActivateBestChain() comments made in D1182.Sep 27 2019, 22:45

Revision Contents
Changeset List

PathSize
src/
8 lines
5 lines

Diff 11229

View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...