Page MenuHomePhabricator
Differential D7147

[backport#17304 1/18] MOVEONLY: Reorder LegacyScriptPubKeyMan methods
ClosedPublic
Actions

Authored by majcosta on Aug 7 2020, 16:02.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC9e67a76f84c3: [backport#17304 1/18] MOVEONLY: Reorder LegacyScriptPubKeyMan methods
Summary

Can verify move-only with:

git log -p -n1 --color-moved

This commit is move-only and doesn't change code or affect behavior.

https://github.com/bitcoin/bitcoin/pull/17304/commits/b4cb18bce3c9a6adab2fa32f3dad4ad966b33be0

Partial backport of Core PR17304

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 7 2020, 16:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2020, 16:02
majcosta requested review of this revision.Aug 7 2020, 16:02
teamcity edited the summary of this revision. (Show Details)Aug 7 2020, 16:02

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12330: Diff 22791.Aug 7 2020, 16:19
majcosta added a child revision: D7148: [backport#17304 2/18] Refactor: Declare LegacyScriptPubKeyMan methods as virtual.Aug 7 2020, 17:47
jasonbcox accepted this revision.Aug 7 2020, 17:56
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/scriptpubkeyman.h
265 ↗(On Diff #22791)

Nit: comment styling

This revision is now accepted and ready to land.Aug 7 2020, 17:56
Closed by commit rABC9e67a76f84c3: [backport#17304 1/18] MOVEONLY: Reorder LegacyScriptPubKeyMan methods (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 8 2020, 14:13
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC9e67a76f84c3: [backport#17304 1/18] MOVEONLY: Reorder LegacyScriptPubKeyMan methods.

Revision Contents
Changeset List

PathSize
src/
wallet/
221 lines

Diff 22823

View Options

src/wallet/scriptpubkeyman.h

Loading...