Page MenuHomePhabricator

[backport#17304 3/18] Refactor: Add new ScriptPubKeyMan virtual methods
ClosedPublic

Authored by majcosta on Aug 7 2020, 16:07.

Details

Summary

This commit does not change behavior.

https://github.com/bitcoin/bitcoin/pull/17304/commits/acedc5b8230ed9ad07f96f51f0ef862ab3a41d5e


Depends on D7148

Partial backport of Core PR17304

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta requested review of this revision.Aug 7 2020, 16:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/scriptpubkeyman.cpp
222 ↗(On Diff #22793)

Nit: as the Core reviewers point out, this extra scoping is not needed. but feel free to leave it in as long as it's cleaned up or used in the rest of the stack...

This revision is now accepted and ready to land.Aug 7 2020, 19:02