Page MenuHomePhabricator
Differential D7149

[backport#17304 3/18] Refactor: Add new ScriptPubKeyMan virtual methods
ClosedPublic
Actions

Authored by majcosta on Aug 7 2020, 16:07.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC5c6f38dc131f: [backport#17304 3/18] Refactor: Add new ScriptPubKeyMan virtual methods
Summary

This commit does not change behavior.

https://github.com/bitcoin/bitcoin/pull/17304/commits/acedc5b8230ed9ad07f96f51f0ef862ab3a41d5e

Depends on D7148

Partial backport of Core PR17304

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 7 2020, 16:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2020, 16:07
majcosta requested review of this revision.Aug 7 2020, 16:07
teamcity edited the summary of this revision. (Show Details)Aug 7 2020, 16:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12332: Diff 22793.Aug 7 2020, 16:31
majcosta added a child revision: D7151: [backport#17304 4/18] Refactor: Move SetAddressBook call out of LegacyScriptPubKeyMan::GetNewDestination.Aug 7 2020, 16:54
jasonbcox accepted this revision.Aug 7 2020, 19:02
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/scriptpubkeyman.cpp
222 ↗(On Diff #22793)

Nit: as the Core reviewers point out, this extra scoping is not needed. but feel free to leave it in as long as it's cleaned up or used in the rest of the stack...

This revision is now accepted and ready to land.Aug 7 2020, 19:02
Closed by commit rABC5c6f38dc131f: [backport#17304 3/18] Refactor: Add new ScriptPubKeyMan virtual methods (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 8 2020, 15:33
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC5c6f38dc131f: [backport#17304 3/18] Refactor: Add new ScriptPubKeyMan virtual methods.

Revision Contents
Changeset List

PathSize
src/
wallet/
25 lines
25 lines
17 lines

Diff 22825

View Options

src/wallet/scriptpubkeyman.h

Loading...
View Options

src/wallet/scriptpubkeyman.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...