Differential D7155

[backport#17304 8/18] refactor: Replace UnsetWalletFlagWithDB with UnsetBlankWalletFlag in ScriptPubKeyMan
ClosedPublic
Actions

Authored by majcosta on Aug 7 2020, 17:04.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC09a9643db9bc: [backport#17304 8/18] refactor: Replace UnsetWalletFlagWithDB with…

Summary

ScriptPubKeyMan is only using UnsetWalletFlagWithDB to unset the blank
wallet flag. Just make that it's own function and not expose the flag
writing directly.

This does not change behavior.

https://github.com/bitcoin/bitcoin/pull/17304/commits/fc2867fdf50f47e5ad5f43445e500e3a477a8074

Depends on D7154

Partial backport of Core PR17304

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 7 2020, 17:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2020, 17:04

majcosta requested review of this revision.Aug 7 2020, 17:04

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7156: [backport#17304 9/18] Refactor: Move SetAddressBookWithDB call out of LegacyScriptPubKeyMan::ImportScriptPubKeys.Aug 7 2020, 17:09

Harbormaster completed remote builds in B12338: Diff 22799.Aug 7 2020, 17:23

jasonbcox accepted this revision.Aug 7 2020, 19:43

This revision is now accepted and ready to land.Aug 7 2020, 19:43

Closed by commit rABC09a9643db9bc: [backport#17304 8/18] refactor: Replace UnsetWalletFlagWithDB with… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 8 2020, 19:17

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC09a9643db9bc: [backport#17304 8/18] refactor: Replace UnsetWalletFlagWithDB with….

Revision Contents
Changeset List

Path

Size

src/

wallet/

2 lines

9 lines

5 lines

4 lines

Diff 22830

View Options

src/wallet/scriptpubkeyman.h

View Options

src/wallet/scriptpubkeyman.cpp

View Options

src/wallet/wallet.h

View Options

[backport#17304 8/18] refactor: Replace UnsetWalletFlagWithDB with UnsetBlankWalletFlag in ScriptPubKeyManClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22830

src/wallet/scriptpubkeyman.h

src/wallet/scriptpubkeyman.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

[backport#17304 8/18] refactor: Replace UnsetWalletFlagWithDB with UnsetBlankWalletFlag in ScriptPubKeyMan
ClosedPublic
Actions

Revision Contents
Changeset List