Differential D7164

[backport#17304 17/18] Refactor: Move GetKeypoolSize code out of CWallet
ClosedPublic
Actions

Authored by majcosta on Aug 7 2020, 17:24.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABCbe3af3b67479: [backport#17304 17/18] Refactor: Move GetKeypoolSize code out of CWallet

Summary

This commit does not change behavior.

https://github.com/bitcoin/bitcoin/pull/17304/commits/7ef47b88e67718766c92d23973742d08436176e0

Depends on D7163

Partial backport of Core PR17304

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 7 2020, 17:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2020, 17:25

majcosta requested review of this revision.Aug 7 2020, 17:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7165: [backport#17304 18/18] Refactor: Move nTimeFirstKey accesses out of CWallet.Aug 7 2020, 17:27

Harbormaster completed remote builds in B12347: Diff 22808.Aug 7 2020, 17:56

jasonbcox accepted this revision.Aug 8 2020, 00:15

This revision is now accepted and ready to land.Aug 8 2020, 00:15

Closed by commit rABCbe3af3b67479: [backport#17304 17/18] Refactor: Move GetKeypoolSize code out of CWallet (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 8 2020, 19:58

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCbe3af3b67479: [backport#17304 17/18] Refactor: Move GetKeypoolSize code out of CWallet.

Revision Contents
Changeset List

Path

Size

src/

wallet/

2 lines

5 lines

9 lines

10 lines

Diff 22839

View Options

src/wallet/scriptpubkeyman.h

View Options

src/wallet/scriptpubkeyman.cpp

View Options

src/wallet/wallet.h

View Options

[backport#17304 17/18] Refactor: Move GetKeypoolSize code out of CWalletClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22839

src/wallet/scriptpubkeyman.h

src/wallet/scriptpubkeyman.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

[backport#17304 17/18] Refactor: Move GetKeypoolSize code out of CWallet
ClosedPublic
Actions

Revision Contents
Changeset List