Differential D7152

[backport#17304 5/18] Refactor: Move SetWalletFlag out of LegacyScriptPubKeyMan::UpgradeKeyMetadata
ClosedPublic
Actions

Authored by majcosta on Aug 7 2020, 16:59.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC31181accc23d: [backport#17304 5/18] Refactor: Move SetWalletFlag out of LegacyScriptPubKeyMan…

Summary

This commit does not change behavior.

https://github.com/bitcoin/bitcoin/pull/17304/commits/4c5491f99c6b8ca779c48be63eb2ba18d98ee52a

Depends on D7151

Partial backport of Core PR17304

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 7 2020, 16:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2020, 16:59

majcosta requested review of this revision.Aug 7 2020, 16:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7153: [backport#17304 6/18] Remove SetWalletFlag from WalletStorage.Aug 7 2020, 17:00

Harbormaster completed remote builds in B12335: Diff 22796.Aug 7 2020, 17:14

jasonbcox accepted this revision.Aug 7 2020, 19:14

This revision is now accepted and ready to land.Aug 7 2020, 19:14

Closed by commit rABC31181accc23d: [backport#17304 5/18] Refactor: Move SetWalletFlag out of LegacyScriptPubKeyMan… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 8 2020, 16:41

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC31181accc23d: [backport#17304 5/18] Refactor: Move SetWalletFlag out of LegacyScriptPubKeyMan….

Revision Contents
Changeset List

Path

Size

src/

wallet/

scriptpubkeyman.cpp

4 lines

wallet.cpp

5 lines

Diff 22827

View Options

src/wallet/scriptpubkeyman.cpp