Page MenuHomePhabricator
Differential D7148

[backport#17304 2/18] Refactor: Declare LegacyScriptPubKeyMan methods as virtual
ClosedPublic
Actions

Authored by majcosta on Aug 7 2020, 16:05.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC65b5027b77c9: [backport#17304 2/18] Refactor: Declare LegacyScriptPubKeyMan methods as virtual
Summary

This commit does not change behavior.

https://github.com/bitcoin/bitcoin/pull/17304/commits/533d8b364f4e589aa1acb28cdea5e6e6e80d34dc

Depends on D7147

Partial backport of Core PR17304

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 7 2020, 16:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2020, 16:05
majcosta requested review of this revision.Aug 7 2020, 16:05
teamcity edited the summary of this revision. (Show Details)Aug 7 2020, 16:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7149: [backport#17304 3/18] Refactor: Add new ScriptPubKeyMan virtual methods.Aug 7 2020, 16:07
Harbormaster completed remote builds in B12331: Diff 22792.Aug 7 2020, 16:23
majcosta edited the summary of this revision. (Show Details)Aug 7 2020, 17:47
majcosta added a parent revision: D7147: [backport#17304 1/18] MOVEONLY: Reorder LegacyScriptPubKeyMan methods.
jasonbcox accepted this revision.Aug 7 2020, 18:54
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/scriptpubkeyman.h
168 ↗(On Diff #22792)

Nit: fix comment style

This revision is now accepted and ready to land.Aug 7 2020, 18:54
Closed by commit rABC65b5027b77c9: [backport#17304 2/18] Refactor: Declare LegacyScriptPubKeyMan methods as virtual (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 8 2020, 15:27
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC65b5027b77c9: [backport#17304 2/18] Refactor: Declare LegacyScriptPubKeyMan methods as virtual.

Revision Contents
Changeset List

PathSize
src/
wallet/
33 lines

Diff 22824

View Options

src/wallet/scriptpubkeyman.h

Loading...