Differential D7156

[backport#17304 9/18] Refactor: Move SetAddressBookWithDB call out of LegacyScriptPubKeyMan::ImportScriptPubKeys
ClosedPublic
Actions

Authored by majcosta on Aug 7 2020, 17:09.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABCf1019d150830: [backport#17304 9/18] Refactor: Move SetAddressBookWithDB call out of…

Summary

This commit does not change behavior.

https://github.com/bitcoin/bitcoin/pull/17304/commits/67be6b9e213da1fd7b2e8438c445c5a64092e831

Depends on D7155

Partial backport of Core PR17304

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 7 2020, 17:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2020, 17:09

majcosta requested review of this revision.Aug 7 2020, 17:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7157: [backport#17304 10/18] Refactor: Move LoadKey LegacyScriptPubKeyMan method definition.Aug 7 2020, 17:11

Harbormaster completed remote builds in B12339: Diff 22800.Aug 7 2020, 17:28

jasonbcox accepted this revision.Aug 7 2020, 19:45

This revision is now accepted and ready to land.Aug 7 2020, 19:45

Closed by commit rABCf1019d150830: [backport#17304 9/18] Refactor: Move SetAddressBookWithDB call out of… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 8 2020, 19:39

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCf1019d150830: [backport#17304 9/18] Refactor: Move SetAddressBookWithDB call out of….

Revision Contents
Changeset List

Path

Size

src/

wallet/

scriptpubkeyman.h

5 lines

scriptpubkeyman.cpp

8 lines

wallet.cpp

14 lines

Diff 22831

View Options

src/wallet/scriptpubkeyman.h

View Options

src/wallet/scriptpubkeyman.cpp

View Options

[backport#17304 9/18] Refactor: Move SetAddressBookWithDB call out of LegacyScriptPubKeyMan::ImportScriptPubKeysClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22831

src/wallet/scriptpubkeyman.h

src/wallet/scriptpubkeyman.cpp

src/wallet/wallet.cpp

[backport#17304 9/18] Refactor: Move SetAddressBookWithDB call out of LegacyScriptPubKeyMan::ImportScriptPubKeys
ClosedPublic
Actions

Revision Contents
Changeset List