Differential D7151

[backport#17304 4/18] Refactor: Move SetAddressBook call out of LegacyScriptPubKeyMan::GetNewDestination
ClosedPublic
Actions

Authored by majcosta on Aug 7 2020, 16:54.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC7814f68f17f1: [backport#17304 4/18] Refactor: Move SetAddressBook call out of…

Summary

This commit does not change behavior.

https://github.com/bitcoin/bitcoin/pull/17304/commits/769acef85730a6c0e2f5603fbd673b176c2d34d0

Depends on D7149

Partial backport of Core PR17304

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 7 2020, 16:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2020, 16:54

majcosta requested review of this revision.Aug 7 2020, 16:54

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7152: [backport#17304 5/18] Refactor: Move SetWalletFlag out of LegacyScriptPubKeyMan::UpgradeKeyMetadata.Aug 7 2020, 16:59

Harbormaster completed remote builds in B12334: Diff 22795.Aug 7 2020, 17:09

jasonbcox accepted this revision.Aug 7 2020, 19:10

This revision is now accepted and ready to land.Aug 7 2020, 19:10

Closed by commit rABC7814f68f17f1: [backport#17304 4/18] Refactor: Move SetAddressBook call out of… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 8 2020, 16:05

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC7814f68f17f1: [backport#17304 4/18] Refactor: Move SetAddressBook call out of….

Revision Contents
Changeset List

Path

Size

src/

wallet/

scriptpubkeyman.h

8 lines

scriptpubkeyman.cpp

4 lines

wallet.cpp

7 lines

Diff 22826

View Options

src/wallet/scriptpubkeyman.h

View Options

src/wallet/scriptpubkeyman.cpp

View Options

[backport#17304 4/18] Refactor: Move SetAddressBook call out of LegacyScriptPubKeyMan::GetNewDestinationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22826

src/wallet/scriptpubkeyman.h

src/wallet/scriptpubkeyman.cpp

src/wallet/wallet.cpp

[backport#17304 4/18] Refactor: Move SetAddressBook call out of LegacyScriptPubKeyMan::GetNewDestination
ClosedPublic
Actions

Revision Contents
Changeset List