Differential D7153

[backport#17304 6/18] Remove SetWalletFlag from WalletStorage
ClosedPublic
Actions

Authored by majcosta on Aug 7 2020, 17:00.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC1b72f8e38659: [backport#17304 6/18] Remove SetWalletFlag from WalletStorage

Summary

SetWalletFlag is unused.

Does not change any behavior

https://github.com/bitcoin/bitcoin/pull/17304/commits/0391aba52dcc33613295fd6099c804ac7134b063

Depends on D7152

Partial backport of Core PR17304

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 7 2020, 17:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2020, 17:00

majcosta requested review of this revision.Aug 7 2020, 17:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7154: [backport#17304 7/18] Refactor: Remove UnsetWalletFlag call from LegacyScriptPubKeyMan::SetHDSeed.Aug 7 2020, 17:01

Harbormaster completed remote builds in B12336: Diff 22797.Aug 7 2020, 17:16

jasonbcox accepted this revision.Aug 7 2020, 19:17

This revision is now accepted and ready to land.Aug 7 2020, 19:17

Closed by commit rABC1b72f8e38659: [backport#17304 6/18] Remove SetWalletFlag from WalletStorage (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 8 2020, 18:55

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC1b72f8e38659: [backport#17304 6/18] Remove SetWalletFlag from WalletStorage.

Revision Contents
Changeset List

Path

Size

src/

wallet/

scriptpubkeyman.h

1 line

wallet.h

2 lines

Diff 22828

View Options

src/wallet/scriptpubkeyman.h