Differential D7160

[backport#17304 13/18] Refactor: Move Upgrade code out of CWallet::CreateWalletFromFile
ClosedPublic
Actions

Authored by majcosta on Aug 7 2020, 17:18.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC362966c0db55: [backport#17304 13/18] Refactor: Move Upgrade code out of CWallet…

Summary

This commit does not change behavior.

https://github.com/bitcoin/bitcoin/pull/17304/commits/8b0d82bb428de9e7f1da7c61574e7a8376a62d43

Depends on D7159

Partial backport of Core PR17304

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 7 2020, 17:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2020, 17:18

majcosta requested review of this revision.Aug 7 2020, 17:18

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7161: [backport#17304 14/18] Refactor: Move HavePrivateKeys code out of CWallet::CreateWalletFromFile.Aug 7 2020, 17:20

Harbormaster completed remote builds in B12343: Diff 22804.Aug 7 2020, 17:42

jasonbcox accepted this revision.Aug 8 2020, 00:02

This revision is now accepted and ready to land.Aug 8 2020, 00:02

Closed by commit rABC362966c0db55: [backport#17304 13/18] Refactor: Move Upgrade code out of CWallet… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 8 2020, 19:56

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC362966c0db55: [backport#17304 13/18] Refactor: Move Upgrade code out of CWallet….

Revision Contents
Changeset List

Path

Size

src/

wallet/

5 lines

34 lines

4 lines

30 lines

Diff 22835

View Options

src/wallet/scriptpubkeyman.h

View Options

src/wallet/scriptpubkeyman.cpp

View Options

src/wallet/wallet.h

View Options

[backport#17304 13/18] Refactor: Move Upgrade code out of CWallet::CreateWalletFromFileClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22835

src/wallet/scriptpubkeyman.h

src/wallet/scriptpubkeyman.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

[backport#17304 13/18] Refactor: Move Upgrade code out of CWallet::CreateWalletFromFile
ClosedPublic
Actions

Revision Contents
Changeset List